From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA1E6C35274 for ; Thu, 21 Dec 2023 22:07:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18C326B0078; Thu, 21 Dec 2023 17:07:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13C986B007E; Thu, 21 Dec 2023 17:07:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF7C56B0081; Thu, 21 Dec 2023 17:07:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DD80A6B0078 for ; Thu, 21 Dec 2023 17:07:28 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AA94A1A0CE9 for ; Thu, 21 Dec 2023 22:07:28 +0000 (UTC) X-FDA: 81592212576.04.4632A81 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 6160240009 for ; Thu, 21 Dec 2023 22:07:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SaTNK5cZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703196446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XwNzjzjYlQ4OkFShh9gjuNoM97Y9E8n3hq50jUuedQg=; b=C6WVo0lAXgEnajueL9UUVh8qsPdpRy4+OXjblcqBaEphkuHACNE3pEyiAo+Pv/ObRzLkFJ pHfobRNbhMUB40QcH+PjIHEEVrYIVl6T9jGh0mbKl+GoEV6ZGOWxdz9JhLjYKDVSe6bWUp H9t8ivmf+vkogUF3Hd9WxvQ3HCB1hZQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SaTNK5cZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703196446; a=rsa-sha256; cv=none; b=GVeT7KjUdJWfhHnww3R3Ph5NfwtsfCfGo1G2KTY93pK4N2/4LXZ3tNGhcpYs1izp/2jT1b qVxGqpUBZyusd94WpIyQXDTmovHmOFd4vIsxEP7qiR2q4Ozxo7qzgSYz40gtB4uYnZPDEz 4iy4z6JcDs8TTW2ff1yHki3xVvZP80g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703196445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XwNzjzjYlQ4OkFShh9gjuNoM97Y9E8n3hq50jUuedQg=; b=SaTNK5cZ+UeRLSkZw5Po3aCJTlwEf3uFGkYhpMjGCp2fD78pFNkjy9Ez0Ui/mmzRaCOUHq q15/GslXIAJBw810A+NaBi5v0qdlwOv4kYemyL9NPToOJ4F2Wwf3T4C9Rq94x0fTq0Ssew MUyLQssbDNtVo07Wid2QoXwUen4u0Ig= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-jX4MQ-dwMj-4HqXjBKBkYg-1; Thu, 21 Dec 2023 17:07:24 -0500 X-MC-Unique: jX4MQ-dwMj-4HqXjBKBkYg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3367e2bd8b0so790151f8f.1 for ; Thu, 21 Dec 2023 14:07:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703196443; x=1703801243; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XwNzjzjYlQ4OkFShh9gjuNoM97Y9E8n3hq50jUuedQg=; b=c5VerREYcVJzy7SwaMkUIBg2MyFZ0m1yCBo+MyWR3jBMoC85/z1aoNNZjGvqFsuWjx 7Sc3ae5EKnGRccLCfiUrGGuozrOY31uWXZxg2xJi9i1t5fdNMuqE9T+CWmdQVmFUD2KM piKF9pEwmh86cGMP+Ouq/6IHiITDbuICxLaP5YpR391qHy7ws4hRwclL3r3XVicZSWbc 5InE2BR4pAF0h3bSO8CSyQjYf7N6nAzlsZboqFO1Z0iyjzD31gvJwsCd/KzbX+UJAlKa 4c25k65SSLvaJMl6FE6R4cWS1AdddRbpuDOwmFp/Y5Q6w0Drr0F+lnJD4dkaXaJsxzG4 aA4A== X-Gm-Message-State: AOJu0YwQ3DNVtAHx4u5EOBrvNEx/6ta3iPyXOcwZPHLcVJ49aAhbEeYH Dje8J+m5u/WWpAKySnl4S7+R5UkKAOQzRxnstTQ2HX4vCAZr6sMKiwZ/Wm8V74SxmmwuXd9b/i8 /etDiX39wywOsw2zxXZ8= X-Received: by 2002:a5d:408d:0:b0:336:60ae:3c4a with SMTP id o13-20020a5d408d000000b0033660ae3c4amr209954wrp.112.1703196443050; Thu, 21 Dec 2023 14:07:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrqGvmGJc7L4wlEO6kkWusGFqDludRg58uGUHX+hhpjjEjAe2cgCdCdshbEAo35Q/ZkPJMpw== X-Received: by 2002:a5d:408d:0:b0:336:60ae:3c4a with SMTP id o13-20020a5d408d000000b0033660ae3c4amr209948wrp.112.1703196442632; Thu, 21 Dec 2023 14:07:22 -0800 (PST) Received: from ?IPV6:2003:cb:c743:7b00:745e:8663:4f85:318a? (p200300cbc7437b00745e86634f85318a.dip0.t-ipconnect.de. [2003:cb:c743:7b00:745e:8663:4f85:318a]) by smtp.gmail.com with ESMTPSA id t18-20020a5d4612000000b003367bb8898dsm2879751wrq.66.2023.12.21.14.07.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 14:07:22 -0800 (PST) Message-ID: <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com> Date: Thu, 21 Dec 2023 23:07:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [mm] bbcbf2a3f0: kernel_BUG_at_mm/memory.c To: Andrew Morton Cc: Oliver Sang , Matthew Wilcox , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , linux-kernel@vger.kernel.org References: <202312192319.fa8f5709-oliver.sang@intel.com> <20231220141135.cb4241442b657104f0aeae34@linux-foundation.org> <20231221135833.92b8b2a97b28ad0545977f6c@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231221135833.92b8b2a97b28ad0545977f6c@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 8mbk6wu5fg4c3mgfpxpfy86x6aawyo6z X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6160240009 X-HE-Tag: 1703196446-731229 X-HE-Meta: U2FsdGVkX18nL8pFKv5m7IR3jDYCGDvP0hnjNGcFvsorn5iV0WkK1oiCVcOYTirqG+AR6xoNyN+GsdOWy0mLqyVhi3qd1R08Y1VwSrX4Ea74LzDyutCWnKbD/7FcJHKiohB5Zhf/vfXGMT4wM2f3Q2fSgCSjpbO+XNT1h3d9GEK3HDjIwYRUbu3JAfr3fnvOdqysIsjXw3VlQz+08vH55F35uppdlZ+ZQOfj+hHr67KHcmhfP5rdYk7lkgvgOendmIwwjpnNnAMq0ptW4DV/QXBkaFY+jC++iqTYT/fig+qVtbM1Vq7NSRd9Txf+ZTj6z342wxJaCYvw0tYyb7K3GnXSflKjDuTpbPZziphs5RuTSW/dV426jRemzskqFxgq0IKC7i+a3wgCrWzOLtAJpV3M5kd6B0u/2OKMJMi+ym/D4v/VCG3xk0Zu7fSRrJf971t5l04yEBTFi6GnIwc7ar4slEbwyArwndVhtzhI09acanLTyrEnjpTAA8fgsb8VAw42/XSM6D9JcgzIpP6Mr55HjTTT8fg4d5Lml2OPGgll6d5EUSmXcT8K1s5d67GoErS/LwhK83u2uIohGKu7R7/ajhM+CbI0F9G0v+RefHxgPhfmtNeV24W2jOfccv2n8CfORlI3cOBPEkYeU4r7SbUd91zOe3uEXlZ2TIVVAPKiDEDEMhFzZom2DQ95EfJLlo+647bZ5nbMweyYwpitdMmnb73BolngV9hnpVcTO4+cCeZ/Ho859iP37c2WYWacD7uvtznuaWy3HTqZxfabCmQr3Azw282xkW5zUmxvBc30hO2oRHG8TLQF0uxol6lbr5E2GxbHcJjUxJW7N+WiE05Le9aVLDnNC+I/9GY7DtL3ZJqgv9gRpfkMI85qQEAnLueJ+ovTL7WluXgecNBM52NdZLsiy6O7O3MF7GcLFCFzfB9IfNmCi7IccpAsVpjoz5iCjp8oqYs14geP2i2 5D/n3BB7 E2t3asVKheCz/xptQ3EliVu2N6fy0FN5wmss8cIR0fSdWEo++YpQZiMn4dghqfFIbLdMHBUlPkoGpPRXXSCXdRvnwrVIRoypCAaegK7IrvZGdaZnSl3/zBklXorIHFFKLZUuG24ef3b1DFG6gf52eBZ+b/wMh6TpwQnM+sdG04WQPudoddKunnWc5luCxAs4t7UVXuXwHlQRLZo9ST88n4cp13c5MKhdBSl0i1HMFCzZGvK+QKnVUnVJrV6mHys+T0mfwAMua/s8aaNUGEfTQZSlydtlmkKsazpi9vMZ6rdD8jTo9ZVbUshhB1X9S8OnWdqLIuVuYGLjtfACq9dKTiYJPyL7Ujy5NKA42JAO/cdhKQkXX8IhzymxgpDbKES6ga73i5wk/g3T0QtH7ihhw1HuGTgf43XUTQfio/SkZ2nqzRB1mNDHOlfSSBGFSrjhX9zOMKvtiXB1TqOfZukew3YDb+AQAYt91u+ie X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.12.23 22:58, Andrew Morton wrote: > On Thu, 21 Dec 2023 12:32:04 +0100 David Hildenbrand wrote: > >> On 21.12.23 12:23, Oliver Sang wrote: >>> hi, Andrew Morton, >>> >>> On Wed, Dec 20, 2023 at 02:11:35PM -0800, Andrew Morton wrote: >>>> On Tue, 19 Dec 2023 23:46:50 +0800 kernel test robot wrote: >>>> >>>>> >>>>> >>>>> Hello, >>>>> >>>>> kernel test robot noticed "kernel_BUG_at_mm/memory.c" on: >>>>> >>>>> commit: bbcbf2a3f05f74f9d268eab57abbdce6a65a94ad ("mm: convert ksm_might_need_to_copy() to work on folios") >>>> >>>> I assume this is a bisection result, so it's quite repeatable? >>> >>> yes, we bisect to this commit, it's quite repeatable: >>> >>> ddd06bb63d9793ce bbcbf2a3f05f74f9d268eab57ab >>> ---------------- --------------------------- >>> fail:runs %reproduction fail:runs >>> | | | >>> :6 100% 6:6 dmesg.Kernel_panic-not_syncing:Fatal_exception >>> :6 100% 6:6 dmesg.RIP:do_swap_page >>> :6 100% 6:6 dmesg.invalid_opcode:#[##] >>> :6 100% 6:6 dmesg.kernel_BUG_at_mm/memory.c >>> >>> >> >> Can you try with the snipped I sent? Please let me know if you need a >> full patch for testing purposes. > > I think a full patch would be better, please. > From b82e309096abde6c0f24bba50a281e8d3855c132 Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Thu, 21 Dec 2023 23:04:30 +0100 Subject: [PATCH] Fixup: mm: convert ksm_might_need_to_copy() to work on folios We must only adjust the page if the folio changed. Otherwise, if we had a large folio in the swapcache and the folio didn't change, we'd suddenly change the page to-be-mapped. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202312192319.fa8f5709-oliver.sang@intel.com Signed-off-by: David Hildenbrand --- mm/memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index 149f779910fd5..2f9668d357f5c 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3952,7 +3952,8 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) folio = swapcache; goto out_page; } - page = folio_page(folio, 0); + if (folio != swapcache) + page = folio_page(folio, 0); /* * If we want to map a page that's in the swapcache writable, we -- 2.43.0 -- Cheers, David / dhildenb