From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE00BC433F5 for ; Tue, 14 Dec 2021 16:50:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18D9C6B0081; Tue, 14 Dec 2021 11:39:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13D056B0082; Tue, 14 Dec 2021 11:39:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 004776B0083; Tue, 14 Dec 2021 11:39:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id E75976B0081 for ; Tue, 14 Dec 2021 11:39:58 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B24D9180BA53B for ; Tue, 14 Dec 2021 16:39:48 +0000 (UTC) X-FDA: 78916961256.06.90AC8E1 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf10.hostedemail.com (Postfix) with ESMTP id B511DC000C for ; Tue, 14 Dec 2021 16:39:44 +0000 (UTC) Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JD3rr2f4Rz67YrM; Wed, 15 Dec 2021 00:35:24 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 17:39:46 +0100 Received: from [10.47.83.94] (10.47.83.94) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 16:39:45 +0000 Subject: Re: [PATCH v2 09/11] iommu/iova: Consolidate flush queue code To: Robin Murphy , , CC: , , , , , References: From: John Garry Message-ID: <6a7605f8-af54-4547-d108-7fdeda678b6e@huawei.com> Date: Tue, 14 Dec 2021 16:39:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.83.94] X-ClientProxiedBy: lhreml701-chm.china.huawei.com (10.201.108.50) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B511DC000C X-Stat-Signature: ty6xn4wzgggjprha8xknziy7yp84g17a Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com X-Rspamd-Server: rspam11 X-HE-Tag: 1639499984-794055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/12/2021 17:54, Robin Murphy wrote: > Squash and simplify some of the freeing code, and move the init > and free routines down into the rest of the flush queue code to > obviate the forward declarations. > It would be good to get rid of all of these eventually... > Signed-off-by: Robin Murphy > --- FWIW: Reviewed-by: John Garry