From: Christoph Lameter <cl@gentwo.de>
To: Baoquan He <bhe@redhat.com>
Cc: Wupeng Ma <mawupeng1@huawei.com>,
akpm@linux-foundation.org, tj@kernel.org, dennis@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc
Date: Sun, 4 Dec 2022 17:21:44 +0100 (CET) [thread overview]
Message-ID: <6a732c63-125e-c033-3869-87dea6c53e8f@gentwo.de> (raw)
In-Reply-To: <Y4yOMmnrT772wFSL@MiWiFi-R3L-srv>
On Sun, 4 Dec 2022, Baoquan He wrote:
> Can we change the conditional checking in fail part as below?
Yes please. This is potentially a rare condition that should get some
visibility.
next prev parent reply other threads:[~2022-12-04 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 3:14 Wupeng Ma
2022-12-04 12:11 ` Baoquan He
2022-12-04 16:21 ` Christoph Lameter [this message]
2022-12-05 0:30 ` Dennis Zhou
2022-12-05 2:24 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a732c63-125e-c033-3869-87dea6c53e8f@gentwo.de \
--to=cl@gentwo.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawupeng1@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox