From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56698C77B7A for ; Mon, 12 Jun 2023 01:08:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EB4D6B0072; Sun, 11 Jun 2023 21:08:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89A476B0074; Sun, 11 Jun 2023 21:08:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AFAB6B0075; Sun, 11 Jun 2023 21:08:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6CCBA6B0072 for ; Sun, 11 Jun 2023 21:08:53 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 38DCD1C782A for ; Mon, 12 Jun 2023 01:08:53 +0000 (UTC) X-FDA: 80892311346.25.D04B037 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf03.hostedemail.com (Postfix) with ESMTP id B481E20007 for ; Mon, 12 Jun 2023 01:08:49 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686532131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oinWm7F0ELK0p0hulKynsmD17K9+9ZXzoCXUbEZw2QA=; b=4/rYebOKkrDTR8xnv2NZA3lqeIxzkcwjO5Xau7Bai5RRhPg3brF31MB8cmjK6KyRbzfBtK qwRqZwVvo3onwpzMmwEBufkPsUxYFWFT5vZO30Z89Ga1Vfqvj1Zy6ufHnGbK6mxHoDgn+z EpXttJJBOy/ahEpM7/XGMChtlKxOFoE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686532131; a=rsa-sha256; cv=none; b=p7rxo2BNaHexdCCgamNMU/kfvgvT1v0OIdEYKzqxHK7rt5PNGdfS5qcRYaPIvx/2QzdY8N hyo3DlGm3qUyiXJvG1k56DvlDBvVs644RaTODiQCV/PxMT78F15T4iJjsbV5nMN6cWGzPg Gx5gVCDICFg1wkjQyAxA/EzSqDUNTdc= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QfYQY1B0qzLq8l; Mon, 12 Jun 2023 09:05:41 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 09:08:44 +0800 Message-ID: <6a72d06d-4570-864c-ee3f-12edd9458f03@huawei.com> Date: Mon, 12 Jun 2023 09:08:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] mm: kill [add|del]_page_to_lru_list() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , References: <20230609013901.79250-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B481E20007 X-Stat-Signature: by7ypnrmswtr388rhzdb8jsggd3x4wmt X-Rspam-User: X-HE-Tag: 1686532129-833353 X-HE-Meta: U2FsdGVkX1+keVEJ6GHgKw0nGVXFotc7LgGMyFRvrGErei2Kjvh7sSsvvQZHGcSe3YAbWCcXzAuMRGPCNnPQI5xdCCPfx48Dd1fySIcy+pDgNcZs39DojGLPx054Lfc1YOmZjo75ilpGY0ZZWZUIjLvodJd6UB5d5nA34AOvTCt8IwHthTYW49PNQpdF2+G9CiuqYWbbAb4QiV4y4Otp6eeN7/BuF0LAye+0vaIG44aVv68cBVs74KVcr3w9bH2NdgSwhilYZa2i6L4fFUxMROjYQ6N4pEFuc63MV7ooYe2Rf+53mQWPAslERLvByiECF1ptA0iwg5YOQp1PjDbwHUUgl91fEQL8s+zPZGOiYZoUgkmXj8sXN9FBzDn9RzZrbBQljigTCB9rJmjV+cx+TIxMLlDugR2HeWgzZ7+6ZESJZLjxpvvqhlBM6GgpBpR6CAMG4ff5+R3rxQX5QEiIlvS9OVSM22cKslDdJIjX44spM3iru1V9G1oHJv48zP6hxlagoK7TsDsxhBI0cwh5jJQkM95ELkHpsuuWDmEEnEl14NGxemdgwaoBS7lJsLdaVYqqTpHOnm3GkMqHh0ILYOKVxhHuJAa5m0sQtqmlP4izlFkKHtFiqI3sCPnfpO9cfblaDKtYjKDAtegW702nazcntuqjup7t4OLNqg2lFbOSdvkUW+hT/x3374Dz65/JJsa6/LpVK+E8AKb7vKmiWOsT8geLBvFBBEyHuBIux+unEeFmxyWy8Z445nq7xlVwZDtzMm+rUbqk5P1WDTMPsdlscJfXT6oWfsBeEhqxlWCPqiCNlhPfgmfb4iAgogNw8Ttzu4Brs37WPXyGHVLzsVSVoUgZnBi2JIRF+rfnMZV0EX1FjLuj5O9Mw6pbrk6eWJhp/RKjLkabeY0s86fgU36eC0CcjH/qe8UN2rv8pYdDKO5ZWLbQOUq7x+17MxDVGVhayYsgD1X8snuhnhP 0V5eHrQZ aheDHbxGHGTJ30yO/LMyPfVMyatxWquPQZ0uzB84/TYSmG3vu4wJoLRzC0ZdWtR1i45T/d9AvOxmi5Dj0+SvvKBsQv6PvfJZLRA1QgGvnXORQEhMqjeEro82WapfEamaZA/gGGBfzG6x1Jv2tuGQaSqoOpoZQ1WZUh4bUwTNRMVeTS0TYseBwa/iMYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/10 1:18, Matthew Wilcox wrote: > On Fri, Jun 09, 2023 at 09:39:01AM +0800, Kefeng Wang wrote: >> Directly call lruvec_del_folio(), and drop unused page interfaces. > > Convert isolate_migratepages_block() to actually use folios and > then we can kill the interfaces. > >> +++ b/mm/compaction.c >> @@ -1145,7 +1145,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, >> low_pfn += compound_nr(page) - 1; >> >> /* Successfully isolated */ >> - del_page_from_lru_list(page, lruvec); >> + lruvec_del_folio(lruvec, page_folio(page)); > > This kind of thing is not encouraged. It's just churn and gets in > the way of actual conversions. Sure, thanks for your suggestion, will convert isolate_migratepages_block() firstly. >