From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: kill [add|del]_page_to_lru_list()
Date: Mon, 12 Jun 2023 09:08:44 +0800 [thread overview]
Message-ID: <6a72d06d-4570-864c-ee3f-12edd9458f03@huawei.com> (raw)
In-Reply-To: <ZINe7xJPI3s6HJG4@casper.infradead.org>
On 2023/6/10 1:18, Matthew Wilcox wrote:
> On Fri, Jun 09, 2023 at 09:39:01AM +0800, Kefeng Wang wrote:
>> Directly call lruvec_del_folio(), and drop unused page interfaces.
>
> Convert isolate_migratepages_block() to actually use folios and
> then we can kill the interfaces.
>
>> +++ b/mm/compaction.c
>> @@ -1145,7 +1145,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
>> low_pfn += compound_nr(page) - 1;
>>
>> /* Successfully isolated */
>> - del_page_from_lru_list(page, lruvec);
>> + lruvec_del_folio(lruvec, page_folio(page));
>
> This kind of thing is not encouraged. It's just churn and gets in
> the way of actual conversions.
Sure, thanks for your suggestion, will convert
isolate_migratepages_block() firstly.
>
prev parent reply other threads:[~2023-06-12 1:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 1:39 Kefeng Wang
2023-06-09 17:14 ` Yu Zhao
2023-06-09 17:18 ` Matthew Wilcox
2023-06-12 1:08 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a72d06d-4570-864c-ee3f-12edd9458f03@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox