From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61ACC47077 for ; Thu, 11 Jan 2024 04:05:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 129E28D0001; Wed, 10 Jan 2024 23:05:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B2796B00A0; Wed, 10 Jan 2024 23:05:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6CA38D0001; Wed, 10 Jan 2024 23:05:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D190F6B009F for ; Wed, 10 Jan 2024 23:05:54 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5B04A0486 for ; Thu, 11 Jan 2024 04:05:54 +0000 (UTC) X-FDA: 81665691828.26.32DB01B Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf01.hostedemail.com (Postfix) with ESMTP id B7B774000C for ; Thu, 11 Jan 2024 04:05:51 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=q90eKb7K; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of yonghong.song@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=yonghong.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704945952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oe8y6rx2nxJCVb5v6A3KEWIfmf39eOlQDxZDCZDQpSs=; b=IDrg2nugZ9TxQ4VecdUc6qaZlo9xWuzMfQDZfyGnDrOZuO6QRbGpl39lyu+4W4nT8n8tGn OcvQoUZBIkyFE221VgCdCuuHawCaXKW/jaRpE3uMoSgjuavf96nh3ei2W+dyWnKf6FVnCr Yo6Ujv37otNC+tsqFrd9/C9lPg7oJl0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=q90eKb7K; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of yonghong.song@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=yonghong.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704945952; a=rsa-sha256; cv=none; b=ZtmszhiUY98a2B4PZ1+NyDt0/KFK36UcKuQmnJh2OplW/7Fbjltk8u5WauJqO2vuiz3/yU 53fgzUZHfMHvLWuU2wn9fWzB+krea95UfyfvqpLXDcB6cOKvx5Rtwz42VOxUvUpQRR3+os Bzp3F8WZnsAebBhcRuFhjtEbm3Dk4oA= Message-ID: <6a655e9f-9878-4292-9d16-f988c4bdfc73@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704945949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oe8y6rx2nxJCVb5v6A3KEWIfmf39eOlQDxZDCZDQpSs=; b=q90eKb7K7E7fJPyeOkcWuuQTXMX/wft3oCBjOBhlyiFmrgkyKMUJJweJzGZ7ubFNp8EHyV GcPbNwdLXwLn7SNydULG8Gy/XrORJnr8NctjugZkNqq03qyefn2lSAbUGAAVNkmDZdUytt a026lbDO23xBpkhnXEJJxhDMfDKiHMo= Date: Wed, 10 Jan 2024 20:05:36 -0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links Content-Language: en-GB To: Nathan Chancellor , akpm@linux-foundation.org Cc: llvm@lists.linux.dev, patches@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-efi@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, bridge@lists.linux.dev, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, mykolal@fb.com, bpf@vger.kernel.org References: <20240109-update-llvm-links-v1-0-eb09b59db071@kernel.org> <20240109-update-llvm-links-v1-1-eb09b59db071@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20240109-update-llvm-links-v1-1-eb09b59db071@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B7B774000C X-Stat-Signature: 3dohp6c6h1mxmq7k8ezwixrqwwd545ny X-Rspam-User: X-HE-Tag: 1704945951-9494 X-HE-Meta: U2FsdGVkX1+qL6nr/4Ib36Q2J8MjWTsxwS6vMjXY07BD8OvM64FOJflqU/dNFUOxSFOKRPAEskYVTQ0ALqLycQPTIBVK4nQwVnCHXrTwDElFrb14dVsfEc6uhwdiy4dKZd2Pksqs0UyVr3tHTvUOq3yo/q3Fc8omfIfWglLeMwh3DPbGu0eMTJURbMZ73e7XP1NWgQTYFi+rBvou4TZbmHgHzQwHV8f2ae/HjSGoGJ1pc5IU44Fc2Fv+MqhqqZ0lsYuUMCthc857nPwEdo0W+NZq4hsqpaJ1U+73T3Xc18UMbR2X3uKOfaZrQimbaud1pT31tKnWZ/p6ZaXMqubFmBvonyflMJKYiyRFwFAjLkJ7fOfnwLEJLOKHr8WZBKzFz8H9P/Z6VaMZuf027ZV47vZb5oFudSvNVmelm6IFI/8VZc96zW/DLufsl3YW5XyIc9yP7uRXj2SlCwhPuNHLO7nY++T7WvyOgbqprv8GrnnAJpdHNispnmJtill4V9u33xASoset0o6JN77sVEb4HHkpVYR6hSF/fQuSCErl+X8g4mJYuw1BADlJPBdrwd34OOvWmbUjIOblf2N6vGYLE4F2xtZqrnpsWCiy/4gZ7RoDnb6F+iOVxhIQjOjZUAfqzi4dadN0Hy0MuHaBcBQmJr/gJ3nkpAC6OD2CM/a8GVIOttJq8/jUPpTxz8K0f+NITYfQwvWEeE/2vO/T8qm9qaGuI5TNrNjJ+vdlEff60owU8ANe9ADDJEc7twRzTmzJB2cCPqcuTO9GbzSKhrXNLWJi5ZJSeOd7Y/dXVezk3aNaZmM8RBlvsZxlo0ijI0M9xUrAX+aYs0LP7Zb6/JCW4m+kdUcazuzzW+wlKxldTgiocRUredYhXA+3pRCAbTNSkNQu0vB9h1DrAkxkL1Ljz6UUSidDaXFola+bS83P7tpEc6b4B/i1UIm+CHAR0iuYsr7y6x817oyKBLC3JA0 uz/higYa 9qATRmA5ougvBaAhpamnnVSpWHHoY+d2ix7crxgf1pdT4VjYNOtmIf8o/anYWR3eLxnZ9s/qPGdNcU/Ps3nPS9RESy1NynHWGu7oNJqSB3okXkOy7TpOgc9wgYnzg/eXfJxJXybZEJDPy8jPVMWloaV/WZxJpbiNroJJ+1yjVYKnth838n6nk2pCGwmRV5aJUdP0qB+CfnbLm0XvPoTR1sxJ4gSER1g40N/tJRne+vI1+ms+SMeV/YeN9F7q8o3M81Yi5HZPtXrVMc1AxwlR2J21CrR5K3LykT7Rhd/fDQF2HPHpX36f9ghJYSAi/Mmj+ZbsqMJlnA5WWkfpruMPsrdmet3rgu7OFDJRh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/9/24 2:16 PM, Nathan Chancellor wrote: > reviews.llvm.org was LLVM's Phabricator instances for code review. It > has been abandoned in favor of GitHub pull requests. While the majority > of links in the kernel sources still work because of the work Fangrui > has done turning the dynamic Phabricator instance into a static archive, > there are some issues with that work, so preemptively convert all the > links in the kernel sources to point to the commit on GitHub. > > Most of the commits have the corresponding differential review link in > the commit message itself so there should not be any loss of fidelity in > the relevant information. > > Additionally, fix a typo in the xdpwall.c print ("LLMV" -> "LLVM") while > in the area. > > Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 > Signed-off-by: Nathan Chancellor Ack with one nit below. Acked-by: Yonghong Song > --- > Cc: ast@kernel.org > Cc: daniel@iogearbox.net > Cc: andrii@kernel.org > Cc: mykolal@fb.com > Cc: bpf@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > --- > tools/testing/selftests/bpf/README.rst | 32 +++++++++++----------- > tools/testing/selftests/bpf/prog_tests/xdpwall.c | 2 +- > .../selftests/bpf/progs/test_core_reloc_type_id.c | 2 +- > 3 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/tools/testing/selftests/bpf/README.rst b/tools/testing/selftests/bpf/README.rst > index cb9b95702ac6..b9a493f66557 100644 > --- a/tools/testing/selftests/bpf/README.rst > +++ b/tools/testing/selftests/bpf/README.rst > @@ -115,7 +115,7 @@ the insn 20 undoes map_value addition. It is currently impossible for the > verifier to understand such speculative pointer arithmetic. > Hence `this patch`__ addresses it on the compiler side. It was committed on llvm 12. > > -__ https://reviews.llvm.org/D85570 > +__ https://github.com/llvm/llvm-project/commit/ddf1864ace484035e3cde5e83b3a31ac81e059c6 > > The corresponding C code > > @@ -165,7 +165,7 @@ This is due to a llvm BPF backend bug. `The fix`__ > has been pushed to llvm 10.x release branch and will be > available in 10.0.1. The patch is available in llvm 11.0.0 trunk. > > -__ https://reviews.llvm.org/D78466 > +__ https://github.com/llvm/llvm-project/commit/3cb7e7bf959dcd3b8080986c62e10a75c7af43f0 > > bpf_verif_scale/loop6.bpf.o test failure with Clang 12 > ====================================================== > @@ -204,7 +204,7 @@ r5(w5) is eventually saved on stack at insn #24 for later use. > This cause later verifier failure. The bug has been `fixed`__ in > Clang 13. > > -__ https://reviews.llvm.org/D97479 > +__ https://github.com/llvm/llvm-project/commit/1959ead525b8830cc8a345f45e1c3ef9902d3229 > > BPF CO-RE-based tests and Clang version > ======================================= > @@ -221,11 +221,11 @@ failures: > - __builtin_btf_type_id() [0_, 1_, 2_]; > - __builtin_preserve_type_info(), __builtin_preserve_enum_value() [3_, 4_]. > > -.. _0: https://reviews.llvm.org/D74572 > -.. _1: https://reviews.llvm.org/D74668 > -.. _2: https://reviews.llvm.org/D85174 > -.. _3: https://reviews.llvm.org/D83878 > -.. _4: https://reviews.llvm.org/D83242 > +.. _0: https://github.com/llvm/llvm-project/commit/6b01b465388b204d543da3cf49efd6080db094a9 > +.. _1: https://github.com/llvm/llvm-project/commit/072cde03aaa13a2c57acf62d79876bf79aa1919f > +.. _2: https://github.com/llvm/llvm-project/commit/00602ee7ef0bf6c68d690a2bd729c12b95c95c99 > +.. _3: https://github.com/llvm/llvm-project/commit/6d218b4adb093ff2e9764febbbc89f429412006c > +.. _4: https://github.com/llvm/llvm-project/commit/6d6750696400e7ce988d66a1a00e1d0cb32815f8 > > Floating-point tests and Clang version > ====================================== > @@ -234,7 +234,7 @@ Certain selftests, e.g. core_reloc, require support for the floating-point > types, which was introduced in `Clang 13`__. The older Clang versions will > either crash when compiling these tests, or generate an incorrect BTF. > > -__ https://reviews.llvm.org/D83289 > +__ https://github.com/llvm/llvm-project/commit/a7137b238a07d9399d3ae96c0b461571bd5aa8b2 > > Kernel function call test and Clang version > =========================================== > @@ -248,7 +248,7 @@ Without it, the error from compiling bpf selftests looks like: > > libbpf: failed to find BTF for extern 'tcp_slow_start' [25] section: -2 > > -__ https://reviews.llvm.org/D93563 > +__ https://github.com/llvm/llvm-project/commit/886f9ff53155075bd5f1e994f17b85d1e1b7470c > > btf_tag test and Clang version > ============================== > @@ -264,8 +264,8 @@ Without them, the btf_tag selftest will be skipped and you will observe: > > # btf_tag:SKIP > > -.. _0: https://reviews.llvm.org/D111588 > -.. _1: https://reviews.llvm.org/D111199 > +.. _0: https://github.com/llvm/llvm-project/commit/a162b67c98066218d0d00aa13b99afb95d9bb5e6 > +.. _1: https://github.com/llvm/llvm-project/commit/3466e00716e12e32fdb100e3fcfca5c2b3e8d784 > > Clang dependencies for static linking tests > =========================================== > @@ -274,7 +274,7 @@ linked_vars, linked_maps, and linked_funcs tests depend on `Clang fix`__ to > generate valid BTF information for weak variables. Please make sure you use > Clang that contains the fix. > > -__ https://reviews.llvm.org/D100362 > +__ https://github.com/llvm/llvm-project/commit/968292cb93198442138128d850fd54dc7edc0035 > > Clang relocation changes > ======================== > @@ -292,7 +292,7 @@ Here, ``type 2`` refers to new relocation type ``R_BPF_64_ABS64``. > To fix this issue, user newer libbpf. > > .. Links > -.. _clang reloc patch: https://reviews.llvm.org/D102712 > +.. _clang reloc patch: https://github.com/llvm/llvm-project/commit/6a2ea84600ba4bd3b2733bd8f08f5115eb32164b > .. _kernel llvm reloc: /Documentation/bpf/llvm_reloc.rst > > Clang dependencies for the u32 spill test (xdpwall) > @@ -304,6 +304,6 @@ from running test_progs will look like: > > .. code-block:: console > > - test_xdpwall:FAIL:Does LLVM have https://reviews.llvm.org/D109073? unexpected error: -4007 > + test_xdpwall:FAIL:Does LLVM have https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5? unexpected error: -4007 > > -__ https://reviews.llvm.org/D109073 > +__ https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d To be consistent with other links, could you add the missing last alnum '5' to the above link? > diff --git a/tools/testing/selftests/bpf/prog_tests/xdpwall.c b/tools/testing/selftests/bpf/prog_tests/xdpwall.c > index f3927829a55a..4599154c8e9b 100644 > --- a/tools/testing/selftests/bpf/prog_tests/xdpwall.c > +++ b/tools/testing/selftests/bpf/prog_tests/xdpwall.c > @@ -9,7 +9,7 @@ void test_xdpwall(void) > struct xdpwall *skel; > > skel = xdpwall__open_and_load(); > - ASSERT_OK_PTR(skel, "Does LLMV have https://reviews.llvm.org/D109073?"); > + ASSERT_OK_PTR(skel, "Does LLVM have https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5?"); > > xdpwall__destroy(skel); > } > diff --git a/tools/testing/selftests/bpf/progs/test_core_reloc_type_id.c b/tools/testing/selftests/bpf/progs/test_core_reloc_type_id.c > index 22aba3f6e344..6fc8b9d66e34 100644 > --- a/tools/testing/selftests/bpf/progs/test_core_reloc_type_id.c > +++ b/tools/testing/selftests/bpf/progs/test_core_reloc_type_id.c > @@ -80,7 +80,7 @@ int test_core_type_id(void *ctx) > * to detect whether this test has to be executed, however strange > * that might look like. > * > - * [0] https://reviews.llvm.org/D85174 > + * [0] https://github.com/llvm/llvm-project/commit/00602ee7ef0bf6c68d690a2bd729c12b95c95c99 > */ > #if __has_builtin(__builtin_preserve_type_info) > struct core_reloc_type_id_output *out = (void *)&data.out; >