From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E479EB64DD for ; Fri, 21 Jul 2023 15:47:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A340E8D0001; Fri, 21 Jul 2023 11:47:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E3E26B0072; Fri, 21 Jul 2023 11:47:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 884A48D0001; Fri, 21 Jul 2023 11:47:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 783D56B0071 for ; Fri, 21 Jul 2023 11:47:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3B93C1A030B for ; Fri, 21 Jul 2023 15:47:58 +0000 (UTC) X-FDA: 81036049836.22.A39D123 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by imf04.hostedemail.com (Postfix) with ESMTP id E5D0A40021 for ; Fri, 21 Jul 2023 15:47:55 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=ZFzNJsmb; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=2cpUgxQH; dmarc=none; spf=pass (imf04.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689954476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BvQYir1TgtFJ0697wOUYpEwh4jkIy8qXO/mCyyCNVlQ=; b=CoY6S/hFJWm/jLSi/SfB3Iz8ko/KTxeGfiiyNUp2tqnnMbNiSuvrjMLRL6e7fVnGXJ8HyI FJTJ1346Z76NhQrZkAEiRwj5+TzIYGLheacpzYqM5oiQw1bGaqVzO1SvzCsTqH7VKi5mwj O6PeVpuYiOsW9F6GCOj7v3kJjSS4044= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=ZFzNJsmb; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=2cpUgxQH; dmarc=none; spf=pass (imf04.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689954476; a=rsa-sha256; cv=none; b=WHSnk0sEo5TSCOrb+3Wof/Wi4knJQx05k8J1rGhyyr6Cijh8xr3U2s2hgdYdkszf2Q0Lmz SEwtWsN1X2uamfkLM2JyFuFLw6RvMeoGgIR82hNLIpwJLb5EEF4y9EvOybBeA4NkbSlxLg jeVLFgMIxqmsEGi43nWVBlBwjzf88vI= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3C0F13200991; Fri, 21 Jul 2023 11:47:53 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 21 Jul 2023 11:47:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1689954472; x=1690040872; bh=Bv QYir1TgtFJ0697wOUYpEwh4jkIy8qXO/mCyyCNVlQ=; b=ZFzNJsmblah8v7+tzm pvg9g9dqG78Pn972Bj1F9+KdCSDjD3uCQRDbYndZTShRtg30fkvYoGTX8P5lCB46 amLI52y80joBeKH6pyCgpfjdaq0xPRw7e2W30qv4Ij55F8YeiOKSnasFJW4MGuCv oTnQkGeeoPWcGXdS6GihL2mTvgvJSb14frr/X8stZ0DZyj/x5Th5eWypwQN+RyFN FqUrhyyKa672B3D4H3rqyaXoXIhaeatnIHVcWCGuIjuiGm+yEoB+LnolbrxCrt+J /Ludj38mG9YTSkcsHT57dP3tMIP0UAiU4rfPIvFGZOXOhHdoVedfDlqiz4gV5QXV 7oSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689954472; x=1690040872; bh=BvQYir1TgtFJ0 697wOUYpEwh4jkIy8qXO/mCyyCNVlQ=; b=2cpUgxQHdTe/oGeCxgK/z1dXdvf0r nI+DJk6sCYQkGXyawb5ZLMqaVBDvd4ux5LwWHEfbwULXqJQOK/cseoRhc0eTTMF2 32Xr6K7VYAMBkTdtPFBSrsYOpL/hbhOrAmtx24BYkby0b6gGWl7MKFPBhcmFF6gb E0PP4klBMjk6e8WkGZ7Kcrn2Y5sncq/JzkKLFAfOdAvw+xGfY5MQY/OWYlfTV5Vp Xa+gvtB4HtjIu/zx1jkyCKHkuVsAYxsZ7XS9WXxDBP3r0FL8OWf4zt/nreHyPMaf fxo5yvljEbV0XiZpxIdaT26boEgMjEzY0XDt+pTEl7bCgHSGoIrz7xkPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrhedvgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 297B9B60089; Fri, 21 Jul 2023 11:47:52 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0 Mime-Version: 1.0 Message-Id: <6a49b585-05d0-4b79-b5ab-d710f5d6d598@app.fastmail.com> In-Reply-To: <20230721105743.819362688@infradead.org> References: <20230721102237.268073801@infradead.org> <20230721105743.819362688@infradead.org> Date: Fri, 21 Jul 2023 17:47:31 +0200 From: "Arnd Bergmann" To: "Peter Zijlstra" , "Thomas Gleixner" , "Jens Axboe" Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" , "Darren Hart" , dave@stgolabs.net, andrealmeid@igalia.com, "Andrew Morton" , urezki@gmail.com, "Christoph Hellwig" , "Lorenzo Stoakes" , linux-api@vger.kernel.org, linux-mm@kvack.org, Linux-Arch , malteskarupke@web.de Subject: Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags Content-Type: text/plain X-Rspamd-Queue-Id: E5D0A40021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7zef5qzdrbqie1qongborpkgbfm3whnd X-HE-Tag: 1689954475-921440 X-HE-Meta: U2FsdGVkX18TkJq3FgQs9VrhTWVRZPjtzR+nigTIjE+N7pgiE2UNN4CDj6+lWMmcehWEMEcY/bbWDmMR8niSPWeDURSfoeXC5kCyoSY2kxPYj8bMCo5lgA8A20J4Ej+EwYUpaecoj/4/uwKhk38pMKBeJjZTRdL7hnC2iB5CYUH6h2r3yPs9eWw8Y2BXbsm/2LoAgttyMHm7WqFDyqJMYiKVI/h2RF0y06zJlTpZx8n4lE/WVHHiXbPvZyGiZHK+Sg67MYen/X7je/jS7S104jcM+72+V8423swqhpdLQRDkMV50YSCNoiarxfiK7YljNc4p+c2Zeo0ZZNJoB9yD6Lw9fg13Enx45CrRLemdGSKcwwI/pXPIQSbgjVcQmNuHO6DT9c9crkN/wzYM78joIN7uOgFY19qidV6C5OrRR8VHS8TNlRD8I2wV5m34DGWEB7EWHNMrvMA9wONWIQGBriKiw57MP5trQmdONVb4RtCsrJFrQwpTz1ErJ0YZdkRyjOaJ+D3C42E+rdq28BV/NBeNm1Kn/eGSuA/JsZ4UAhQ4uNk8w9ZiyFeeeBGlNAaXWaCLXAbSnI52JTMqFHbnCLiZ3Q3LCvmC/1MBl01NUruAb6CCx9jjB7XzOnASERyBeDLdGTQEjDupWlmziXFYwxwUcN759piHM8eXDO94qogJdOwKn+zw3HWXY/wbmXwk2gFyodtoFiZgGbt8ZVGXn+qFFdlSimsWFs0RpLjC08TIwrWVvmx9P22yjgrG8AbCcRlFXp1HcQZA+iBNHIUadaa31TMn6d/9xTwZDZKbY/xng4udm2wrWEY2NgM5EGqMINKwVnbKm56gWxg9tGo/s3moPpm2NXrJVz+iADE4JbRJx7pttiex1Z3ZfQIhfGME1kNzhMNixx9UyuK6XojrB5IFca/s+N8WnM0yXpcp7wlWuP6hXY3qpcvTY/JhN8LaZ7LNgjMipQXI4Iz0Ekv ya85rUAn sViHNvKff16vU+1RpTuC1RCXwDzTZz4ECCF0iDYnkzJhGqeuVeLC5AIkCMRcK7xCPYpcZjO7oX/0KTVa/YY5zD6bHwOEWoKaUqR1HoN42YgmZ9aOk2pFoWynC6Cc5r9JlOPenPaHWW4EjwfjDLHRnOKaEdhwdsz307cEGgTUDZldWMys= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21, 2023, at 12:22, Peter Zijlstra wrote: > * futex_parse_waitv - Parse a waitv array from userspace > @@ -207,7 +207,12 @@ static int futex_parse_waitv(struct fute > if ((aux.flags & ~FUTEX2_MASK) || aux.__reserved) > return -EINVAL; > > - if (!(aux.flags & FUTEX2_32)) > + if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) { > + if ((aux.flags & FUTEX2_64) == FUTEX2_64) > + return -EINVAL; > + } > + > + if ((aux.flags & FUTEX2_64) != FUTEX2_32) > return -EINVAL; This looks slightly confusing, how about defining another FUTEX2_SIZEMASK (or similar) macro to clarify that "aux.flags & FUTEX2_64" is a mask operation that can match the FUTEX2_{8,16,32,64} values? Arnd