From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D6ED1038E for ; Fri, 25 Oct 2024 00:41:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C9FD6B0092; Thu, 24 Oct 2024 20:41:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 479206B0093; Thu, 24 Oct 2024 20:41:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 368BA6B0095; Thu, 24 Oct 2024 20:41:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 16A546B0092 for ; Thu, 24 Oct 2024 20:41:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2EE64C0259 for ; Fri, 25 Oct 2024 00:41:26 +0000 (UTC) X-FDA: 82710270888.07.0ADC9BD Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf19.hostedemail.com (Postfix) with ESMTP id C9F5B1A0012 for ; Fri, 25 Oct 2024 00:41:19 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729816735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0M3IFM1zQzKkx9VKuGY4yMfwAYPlP6kTbNkBa90eQb0=; b=Jj01sRjZz2nnxI5TdlkNnIaqUp2dOCjevCkoPoivugHLJeUny+OEK/e0IKa8hdnoh9ww9N cFRwSiD7eLaaGeO0Vv/AAynGrxBlmTaPriO3w/Jb9AfoU60GW4OO/BZ4GHPxWo+5EcYwop bR9b6U4tCbJu5lMp9LtwIf7knrJ8RY0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729816735; a=rsa-sha256; cv=none; b=uXN8ZltZLRR7EdblMpyE3ZxXr/ZQeM+2MWzQuCWiXk3lzteK2ZyKMnYgbIRb8QOaCHdbKU eEN3Mn825pH/0XET0K82Cf0oQh4JCcMewp9yAiTt0OvwfeJbP9qt8yoE7fh/4Q+KoqQbWZ 011tl33Va3gARE4dQdIyeHLL64lHx04= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XZP7y4P9Qz1jvvn; Fri, 25 Oct 2024 08:40:14 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 9EF11180043; Fri, 25 Oct 2024 08:41:39 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 25 Oct 2024 08:41:39 +0800 Message-ID: <6a3640b3-20f1-4d98-8e82-5a98b2d64930@huawei.com> Date: Fri, 25 Oct 2024 08:41:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: always use base address when clear gigantic page From: Kefeng Wang To: Andrew Morton CC: David Hildenbrand , Matthew Wilcox , Muchun Song , "Huang, Ying" , Linux MM References: <20241024124436.3419497-1-wangkefeng.wang@huawei.com> <58f6a052-8b0a-4c1b-88c5-d3a462acc0af@huawei.com> Content-Language: en-US In-Reply-To: <58f6a052-8b0a-4c1b-88c5-d3a462acc0af@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C9F5B1A0012 X-Stat-Signature: hsegy5gi9h134ubtj63pf3hwjsmcatb1 X-Rspam-User: X-HE-Tag: 1729816879-718519 X-HE-Meta: U2FsdGVkX181GEcdWRPuNkcF6WcJeRWmmFZiUsC0Z2GLpy4TxP+646Jjy/ScDvcsCOCVxSNEIRVtxmeImccogJ6JKKmC5marXcSny9AMCXefkC8pXKAXBTXV9bsjqM7FkFCEpUHQKt2GaN3OhVt8xdWosXl02zK7EhLrHh/Z0Takbo3DskOa6Do84/H6zXbNGtOxUX1O0RkdTywNLXvMUn4v/FeA9vChhxffZBDRUOqKHNxddxq+fhefT0ovbFa10xaS8y3t8CPR0riVK2aaHrAG1aFNtvocmd/T4Pczeapd0IzixBugvZAGdi1ZN6PPrvAhox3F/MMecgpFEzN0bxaMLqMNS7utrx125EHbY3mKVPqulCG+qPNVfaS7kYfUO04SJgtwdqTGGT1qkNoYXUadEn+8DYO0WUJrMpwGZb5X9mIXE2+TH4xTsIaTsLBVMtJ8tNjnkH/jMWzGjsRCU0mRrcpzYDrHr6K+cOxOTbdXYsKj7VcIFs+9M1ZdNHdbvkAGnQfgnLqmweeDCxoT+lww+Z5E5zkFSnPL7TmFNcAfUSM9htqdMdi8Qmxc1qmtMmMTkrbMzZpPXniok86En1OcNrLRE3BSTMavMc12FG9g2t/8DUOkEfQ28PiEMrVV2hUdAGjMMAaeBmoV4WNo8PLAUAaZ7EuyUqYfCFL0ySQEtr6IN8Z7rnDwC4hhyvENxgunpdD16LsTlbWv+gpI3bi92V225/sY2ZzkyuOuT+KrbNOvC8t+1nVVAO96EmH6+qsiBrIBxMyHdGXlZ+xX/VWZjamXbDNhM2TjilcQamjJVVbShgVMYV/1AUiDVLPXciLCRj4RJQSqYK4avHV78lMZ967B1wHvXcySCezd2XwmjARnsrp3A63D/fBxhpJCd+WmiYRtlAUbBe3Bi6Gxg97hz9FLPFGRRMCPskD6bq5aDLNnUOqqxPba4by9d9yCl/VJJBRUTTqmkJ0Fj4+ zuLFzQs/ PBZ3zdHoeDZa/JjMFFF1CXLmKOBWBhW5u89Yx11BcwRGVJbjMZQEgGHp5hJA2Jz84fsGJEk8hXLaqjWn27g/idQnYgG+iJUQA8kH3RXLxFI9BOQwdfAIMCdnivIBBhCzcLlOGuQW8ouxr9HYmfqPTsgNfbW2nl+gQATlvsuAFJpsHt46RpKOnc/1BAEfmo+hzR9EhRwyESoZ/bdmsIXqOX2kdmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/24 20:45, Kefeng Wang wrote: > +cc maillist Please ignore this series, sorry for the noise, let me resend all patches with correct cc list. > > On 2024/10/24 20:44, Kefeng Wang wrote: >> When clear gigantic page, it zeros page from the first subpage to >> the last subpage, that is, aligned base address is needed in it, >> and we don't need to aligned down the address in the caller as the >> real address will be passed to process_huge_page(). >> >> Fixes: 78fefd04c123 ("mm: memory: convert clear_huge_page() to >> folio_zero_user()") >> Signed-off-by: Kefeng Wang >> --- >>   fs/hugetlbfs/inode.c | 2 +- >>   mm/memory.c          | 1 + >>   2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index a4441fb77f7c..a5ea006f403e 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -825,7 +825,7 @@ static long hugetlbfs_fallocate(struct file *file, >> int mode, loff_t offset, >>               error = PTR_ERR(folio); >>               goto out; >>           } >> -        folio_zero_user(folio, ALIGN_DOWN(addr, hpage_size)); >> +        folio_zero_user(folio, addr); >>           __folio_mark_uptodate(folio); >>           error = hugetlb_add_to_page_cache(folio, mapping, index); >>           if (unlikely(error)) { >> diff --git a/mm/memory.c b/mm/memory.c >> index 48e534aa939c..934ab5fff537 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -6802,6 +6802,7 @@ static void clear_gigantic_page(struct folio >> *folio, unsigned long addr, >>       int i; >>       might_sleep(); >> +    addr = ALIGN_DOWN(addr, folio_size(folio)); >>       for (i = 0; i < nr_pages; i++) { >>           cond_resched(); >>           clear_user_highpage(folio_page(folio, i), addr + i * >> PAGE_SIZE); > >