From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB429C77B73 for ; Thu, 20 Apr 2023 02:47:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44A196B0071; Wed, 19 Apr 2023 22:47:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FAE86B0072; Wed, 19 Apr 2023 22:47:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2FD6B0074; Wed, 19 Apr 2023 22:47:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1F0676B0071 for ; Wed, 19 Apr 2023 22:47:06 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E3BD6160416 for ; Thu, 20 Apr 2023 02:47:05 +0000 (UTC) X-FDA: 80700232410.07.6E24AFE Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf06.hostedemail.com (Postfix) with ESMTP id 5DB0918000E for ; Thu, 20 Apr 2023 02:47:03 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=doyqjWx+; spf=pass (imf06.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681958824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ONGcsQhQe5EvPEMRGVWXOw89umdmRiF62BqlC5adKeI=; b=kk0SUG6aA7s8dtQDQJsndoAbc8wcPWU3+zAhqxv/Pcgyg0RzwGbgou03qYqCBqXEBCqZEo gUlrSZVWKZXhHsziBHOXd+ePDKtXLbdGk6353/uf3NsddlZ5js7ft/N02X/ZFykalZwpKy Fvtv50VELoWNsOwmyC014UtkQ4Ss3dA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=doyqjWx+; spf=pass (imf06.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681958824; a=rsa-sha256; cv=none; b=oRkTy8jN1KyUZyBaNf7+cpZUK3acKY5fBxNh85cWirSGtyoIgmtXOxkaVpMOqyshLwxUYt P4BUjKmfjpxZDPRtvADmnnTitihQZ2y3ZNjCmagmfge0oikkAkjQNIvr52jN9hyEwOnF4C JKuJJ7IE2y3anzCJMe5ER3WUMw//bQM= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1a814fe0ddeso6929665ad.2 for ; Wed, 19 Apr 2023 19:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1681958822; x=1684550822; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ONGcsQhQe5EvPEMRGVWXOw89umdmRiF62BqlC5adKeI=; b=doyqjWx+2bTIsT9FbRCU0F581ywpOcsJmoTejK2QuOP6Owg0kPKux89cd2wp/LQVF0 3mTPmTC6/peMzHNY+2spKZjC46AXrjhckyWYLQgCfesJBcvteL/dmg/GcKibc2/zmD+e xbScjemnl1cw7HSGj+7F1N7EqZQBKBU9EZQF74Y2APqGsKgIa3AN2ZhrNfygbkr30S7d G14hinuZt7Vtd7kdQ0NmWI0ZCSSSJesV0BrpVHsVSP1Fg+48oFyFAW1gwwwATuZHBT48 Af97GHaGEmaW9tzwwDa6wQS63i1n3sl5YdiQU+YhC1/25FrY6O0CiZmfy8hwJIOLTZuV zKTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681958822; x=1684550822; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ONGcsQhQe5EvPEMRGVWXOw89umdmRiF62BqlC5adKeI=; b=Z2CGSws7KOdfMM75NGu6xJR8ocVdPwYXFdDpgHW2vB8ppRAn1U9KkayB2Pqus8Auo+ N6BLEC8otbAk4at60xYaRJNFUVlGYZQsxGJfmYHiqlWJmKCALmVetA0F4VnoQI+/+5b7 PmpFUQlqPx62JKPU8lE5kHvRE8bGUF/SmyUKi9m8JSGYGEUhsO5wlGuyREu76Rgk/+e0 O/L+Si7g+kBUE7wOHLkIg5Lw0mWLT+Ia8eSenxp7ojWsCZ9/OuDDrpzUac9KU2TIx9tw Man16LWZRY7YDZC4JvwZHrKussSY0jCvYQ1PIkDzFvk++9PWYnZzI5X+Yd0b+5qidQ8q mYfw== X-Gm-Message-State: AAQBX9feoVtLzO4m6NxsC5iakXUxIJuE1Ar6T/Q5XUYgLR1ok/avRms5 tUg5U0I+Q4XjWWeRvimHpHTZxA== X-Google-Smtp-Source: AKy350bDwyoIChbds7xq1ecwfOCztzTynvx7cLW+ChaUaqWIqLPh7uhf6YD22ulu7zYqyDP6h2ZDOA== X-Received: by 2002:a17:903:18f:b0:19a:b427:230a with SMTP id z15-20020a170903018f00b0019ab427230amr8253487plg.63.1681958822010; Wed, 19 Apr 2023 19:47:02 -0700 (PDT) Received: from [10.200.10.217] ([139.177.225.248]) by smtp.gmail.com with ESMTPSA id d4-20020a170902b70400b001a681d123a0sm114401pls.297.2023.04.19.19.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 19:47:01 -0700 (PDT) Message-ID: <6a24bc86-0c19-b8c9-2e27-86282ee07171@bytedance.com> Date: Thu, 20 Apr 2023 10:46:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] maple_tree: Fix allocation in mas_sparse_area() To: Andrew Morton Cc: Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org References: <20230419093625.99201-1-zhangpeng.00@bytedance.com> <20230419124902.7cb9b5c54afa37736e7b0e3a@linux-foundation.org> From: Peng Zhang In-Reply-To: <20230419124902.7cb9b5c54afa37736e7b0e3a@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5DB0918000E X-Stat-Signature: yxdfqch1dryfn5kbegrfzxtx4rqt3ubx X-Rspam-User: X-HE-Tag: 1681958823-508478 X-HE-Meta: U2FsdGVkX196kzlaXVJQUi1T8x0XweiRhvRxTviUqzE0yLwSr4Qu+Xw4V+zOKkSMxqJrO3IvWTZ/AIBwRmSoMdW8iuYXfr1C7w5xDoibVV2vRGeBj5QJo71ggMkDI8W4+QYw1VWJCRwUjFKiTbqXUjLb73HK+XIzvqcqO2DT6bIFCnYdgyidhkNo9uwLSIlBcN9C9l/6MoECDv4w8ZmYTsJG4AC/GKU+lUVgL0+fQEw2nKBQY1987JhM6Fx+M1noHoPczDujFDpC/aE1ZRps0b8TDq/QJFUrYaT2kkNA5cZ7NafyPR2Y3JVfzqTl7oEBlzcJIhsmNAZbg5vYb522SZJi1LUaDsBypq209ofR1fWCseNk1V6lhGKL1OpJZnV7sqNqCC5DrvRw8bMMlE+mwGYlRmI5J2NvYXffoG3GcAvHCq9aVPeMba5j1Jg8/NwmBQmu0/LfBlbMSxRwJb92r6EFB4gzwWVHaIENxZSIj2e/u2tR/rHBrje9XKG06nIbPxhN08BNJEVY/wWvQ+zttSWoWfg+Zc9G/1bBDE3ZDMJ/tk7SIq/QHoWFvrEEl/4USFruOArJBAwCVFtu/D+sCROFMTNFeaY8xFoWTr0gq/WWqoUs5dQ/P1PtDM/a1J+aEsLgkOb3WAs4Pa71WSKB0TXlbv+oCGbi5mYRn9uRsp24aJvfMooCm3kc+ZOBYVv8YNQfUUd35r8lxlprYv08Zmn0Q8GrbQwadL3AKr9QrqwyOxTHpaTyZIaSJb6McgkWU/uKI/GaAkO+jGjhwyOEkFb3juyQDStuwtkCxf32BklMaE8mqXrDu4oK2IWo8LVXgYH6JjgrAhf0iF6LJcGaYXazVExEhuxaHmk5BYDeBiv5ZjLHPpZauKmoO+D4XJV+PMzfvGMiGCyRMrr85ZNqPx+X+bOJYzCbxKpUD73+kk2c1r8GD7DnGiRxTM2r3PTsYrewl1o8Ng+2f2RnSX9 6+SZ3flr y8LwFCoCf7uj5hGtY+km9qLCb+P3rrIVkWDTUiHXH8hHFUs3XgOyIpJ7wwHQ5GunaLvWAVEIeS/o1viSFWlUPXrG62uzZiy2aKEVriR9m4JovkRyp6YbaMNI/N1S82Fpu5b23nopqg+WMiBmhINVGxY6ArE88OJJWaxTxWo03Jd7loROZk/sUzikTDMoEmC/6S/35+qCP9ZnZl9Sfp0l+HroBnltW24/Qw6Vkmca5YUzH7FkQ/qCApRAXnnqXN7jj+mCi2xGq7BV4dmRV00I29zkTzlrUZ+kxEuFqwVHsgj2RmtTOyOvNGptSZpLjWs8slXar/ylSvgaCqosC0846744A/dSf9KbkwhpzGK1dVPEf9G9XVGhGf2iPFMCHCzLTET3ngk6CMTpZWpC+f9YWI6R5YWT0OevD6LeWJoiC+pEOfCKxv+gjtOnYvRDcH9+CrzoO6++rcGp1DdQWEw7yOYrChxmQ3Qgva5pOqJ4pP8OTil4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000062, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/4/20 03:49, Andrew Morton 写道: > On Wed, 19 Apr 2023 17:36:25 +0800 Peng Zhang wrote: > >> In the case of reverse allocation, mas->index and mas->last do not point >> to the correct allocation range, which will cause users to get incorrect >> allocation results, so fix it. If the user does not use it in a specific >> way, this bug will not be triggered. > Please describe the user-visible effects of the bug. I assume "none", > because there are presently no callers which can trigger it? > >> Also re-checks whether the size is still satisfied after the lower bound >> was increased, which is a corner case and is incorrect in previous versions. > Again, what are the user-visible effects of the bug? > > This is indeed a bug, but only VMA uses it now, the way VMA is used now will not trigger it. There is a possibility that a user will trigger it in the future. As a general-purpose data structure library, Maple tree is treated as an opaque box by its users. I think that as long as users use the API provided by Maple tree correctly, there should be no errors in maple tree. Just like other data structure libraries (such as rbtree). So I fixed it. It's easy to write test cases to trigger this bug, but I haven't written test code yet. Sorry I didn't describe it in detail. In the future I will describe user-visible effects in detail. Thanks.