From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A244C433F5 for ; Tue, 8 Mar 2022 11:29:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2882D8D0007; Tue, 8 Mar 2022 06:29:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 211168D0001; Tue, 8 Mar 2022 06:29:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9528D0007; Tue, 8 Mar 2022 06:29:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id F2C818D0001 for ; Tue, 8 Mar 2022 06:29:53 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AFD09901B2 for ; Tue, 8 Mar 2022 11:29:53 +0000 (UTC) X-FDA: 79220999466.26.F9E6B5D Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf04.hostedemail.com (Postfix) with ESMTP id 0344240011 for ; Tue, 8 Mar 2022 11:29:52 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KCXzy4R46zbbnm; Tue, 8 Mar 2022 19:25:02 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 8 Mar 2022 19:29:49 +0800 Subject: Re: [PATCH 03/16] mm/migration: remove unneeded local variable page_lru To: Alistair Popple CC: , , , , , , , , , , , , , , , , , References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-4-linmiaohe@huawei.com> <87wnh6rpms.fsf@nvdebian.thelocal> From: Miaohe Lin Message-ID: <6a1b2a5e-5b43-b45a-9092-1699cc3fc0c8@huawei.com> Date: Tue, 8 Mar 2022 19:29:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <87wnh6rpms.fsf@nvdebian.thelocal> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 0344240011 X-Stat-Signature: 53qqii8f6m56c88rps1po6h437p51upt Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646738992-76090 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/7 18:58, Alistair Popple wrote: > Miaohe Lin writes: > >> We can use page_is_file_lru() directly to help account the isolated >> pages to simplify the code a bit as same as local variable follflags. > > Looks good, but there are two independent changes here. Even though they are > small they should probably be split into two patches. Sounds reasonable. Will try to do this in v2. Thanks. > >> Signed-off-by: Miaohe Lin >> --- >> mm/migrate.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index bc1867a5706c..da5a81052468 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -1609,7 +1609,6 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, >> { >> struct vm_area_struct *vma; >> struct page *page; >> - unsigned int follflags; >> int err; >> >> mmap_read_lock(mm); >> @@ -1619,8 +1618,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, >> goto out; >> >> /* FOLL_DUMP to ignore special (like zero) pages */ >> - follflags = FOLL_GET | FOLL_DUMP; >> - page = follow_page(vma, addr, follflags); >> + page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP); >> >> err = PTR_ERR(page); >> if (IS_ERR(page)) >> @@ -2033,7 +2031,6 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page, >> >> static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) >> { >> - int page_lru; >> int nr_pages = thp_nr_pages(page); >> int order = compound_order(page); >> >> @@ -2060,8 +2057,7 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) >> if (isolate_lru_page(page)) >> return 0; >> >> - page_lru = page_is_file_lru(page); >> - mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + page_lru, >> + mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + page_is_file_lru(page), >> nr_pages); >> >> /*