From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3601C4345F for ; Tue, 23 Apr 2024 08:24:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9118C6B00DE; Tue, 23 Apr 2024 04:24:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C2386B00DF; Tue, 23 Apr 2024 04:24:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0846B00E0; Tue, 23 Apr 2024 04:24:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5BEAE6B00DE for ; Tue, 23 Apr 2024 04:24:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 176FDA067A for ; Tue, 23 Apr 2024 08:24:10 +0000 (UTC) X-FDA: 82040109060.01.30E2799 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 6618840014 for ; Tue, 23 Apr 2024 08:24:07 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713860647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RfHuQjhnnE1bmtMaE4IymDoNkTdFodzQ1kd3CZqYuoI=; b=bSWaq4plBjUHV68El2yS6n8GZwLcjdMBtyfqkecUQebT/QaLOoOQwd3o5Z/m7fgcyTpNEQ ekxjZNYepb5O8WVV3Dsl3U/jOaBcwVttU3blPJVjAl6AMVpoKT47XpOBTWA6zWPIwiGNlR ZOrmuEP47ZKk5VmQbiKOjCppn+QK/EQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713860647; a=rsa-sha256; cv=none; b=t3AUSdU1adGi02uEHfSOhK2C6yOCqs4+E7vWBS2YXlqzzeiZ8iKZ3btjV3bWX3ReZJFhRd vfnxidqpRNm/dIUxBUUgJWEv/2/l2FxokFJ8KJ3FSDz2r9sTX1Y997utOMl2QJoLl8Onc4 tTdOj4EVj9J+G+L7aXXB5uTfXdI08YM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 739BA339; Tue, 23 Apr 2024 01:24:34 -0700 (PDT) Received: from [10.57.74.127] (unknown [10.57.74.127]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A872B3F64C; Tue, 23 Apr 2024 01:24:03 -0700 (PDT) Message-ID: <6a08436e-c984-43aa-bbfa-05cfea34516a@arm.com> Date: Tue, 23 Apr 2024 09:24:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 5/5] selftests/mm: soft-dirty should fail if a testcase fails Content-Language: en-GB To: David Hildenbrand , Catalin Marinas , Will Deacon , Andrew Morton , Shuah Khan , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , Shivansh Vij Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20240419074344.2643212-1-ryan.roberts@arm.com> <20240419074344.2643212-6-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6618840014 X-Rspam-User: X-Stat-Signature: 31k61ghy1st8s77xxbzyu5pm7s7ptepo X-HE-Tag: 1713860647-375145 X-HE-Meta: U2FsdGVkX1+gtW3zPxfbCN/bFmdYoFHGuBr52WRna/RRVESYc99Cf8hTDPdjD0IVh6qXXyfEnE/Lf1RPDB9da1YerjC+aFBVf2AZGaHBQ7BtckCn+1uZ9roxvhurVoQMkRChPSWJd0udTL6GNV2spH5SR4lUe5fSg2vx/dm2pncP5Nehw/XIPWguM4XMQzl246/B8g00xHFwJLY8Ei4EJQYPu0gnDYzvMJ1iE3LA66oSfombJW7VaV+1uYQI87uovCDEtV3SIZ96O2s1NG9fl9n6eq2XI0WDZrQZkf5oZ74sW9E0duBbaAzQ5z4K5Q01BkYckZSNkOQS+w3P5EvHrp4HSoyT/PDoEyKvCGHH562TUt/MUWaMVaynrBKCNj/GDchxuouBfGrTHsSbqrBv/sy9tBQepZNPfTkNY054MJTazuUYMCG7LDluS/Sba6tsWbEXIMBMCSWQJXJ21OFtZzCnujxhJ0OTDkO0UcVbym/Q+gPV4vJ02cmbeM4EJKoxSRSu6HCVTunGXgXkgqOXw1hshAPbU3+V6O8T7PYcOwXXjekP4S54OwUrdG/oXCBhuRPWdEh/H0doBnO67rH8Ya7zwBOq3ZgDC5ZAyIvN0EhKYR2sctlLA6KOS8aCQ/OqH3KR2xaUP/bnlFtfvwNBO79+4lgGdnd+kmtV7INwJhiuo15OreuipKJAfzZchMUe0TigPOG+EnMinudyX5ADaoMHh3vxTXG05FMHKfy3pwJzppfNwSdXqIhLRzjLvLxWXUhBl3yNjgpvHO8LiKrcqutIxGqXrG8St9O1NKCt5+zPo4dR8wRd8GCgXe47UQ2cLeYhFT4gYNrGmKL64FBWtEYcJfFfw55w4nEp8g2Zv8lJDcQli5wYW2WV1iQTNfVHAAvEAy6djGJv2mREZfJptkN+2+LbE9m+wa/9Nqelh0C4WTsh3IHc/fVXz5pWXFsU3qg8KOWwU0pP51rP7ld FtmoMkbv xpFi28jHNTp3KFVNqJ3ydR5dVWS7FZDE00pQDTvxpYX5xoTJ/nYLMUjgRSjUhqpokMGMNdUqzMhIoaUxb/yn4PNZUhxXiOSyG2/jJXvqDh2xlbJ12Ct1ZdiQhr/+wm+8e9aVL3ImG+DjIWikRgDEqg1y9NiUbnb+aRAb0JVMef6f4RuWEwsf9TLh6xaH1+H9norIUifB+RLLB+t2KqancFQ3AYS8dbNpbx7pAoDC4cGmwCCWvYia+Lg4lJOJbZug3Ghtr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22/04/2024 10:33, David Hildenbrand wrote: > On 19.04.24 09:43, Ryan Roberts wrote: >> Previously soft-dirty was unconditionally exiting with success, even if >> one of it's testcases failed. Let's fix that so that failure can be >> reported to automated systems properly. >> >> Signed-off-by: Ryan Roberts >> --- >>   tools/testing/selftests/mm/soft-dirty.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/soft-dirty.c >> b/tools/testing/selftests/mm/soft-dirty.c >> index 7dbfa53d93a0..bdfa5d085f00 100644 >> --- a/tools/testing/selftests/mm/soft-dirty.c >> +++ b/tools/testing/selftests/mm/soft-dirty.c >> @@ -209,5 +209,5 @@ int main(int argc, char **argv) >> >>       close(pagemap_fd); >> >> -    return ksft_exit_pass(); >> +    ksft_finished(); >>   } >> -- >> 2.25.1 >> > > Guess that makes sense independent of all the other stuff? Yes definitely. What's the process here? Do I need to re-post as a stand-alone patch? Or perhaps, Shuah, you could take this into your tree as is? > > Reviewed-by: David Hildenbrand Thanks!