From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 082C5C48BC4 for ; Thu, 15 Feb 2024 16:57:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 895E88D0013; Thu, 15 Feb 2024 11:57:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 847F58D0001; Thu, 15 Feb 2024 11:57:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C29E8D0013; Thu, 15 Feb 2024 11:57:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5880F8D0001 for ; Thu, 15 Feb 2024 11:57:47 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 213E181229 for ; Thu, 15 Feb 2024 16:57:47 +0000 (UTC) X-FDA: 81794644974.10.A20C953 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id BDC091C001C for ; Thu, 15 Feb 2024 16:57:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj78eShb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d4x9GOGa; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj78eShb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d4x9GOGa; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708016265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l7muDhr8z81X6jCxdMQftsbeBEUefCO81St+FLzSeTk=; b=sXXd2b91M17HlKxEwvfXkXAKvmJOeh2jI/TJ/tGkAHCYaLaoxjKi/0lzziotdMBazvP9Lv 4suZH8wOWQgI8gFDil9y60vy1hP3O9cNAZ+DhIZHpjNmhkHKKpFaTUYOj96f0xysbg/39F A6TjCdlN8WcNI0MTGbbC07RtneWJXp0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj78eShb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d4x9GOGa; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj78eShb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d4x9GOGa; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708016265; a=rsa-sha256; cv=none; b=75ifASPNWzbJ9Y1JyIJ9Fe6aindGnIQLQ/V+qawvKhak7zBE2gzZVMOAFGhM0qhEv0nFJe DvR2/WFN3/4EkC0dF3LTkqzHnwpKUC0sVypTpdqWUwSfCCmznX8TKTnRPiQZmLaaVV71t/ rGRpB87IR23fOZ85dfDjObeyLqGtiF4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2AE982222A; Thu, 15 Feb 2024 16:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708016263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l7muDhr8z81X6jCxdMQftsbeBEUefCO81St+FLzSeTk=; b=Uj78eShbmCGOVbMuA28C8iKzGylYbSaStAQ4dkI/AZ2eOXwjEledvo1aAoWlaAJI4y2yC3 7/GGEsczGzRkcT3MLZL4FPoXdvCMynBLLlkjTabgQznADQe+G2pITnpvd5dKe5THIpkhZb bYLdt6LpiRl9Sm9wsshAiKiEZcK2b5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708016263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l7muDhr8z81X6jCxdMQftsbeBEUefCO81St+FLzSeTk=; b=d4x9GOGaorsYebiZnthGeD3C+cEhXXfg4FLEm4KMXI1XDv1rTnwL6z7SHoE8wuucanmu7h WiFbeh0TCVvumJCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708016263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l7muDhr8z81X6jCxdMQftsbeBEUefCO81St+FLzSeTk=; b=Uj78eShbmCGOVbMuA28C8iKzGylYbSaStAQ4dkI/AZ2eOXwjEledvo1aAoWlaAJI4y2yC3 7/GGEsczGzRkcT3MLZL4FPoXdvCMynBLLlkjTabgQznADQe+G2pITnpvd5dKe5THIpkhZb bYLdt6LpiRl9Sm9wsshAiKiEZcK2b5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708016263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l7muDhr8z81X6jCxdMQftsbeBEUefCO81St+FLzSeTk=; b=d4x9GOGaorsYebiZnthGeD3C+cEhXXfg4FLEm4KMXI1XDv1rTnwL6z7SHoE8wuucanmu7h WiFbeh0TCVvumJCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 01A1E13A53; Thu, 15 Feb 2024 16:57:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uF5gO4ZCzmX7DAAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 16:57:42 +0000 Message-ID: <6a011e7f-4e21-4e31-a9a2-52cba3181337@suse.cz> Date: Thu, 15 Feb 2024 17:57:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] mm/compaction: add support for >0 order folio memory compaction. Content-Language: en-US To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20240214220420.1229173-1-zi.yan@sent.com> <20240214220420.1229173-3-zi.yan@sent.com> From: Vlastimil Babka In-Reply-To: <20240214220420.1229173-3-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BDC091C001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8ta4xo9xo9p3ogxaunjdwguze8faanap X-HE-Tag: 1708016264-320007 X-HE-Meta: U2FsdGVkX18Tqp+Gbsm9X/irsJpaycUNSm0ib8zkEodC49PYWPsIuSquuWAyhCoTM74EgBwAGdna1tUz16OBmopCfK86AOfGe5a4vHXMPhRJ2nU1z8aY1YQ/ydiuzNhDk5b7Qbv8AA2jg+24aqywiH5EOCq/ZtsviEeOewRjcIT4uchqLWcI2GRE3UoCoFii13u7k+rLEygYB3aQnrI8c5Qdz3jXb0AvtJyaGiQkv0GrazpRz77zdaaTxd97U6ro6SFYFE6iLFPCkj3Vf2DL1GonxYERaun0miUK5AymIQddzD78IVam1/5l6El3ejwIJu4CPf13oOXRcpm5hIX3iEtP84YjK+c+wLpBx4WNE+Zt3c6sNjcLtkIod+V/+46ZGFL2oSOk/H9IlmThiEn3vcTHmcjnaaHyHd+WOCuLzYBthzuEPa7YBYrM6PzBSjVCh0hlXQK1iOSvSCzI+jiU/u8kYb1fsMT9e+SqxEgJ/4XR6OkeaQRy9t0XJK2nqKPVmyT9PJdY5UA+DXXZZnAAzpS4oejEL07Oi6tAxdDnnnsxDRDziIeT57Yu3E7IPZwPA8mqppGTi5xOY1EexIW12wJBWGS0ATaICTlZdNJVFk0rg/O1N9/2zd+IqevlNYWPtiw3nG7iQbl8EcbGws7pxVw6xoa/VcYYTXzneeJFBTjE4EyyKc8ptwsrcovkZ12tVdu8azmpgayBB9JRsTSv5lZLR8p73furqMkPGox+IfLLpqepYZN1YTKiYvaMeYaKIPTo8vG8R7P2QWE0KLruAH+OeMAFItwuiKFEu0VQIDtMBPqj1KCVPb+wjlkerwSR6glPpH0JpvWNGpWZJEYYUVmgVUYWqeyCMYb35D+aCjkHtvwd07UjnaX1+yHvNBpDkZ6Vrk0ii9EPnai1+QnnaLPwIsTa7D1/IyIFbhN4OcGWqvao6b5w3ebBJ1KyMhgZBkl6LmdcNxgbfFxxLwm l0eyLg6C 4zQ4BVK+MwwXG5CY3UOAQb4lFw+6TGw0Apg0L7LvtToCNfNld074AYLrSosTNFbCtr7NH0dgk3aK2fBBNNytzn4nPDgCTelHZOM9JTEgN09JQGeN2Ce6z+4uxzK3SHy7CyXj2n1pfRI2h3mSI9Y/0MjVxQgT14R5J1Z1faA6GuYpX3yRA3ECpx5PtIg5X7myYhn51KqXOPK2C1k9s9VkJMSeqEp/XUjLmH/0ldTkX3q6fRXGrcX0CG2iw0Wp+7lQKlpUtpX6px+VqF/1YQUw8EkItUHQ11B2x64iBX0ZaT0a/4rx5c90w1jDpIDeuJ3l1Dw+2w79ChvyiE3zGDIPilhdTLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/24 23:04, Zi Yan wrote: > @@ -1849,10 +1857,22 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) > static void compaction_free(struct folio *dst, unsigned long data) > { > struct compact_control *cc = (struct compact_control *)data; > + int order = folio_order(dst); > + struct page *page = &dst->page; > + > + if (folio_put_testzero(dst)) { > + free_pages_prepare_fpi_none(page, order); > + > + INIT_LIST_HEAD(&dst->lru); (is this even needed? I think the state of first parameter of list_add() is never expected to be in particular state?) > > - list_add(&dst->lru, &cc->freepages); > - cc->nr_freepages++; > - cc->nr_migratepages += 1 << folio_order(dst); > + list_add(&dst->lru, &cc->freepages[order]); > + cc->nr_freepages += 1 << order; > + cc->nr_migratepages += 1 << order; Hm actually this increment of nr_migratepages should happen even if we lost the free page. > + } > + /* > + * someone else has referenced the page, we cannot take it back to our > + * free list. > + */ > }