From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744F7EB64DD for ; Tue, 25 Jul 2023 03:24:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D02978E0001; Mon, 24 Jul 2023 23:24:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB1CA6B0074; Mon, 24 Jul 2023 23:24:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA9C58E0001; Mon, 24 Jul 2023 23:24:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AB6416B0071 for ; Mon, 24 Jul 2023 23:24:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 62DBE40B74 for ; Tue, 25 Jul 2023 03:24:46 +0000 (UTC) X-FDA: 81048692172.06.028AC68 Received: from out-3.mta0.migadu.com (out-3.mta0.migadu.com [91.218.175.3]) by imf10.hostedemail.com (Postfix) with ESMTP id 83BDCC0006 for ; Tue, 25 Jul 2023 03:24:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=r9D+tXFV; spf=pass (imf10.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.3 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690255483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6p0DFvIoLJzSIVM0qRIM/GXeN12xkckyA9Fji4TGEhI=; b=JcN1DhevhqfJV/T4/5MGmMYRc9JVWzqPWVWp1PG/vW9fJy7kuWtFYowNaa9lVKLZORqbcU f4kS7ERPTZ3LTBUpIa7aXv4XCQSn8HMq4JbfchbMWipRYXOfqfowHW/6QLh52y/R6ORsx0 G/nif0XU12heaGdjOWK4A/XxfM8r3XY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690255483; a=rsa-sha256; cv=none; b=su6cUd0CDSmTV8IVb0ORK+B7JtbAtf4ZtBdPRES99ZzcvOUaULmjhLqhNmDJEb9EO0lmrU ZUcXpsNbX6Q6QgqrCuZYz2HKKvrNAmOqE+JgpwPFZUCs5r4poic46fOw8vD+kR1oq93RSM W+on/j+4KV1Uxwi3V+J/tRFkqTxry3Q= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=r9D+tXFV; spf=pass (imf10.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.3 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690255481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6p0DFvIoLJzSIVM0qRIM/GXeN12xkckyA9Fji4TGEhI=; b=r9D+tXFVa/N1RN+BLv5WgR5iQ4rwtyebnPM62Sh3w2AQ+19WlSlFOjsJl5wosr8TEtJchn V877L2MD6oNieyuMlTG6JawmQ1ns/Fjh33pHsVXqhR6CCRTDc2499SUTwOS+JRsWVrdweW vS3GyBw0+b28Uj9NeJVk00fqQ8IPfLM= MIME-Version: 1.0 Subject: Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Tue, 25 Jul 2023 11:23:54 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , LKML , Linux Memory Management List , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <6FE62F56-1B4E-4E2A-BEA9-0DA6907A2FA9@linux.dev> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-2-zhengqi.arch@bytedance.com> <97E80C37-8872-4C5A-A027-A0B35F39152A@linux.dev> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Stat-Signature: tbtteoqw43an85djsbai3hq9axpzd5n9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 83BDCC0006 X-Rspam-User: X-HE-Tag: 1690255483-310652 X-HE-Meta: U2FsdGVkX1/Wr0+XTVCtAsXuDbquoC+k3o7ZI5v5KTfo01VqSMY1kRkADMg3+MFuQ+F3dAYln8gs9w9Fr6ACFTxWv3ByDLPg6qKWxtsdf3ZnoHeXdFe6xQfhBCYLGmhYFt3HYZFSkJ7nLVIMXhWqlkJ/4EliHNa+yr/Lv33yTqGudI1L+GcKeR2arpAj8u4nLyGz4gaQh/YNrQ2ADuU8brG+RjNrMjwNUbiCnLW0ebcMveLeR2z17Aao4swVMLCCbPvfYPgq0VEiNcG1t07qocnZVEC2HuFqmS2Xd9uk2c7mhRbGb+4VGCgWl1YA9WQeiy3P8ppWBx0EYKeGBbluu8FnIXEuHBIhDLj2b2svVxj4MJ7/XzRriAactOQxoqtPNgoHYNVdUDTnHwWw8aFIaT/9cKh7Axs7ORpkObWInqfMpKz69FMZUYovna3iLIecdwLJrR3oj7nywTEq+dE0NFVssefBcalMVhJh3Rh9NaqSes4m2nTjQbyaEF+ai8n4DAhoDpkSZq0QvE9hylgrcLnD3zX9ztPX+VrGeNmP2NsAfrER0UtZOR2bhSl/fTo4jeIm4PxGn3AMPXYeBmS7mjF5BmqiA+HTliscI8os3JbgodS8qeQ6xSQzuc1kSqU7VFNdaczB4MsHNVWlEOsUoZ44Phu3IrNHw4A+ZH8NfMR0r0hoXqm7PcILwjp3KyP+HZjW5CVxq8f+nMy5+jUMHAXLpjpm8RLKmeTGvK35pTbKMURHTNDo7BGDKykH6VLKUcDDMy7K9+hsLqrNIZxSXTd7Sa3UdJ8osz1FGqLmbQ/lZK4yYU6qDRXqAfpJGW8iYdQYYbwF5AE3eEjp47oTOAPXX9/UtXeTyVnD7fmY0IUv/opS+3TKUeNLhNNgFjyfYgpwDTlPvxizVMPWwX2RKHYkIVYFGIIVohuOYK/1NtP7X8jzW1JYJBpVxVVwG+TV9Fq8RbnWP+OKJ8okjKr rgKuuVrr gi68hDaxQCm90ocS4HJ9Ga9W1bIGv68o6X4GS81MgIgOrlLLkUa01TY/gcSVeUy1t1c57aPJ9uLtdw6wb4B38bI1O5VYgbx/qGHNILlJX5mBtk/QYPqAMP76dQIW7q67YugoUXHGN5dTwtTs8AS2NG+kGIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 25, 2023, at 11:09, Qi Zheng = wrote: >=20 >=20 >=20 > On 2023/7/25 10:35, Muchun Song wrote: >>> On Jul 24, 2023, at 17:43, Qi Zheng = wrote: >>>=20 >>> The mm/vmscan.c file is too large, so separate the shrinker-related >>> code from it into a separate file. No functional changes. >>>=20 >>> Signed-off-by: Qi Zheng >>> --- >>> include/linux/shrinker.h | 3 + >>> mm/Makefile | 4 +- >>> mm/shrinker.c | 707 = +++++++++++++++++++++++++++++++++++++++ >>> mm/vmscan.c | 701 = -------------------------------------- >>> 4 files changed, 712 insertions(+), 703 deletions(-) >>> create mode 100644 mm/shrinker.c >>>=20 >>> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >>> index 224293b2dd06..961cb84e51f5 100644 >>> --- a/include/linux/shrinker.h >>> +++ b/include/linux/shrinker.h >>> @@ -96,6 +96,9 @@ struct shrinker { >>> */ >>> #define SHRINKER_NONSLAB (1 << 3) >>>=20 >>> +unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct = mem_cgroup *memcg, >>> + int priority); >> A good cleanup, vmscan.c is so huge. >> I'd like to introduce a new header in mm/ directory and contains = those >> declarations of functions (like this and other debug function in >> shrinker_debug.c) since they are used internally across mm. >=20 > How about putting them in the mm/internal.h file? Either is fine to me. >=20 >> Thanks.