From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF175C6FD1C for ; Fri, 24 Mar 2023 06:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 649886B0072; Fri, 24 Mar 2023 02:03:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D0286B0074; Fri, 24 Mar 2023 02:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FC0F6B0075; Fri, 24 Mar 2023 02:03:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A31B6B0072 for ; Fri, 24 Mar 2023 02:03:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E757D140590 for ; Fri, 24 Mar 2023 06:03:55 +0000 (UTC) X-FDA: 80602750830.01.3322A0C Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf19.hostedemail.com (Postfix) with ESMTP id 7DE991A0009 for ; Fri, 24 Mar 2023 06:03:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b="e/4ffUXl"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf19.hostedemail.com: domain of "prvs=64474d8277=songliubraving@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=64474d8277=songliubraving@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679637832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OCe/7Z0svT+H2mKSWQaZUcZWI1KwqWWJ5SUayT3VZmc=; b=Q8aDhKHlX9KdeokRHRUQ5ZRyzOw2JCtj97kvCjxqIc01VVZ9BQWrBpdpoFPsPJ2n0EOOB+ PmTiGL1xOfOzCirU+P7a4YswlBhZaNxDVkDvcFLrT7ABcHXOSK8FxptX7ddfz4H8dOOI9/ m/ZKmFvzqiBpQ6FFXvHiFOjI3Q6i9H0= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b="e/4ffUXl"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf19.hostedemail.com: domain of "prvs=64474d8277=songliubraving@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=64474d8277=songliubraving@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1679637832; a=rsa-sha256; cv=pass; b=vrD68ysjJAFhxJYWZh/367skX1zekwFp6q8llFiTKU+KgNQqlnRmfpFKT6Txw83TIP7frT ryRo2MoxuQcpE2KkTsu2n+Kx+BgiFE+zftERwYk4txW+8MwduV2SsG5I/8w3YW5BlVpyvI n1NCRm5jD3CNvT9MXdUhqoK78gGAP+4= Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32O18dSj007504; Thu, 23 Mar 2023 23:03:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=s2048-2021-q4; bh=OCe/7Z0svT+H2mKSWQaZUcZWI1KwqWWJ5SUayT3VZmc=; b=e/4ffUXlK0YxkBrMeFKLXFliGLFIEVaamYfZ0ieSGKObX9L/7XpekbSTMJGstrOGg3Vz SEQCbpsJUF2DBSrR+lkGJ9wVA9aZcfBDUDOYswNgjQOvkLCYsUAmzcBCqR1SHOLn1rIi HWDx5Sfe52meLgwIUEmcq2KUrFapN13qEDB9O27KOvcjc9MRFcm8XePYsuBP4cQ+HVQX uHpCPVePmnbpmXctjageGctQl0JUS+5InilUkSt/NwLuoj/fQT2yjkd9wmbqDBeb/sgx oLSt6nzgxPCzxuYaDDm2hHhAgYMlLrScrSgdskNTSR5sPbv5t3hSFIXs8q5avQJrWgZ9 Uw== Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2040.outbound.protection.outlook.com [104.47.51.40]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3pgxkej2tj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 23:03:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ofr5kSm/91AwvZpaw/pEh7FAzGFZ34rFkkPvHN9QqO1c4sxDUGcFEWbbQQEPhMYdn12/5I+0QITrfebmmyM8l4sqdE1U2b66BVCaUGXCd/AfjVhOUJeiEVT6I/NRGa5dq4olcaHP5fUT01Bf5Ym+MRQ9H3HS2Gr1qbCTTYW9hk7oiJdNpBE9cg2IDzEG4bynfsnIiXQh/fG6UM+7ZeFnEgZcONqytb/DVqXysEJ/R2x1zYtwQNTB/JoFcOB970ZULUtqmIO8uqK1+nnn5Tc3PSEpj/ENHDtNodBxdx9uocsMh/rZYQwWu3T48ZuuX9nwGG3NTZcEt8zdS76I0EGyrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OCe/7Z0svT+H2mKSWQaZUcZWI1KwqWWJ5SUayT3VZmc=; b=asUURz/WyeJWd+Y9EiMVwZntNJiO1EMVm37MJIf/c6Ffl8UsRmcMB1Ft4phM+6yhcqzQKv3ziYy64zG4PehGCqqx2nQ1+wSkQ8Uv8TEKo4lIXfGPn5kNZN67eLf1KfX2eEKXEJFUgw/1K3+mCga1aAxxrBszc24Zbb2TJ32C4ul8K/slFB3ZVadFrQAfuh3cGVIX7/EhaTDG8F8GDCIeyfMpH2WhDN8zSeJFamsezqd7uCrjPV18n3KImnge/jk8+nJo/c6LVAIOFWQS86Jid22EpPzIYQfAPIyC9w5eYYUFOiPyymd/sOlULJWnw4eV7Qo6fJR3xUDwlm6RZVzmTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=meta.com; dmarc=pass action=none header.from=meta.com; dkim=pass header.d=meta.com; arc=none Received: from SA1PR15MB5109.namprd15.prod.outlook.com (2603:10b6:806:1dc::10) by BY3PR15MB4899.namprd15.prod.outlook.com (2603:10b6:a03:3c2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 06:03:38 +0000 Received: from SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::95a1:140b:9c44:f86d]) by SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::95a1:140b:9c44:f86d%5]) with mapi id 15.20.6178.038; Fri, 24 Mar 2023 06:03:38 +0000 From: Song Liu To: Matthew Wilcox CC: Hugh Dickins , Song Liu , Jiri Olsa , David Stevens , Linux-MM , Andrew Morton , Peter Xu , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Jiaqi Yan , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 3/3] mm/khugepaged: maintain page cache uptodate flag Thread-Topic: [PATCH v5 3/3] mm/khugepaged: maintain page cache uptodate flag Thread-Index: AQHZXdJKRWUpBJV49U+GL8Q6io5iaa8I8egAgAA6LACAABowAIAAKsqA Date: Fri, 24 Mar 2023 06:03:37 +0000 Message-ID: <6F9B0A6A-B7F1-4E25-AB15-8F3782D2EF83@fb.com> References: <20230307052036.1520708-1-stevensd@google.com> <20230307052036.1520708-4-stevensd@google.com> <866d1a75-d462-563-dfd7-1aa2971a285b@google.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR15MB5109:EE_|BY3PR15MB4899:EE_ x-ms-office365-filtering-correlation-id: ea1b15a5-1829-4205-1032-08db2c2d82a6 x-fb-source: Internal x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6EPret9m4KpDLit4FWvj+Py0Hq5pZ5H2u0DzSku8jOs4Oa7IqezJBA+saBgk6NokvSlyGUlVpR3W+ZJJfWZzHbs9++zIAvZgCL/7xNlURme2/c0wq78gVX4D/Hf1P2Wgw6bvnBM88tyzd5HumAxIwqJgJeRbyoAxvXk0crNMoTYX23Rw8DWaNPbuTGYj1wPkgpTvg6MNToQ7RZINtDq5NBpc8WEu4kyuUnQHYyGTPw/NOLJj81dQ43JPR8yElUyVRP9SWqzbPg5tvs/Je8Pro7k86+aDyspKpa9wLAgOBbprh7e8dLROgMBmQTyF5Xzs+jqEDO4MxR8azLakH0jACFzmMznLLGXC7X4OOCalGwM7Zw+fe4xbQ1k7XE6wK5Cvr9TAYkVTlLFkJ8O/M26WEyrIKLHTauzXNEp/1vjiWTinHGZXJ9nvicSy9r/bfS7liQyBuFaPk5WVvtPLRUH++4L9J7yf6+JvlTpMl1qquZ2G/NWlsHLRan3dcrpvo+QBQdxiP40PlRuV/RRmU3JgHX9nKhk8VhAhk0Wna9upJBf7dGrliUSG05nmWSvyGyjIxIfoyHIOu6Gw5BaLxDFUFxNt2hNLAGYx+ki02DSgxS3UrR08xoBU5mYtyaZtKID8joGw3NiS6g8rtM/Ivc6N4BotFTW9ss8zlWMTBQpOKZePWDgpjkgkgYAH34KnYIy/Ggu2LTSxrkYGNBYf6n6qGw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR15MB5109.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199018)(33656002)(36756003)(38100700002)(8936002)(76116006)(4326008)(6916009)(86362001)(8676002)(41300700001)(66476007)(66446008)(66946007)(66556008)(64756008)(91956017)(54906003)(71200400001)(478600001)(316002)(6486002)(7416002)(5660300002)(2906002)(6506007)(38070700005)(9686003)(6512007)(53546011)(122000001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dgU/QO1dOoL8L9P10FiDtogO48iBmdSFOfVjbHtKXNBabp+c5VSk/15YHQNM?= =?us-ascii?Q?TtBu12nKO9ogJHJuyEaaUVhWeSNlwUYsmvLH1rdBXfsZEPqDuH4KCIlGVvn+?= =?us-ascii?Q?fyIHEsQSwwcwzFgaQvogeX2B4lK76GY9Ms2NtdQTWJ2FoWTtygmjTMnjFNzZ?= =?us-ascii?Q?ofHUO4gpR8e3ChpJaOQ8NskGNL2uFThDMsGyOkkCjUyjyJ7rOAoto7b0fNWG?= =?us-ascii?Q?ll1wWApUfkfwK32oePYZFPCXwxUprp39dQ+pUOoj5QBhGCs9pnDZVZCg8/yk?= =?us-ascii?Q?s6JzVI9PDwe/9y+lotxYlaNdKEboPIBEVNuNwVX9Sg1lgselasWI+t3Owi0I?= =?us-ascii?Q?hj/aC6TCnkQePtEyc4Se3UrU2gU2ChyJJHKH+NLRtDZjBK8hc8mHdQHbDirm?= =?us-ascii?Q?2v/iHMGSqO6Iw+axj2RyHy28FDgXaUUG+CDhPdZvXWuZdIHskUGtYfmEpA0W?= =?us-ascii?Q?FR70KZgzOuuYSsGs3csymISIZ85Qz9pUWmOCWjgJeEKHzLtGIbheZH6j0lnB?= =?us-ascii?Q?u1MgoYHjhcTRhWUD3y5DxTX8As62BU5WM2naOtmhRZK3NOFFKNAEI4yNdSQg?= =?us-ascii?Q?6X2iAC2oLI6xislZ/ItWKJf/OJlo+vgEoYSoAd47Z688h1qhxkRcD1nSIp1U?= =?us-ascii?Q?shr5eALLkA2BeH+G5K3VrX97CYKM46tbKMV3JEkFanUmKOGsETGDwaYHCFMS?= =?us-ascii?Q?+3oC/mRnfHJ6MXK8mMbqcWdPojBUcxPmt1xdn1MBNWwmAQB5ks5xAKxE+b4+?= =?us-ascii?Q?CAyM/orppgn43ZxA9LvaBoqt6/kdmFqE0ArSKshyJoyIfRkp/T9/mqVdGl2t?= =?us-ascii?Q?JC5db+skQXWQQjlGwdm0vBqogOLIiDVNz7RcYRW0h1FX6aDU38LfztCIT8Na?= =?us-ascii?Q?csWS7Ux2UuRvOGE14yASKCSp6O5mQ+/n4rszBdxrMWFarrkZdPyqaC6bkf9H?= =?us-ascii?Q?DVPaK2795oiaWSRveAcV0JjN9fo2NQK6zgeBCg8i0uHC8C1/xRb9z9TGf79f?= =?us-ascii?Q?HSx+PsfC9Q7cwA1WPLwPEETwnzGnY4ontPNe7jVU/VB3khgDKwfmrGA8Ynf2?= =?us-ascii?Q?MA0sg95/aSwDo8p8xHC9+NVRPEvaARSvUizqPGGgDvX1yvcpvuwInfAX46r6?= =?us-ascii?Q?9ebraMsKE7mVakzr6tCEd6M4cqzLygVLfkIbvDss1xVxbIakk4OAZRivXsmq?= =?us-ascii?Q?Rfxvim+T2B1Z7atx6MedRgoD7syQu2ndgGy4QuHxmOZM2xB1FKnFnNq6ztrO?= =?us-ascii?Q?XHsM3yvf2ecIC5r2dJpyoOdsRmH7zia3G6650TSQws3JjCrW13CaOAn32lmU?= =?us-ascii?Q?e0NWHH+E48Yyz9neQ4AC6Ui4OZ0FeypLY4WD1C/2o7sMqpWJ11LfYFIkmIOy?= =?us-ascii?Q?+kuiIstLp6VA/F1bdyDlcN0v8mfx74YEiI5aZhinPZBiXhgX/aQS2+YEVbuV?= =?us-ascii?Q?tkWHz2CcIjS6u5OVwGGJAk2fREp4adJKqJs23aDXO8ur+4kvgeXGhUmf3ZHa?= =?us-ascii?Q?LDzAQaftTqmWf1G+uBX2EW85dt4VNcLOi7aljpphlyskAVgx88RRwnFIc1xi?= =?us-ascii?Q?WvTXoa5f6UH8oM1hkPo6BNOnOayYprBCxWlG9uSJY9nFc7wCEdM/gyprK+oC?= =?us-ascii?Q?f0uEM3deqBYVgtnimuDyUJhdj2ATCTqQvT1mEFVq4UKy?= Content-Type: text/plain; charset="us-ascii" Content-ID: <5801088FEB3030489DD8A68FD9F23FF9@namprd15.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: meta.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea1b15a5-1829-4205-1032-08db2c2d82a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2023 06:03:38.0128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z3EpvN7z8iUm6Wz6xbq5xo+xlQaI5D7VbO+6hJwo9ZkE4yhB3XeI6Eo3za9d9+5e+LYURzQ83EoinGP+X465sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB4899 X-Proofpoint-GUID: c8kL40PjErdP716Ofqq-Mma1-V7INx58 X-Proofpoint-ORIG-GUID: c8kL40PjErdP716Ofqq-Mma1-V7INx58 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_02,2023-03-23_02,2023-02-09_01 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6jbqcz1oxixt9qia4tawgg7bsarpz3z6 X-Rspamd-Queue-Id: 7DE991A0009 X-HE-Tag: 1679637832-192344 X-HE-Meta: U2FsdGVkX1/9PL2zEz3DlwviJO3sKQa5AU4SLQrnWAZtYQ5OhNdIBIdaCz+aR/V7EN9v7681SG4pWDwvUkSN9k838TXNRT4Ztg60su0dvfIcKEKYsoyYViWXPzRrLPnqlvt1hYrxj51Q9Gb2dHMl/mEiVdgrnf/zyk0M7AL3c2cG9ZvSq5TSriMAwupW3sURfysKe71B6PyFmBa8RxYLpdvM6LRGoKETl89OEtg8Sug9HUFPdF3b7QnvBd0UCKZSFAlnbQVr7CI25OveYojhCIROM9tGig2XCaRAm75ZL4xY3micZrosEB1+uMHY6noqTj+PWfaQkVvI1JqXoPkxRTH+LrwJDgA1HtYHmDnSE0qlPUTk2YZag7Z2GSC3s+YHT2Np6vkJWg7ws8+qPUqZQsW/pUZ2KQ2CU/gRmPoZTTQAD+c/0L3USDKWI2C7bSh6pvWY5YGZ0EZlMIFwkO+5bONTfqU3uzUwUF6Q8IudaM2m4mp4VELxaLayaZvbp6uVF4cM5qbmIegladceB2zT9uBqwvwwrKi8za0xYzQ6oDsEXROVE0KUVynsEhoVygLaUSJhRVIul2jzD7cMDgH1t30DZW45QXIZX4Wtw4tHhxHuVC0uZxAYHhjMlxN8ZT+yiP2JJyEbAfm3tQvcazUAt0GhApIQikRZhMljC0tk4MeJ0ZvRXONEkRLRt8d1/sBavDKjYdPtjdAnk/7MifAxnYDxSZuS84SaG92irdOEcczSBQJUUrRo1ojPogUs52XBDFyeG2qAC6XgHDJHz51PdQ4dvYuTvzsEayZRwtj2ZkDOSfurd9Yb+Fvzv9QknjqKxrS8bhQ1RHZbG8+/hxHq2O26cTH65+B2FfZzylDejzrmLDnPqpnVtk9pooQ+g2om1RGHoW3JqkgASRZUqxdzLfrTc3gd9YGkZPi9jrIzIAsoKZq88vMbtEKYQNhtYqKNhIReYXTV55HgPiKXeYu qsz68A4C 96UPRr8wxkpwk29eqG5U5A97JJsxnmB/uULM8KwZMmKejfW61Ir/5anhhsrrYGzsE5L0X7+3jnyEWkDJPNAoIVd/lE5vSfZSqay3aJQQrO0Jo7xRkZdsmwMp7lc0yuAkr8tau214CkZkTjJLX4dusDP8CjfrQBkkhF3nVjudTOV9IB/CS9ZvYqUB54eLfbA0ak4KZ0hmYKJ5Rzm+/QCqiAWpRSlL5UiTaph6zq5Ql26aRiQjIIfVwMLBWN4+JBeT+rhNOJ9gq3poAlIehumPKr4aRZGx9mHB5XVmuo4bQ0Htx80olfW7RP6/S8nPs9gTlWlZvDsEQH721lsOaz9HmBR/nWw5H3eTBFxKAJjRKZZr4rTkD3DDwn3Mg7700Cz6GTojrPRPbCPfhahOprD8D8mZ2M75D7O1hUBzeE2vY6WEfwsegBwsyyF+OWg4HzILS4Zp6bqtf0vn067qGAZo5nFue5ie1cEdsF3y3iyHZID/GNft1RTQNDjUeLlP8w+YsasTGB5c++6T6w9HK+e8LDgctRwERUGjDaw7N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Mar 23, 2023, at 8:30 PM, Matthew Wilcox wrote: [...] >=20 > The Uptodate flag check needs to be done by the caller; the > find_get_page() family return !uptodate pages. >=20 > But find_get_page() does not advertise itself as NMI-safe. And I > think it's wrong to try to make it NMI-safe. Most of the kernel is > not NMI-safe. I think it's incumbent on the BPF people to get the > information they need ahead of taking the NMI. NMI handlers are not > supposed to be doing a huge amount of work! I don't really understand > why it needs to do work in NMI context; surely it can note the location o= f > the fault and queue work to be done later (eg on irq-enable, task-switch > or return-to-user) The use case here is a profiler (similar to perf-record). Parsing the=20 build id in side the NMI makes the profiler a lot simpler. Otherwise,=20 we will need some post processing for each sample.=20 OTOH, it is totally fine if build_id_parse() fails some time, say < 5%.=20 The profiler output is still useful in such cases.=20 I guess the next step is to replace find_get_page() with a NMI-safe version? Thanks, Song