From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2EDDC4332F for ; Wed, 13 Dec 2023 14:27:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C5646B0467; Wed, 13 Dec 2023 09:27:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 775D76B0468; Wed, 13 Dec 2023 09:27:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6644F6B0469; Wed, 13 Dec 2023 09:27:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 53C416B0467 for ; Wed, 13 Dec 2023 09:27:29 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1C959160B6B for ; Wed, 13 Dec 2023 14:27:29 +0000 (UTC) X-FDA: 81562023018.05.7D63A72 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf24.hostedemail.com (Postfix) with ESMTP id F284F180025 for ; Wed, 13 Dec 2023 14:27:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O4FVnkeJ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702477647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ogqfjk94QmYjvUNgg1o+03IMu+upFqXEAelcw2m6BF0=; b=LV9jZVTwORyi/pH1k1J0yNvQokpziDc7ZT1Q4/qz9dTm67tYyztAkc3GMVVzo95BNv0ocN PdyoRaqGMeFT5N3WQQp31HkXKY2gB7fI4Rfxldd4+3QGU7ZXGcn9RXNG1WPAIv8mfurPCQ 1y16DqONC29ySiyCarNSYEmBWgVHL/w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O4FVnkeJ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702477647; a=rsa-sha256; cv=none; b=s1hbw7f2VB6+QOom0d8mJsLN9JeZ93iE/ITOhY0cfvcZZP6Jtl74T5hkYi+pBxTR98GsDE YkVtqGFdUyl/HMMXDEPwP/+NsWvXu9iIMImMVsdQKKRq1o8t5NQAdk554g3xoqIueB/xgU SoGXNoaRQNutM3BsKZdIQwYLSmi/o6A= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702477644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ogqfjk94QmYjvUNgg1o+03IMu+upFqXEAelcw2m6BF0=; b=O4FVnkeJB8t1p7jQ/Sc19JPsioqfW2DVSaqvl+qsINAE708pWhnuzM9Z8qzAEZ+jRqLahz pl+Cu1s+PDdQv6AE3rF/9bNICB1kW2n30DcpR3L6KPJqEnxT2F3ocpVKG3VqHOhcwjjfg3 AVAVilbG1Qp0jhhPXhkIxYY1clzxNuk= Mime-Version: 1.0 Subject: Re: [PATCH] mm: memcg: remove direct use of __memcg_kmem_uncharge_page X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20231213130414.353244-1-yosryahmed@google.com> Date: Wed, 13 Dec 2023 22:26:50 +0800 Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , "Matthew Wilcox (Oracle)" , cgroups@vger.kernel.org, linux-mm@kvack.org Content-Transfer-Encoding: 7bit Message-Id: <6F87D2CF-42AB-4225-BCF0-3F25F38A643A@linux.dev> References: <20231213130414.353244-1-yosryahmed@google.com> To: Yosry Ahmed X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 3cji69985kimc4qmiadwj1o4tprfz3p8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F284F180025 X-HE-Tag: 1702477646-700724 X-HE-Meta: U2FsdGVkX1+CZvnPAZnhYkhLm5Scy+UL6srSKOM+ouVmi3flOxpAbdGtcdSnofyWpNP9YmsF1jMAdbIOVhAzqqVtgpwMa/OZRieQTYc0F0SPp5EDIfux3CqJvlmghqNYSvXFLi3ZygwnoZikOQ2aCo3iQxL/8aiQ2lKtGB5y36Ro0MUbfHfDXIYqJzY6APj+ntJdEknmcOqRKHnn9SCB57LB/YGvzI4k8ClkiawUp/HB8zpzR9YVTHI4fEJN6aVWb9y13/gHgjO7PdOj1TSThu0GOsXBCKjWBZr/oWHtmv47+LmchlF/nM+OJTppkWmgKx5BMuTiJqpE31+7qaYdevoFFEyTVexElb/cmsCaQFDD01bQON++IKB8OZ5JAv9C+/jp8qIiOKpKlVtxo7xm6cwYsQCFmsReNjcrqVzFmZxvwOhLqfdvF43jXa6CRJ6lbDGpolGy3RpFf4TwxWN4Piz3ei8bqEjH3qYUUqQ/QQjU0yxOq6/wdP2kQe7y89yDwrqSRlX3j3iICcIk9lOPWh0usRqyJ6ZfHD9J4ye/y1UpQ+tHLaEDhi70tK+yOLIK8RyghrO4Gh9yjS7iYYEHztzvUTp7oE+fMvql28+Dg/cPyrVyNPryjT2r3gOKUfnqye3TIhWJZ8ecQ6Pisgm0oCxJSPYW7HO5OQl9RL4p6MUKMt0tba1mdCkf53t6o0fFa1opZi236UA0yh52pMi2pEkC/7Iq911XiYpmEnDpS9LzpafqkzIEabdoYJOThTQxQyOO9Yk338NouFR3CBzDA/QcrOJUHI7kuXL2PbhYmVpEnWBf3bEeqHPhkZQjdHYrdYVs9tMvnVZUNFK0n73QKzOJ1IKz6x6krjXoWB5mydm7ZHTo7p5JbjXMTd5FgNgDjHVZudQtS9JghJ+1Nov0q07tND0V7LuBNygOqm93+trBngmfRGzbUSw3tFPLfVPjlMebF+2CKzfDIADlkys TYoC8a/+ iJMrdeD6SlAetSpjFRLCaCFDDEYuKZtXIMHNEZHOK6RMzrA8icTRLOXQybS1leupmbkc15OY2aHUK16a1Lwfxg2bp1LjCNsJbx4Tk265QiHRd61lXaYAZwHL/3KCHZpiK/pTlArTzfnz9H7xLZgtY9pbyzx3e+tyQPBdfsU0xH4H5anOti/r8TZMR+WKJgrBdIywtvAn/pZgLuhd7rLT69+HI7wfrS2PFNBbD+pcngHyO5uTIEwKAQFx/7G/KtdnVtz93TrdrDYwcBRo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Dec 13, 2023, at 21:04, Yosry Ahmed wrote: > > memcg_kmem_uncharge_page() is an inline wrapper around > __memcg_kmem_uncharge_page() that checks memcg_kmem_online() before > making the function call. Internally, __memcg_kmem_uncharge_page() has a > folio_memcg_kmem() check. > > The only direct user of __memcg_kmem_uncharge_page(), > free_pages_prepare(), checks PageMemcgKmem() before calling it to avoid > the function call if possible. Move the folio_memcg_kmem() check from > __memcg_kmem_uncharge_page() to memcg_kmem_uncharge_page() as > PageMemcgKmem() -- which does the same thing under the hood. Now > free_pages_prepare() can also use memcg_kmem_uncharge_page(). > > No functional change intended. > > Signed-off-by: Yosry Ahmed Reviewed-by: Muchun Song Thanks