Re: [Patch v4 2/2] mm/khugepaged: remove definition of struct khugepaged_mm_slot

[Zi Yan <ziy@nvidia.com>]

On 26 Sep 2025, at 20:45, Wei Yang wrote:

> Current code calls mm_slot_entry() even when we don't have a valid slot,
> which is not future proof. Currently, this is not a problem because
> "slot" is the first member in struct khugepaged_mm_slot.
>
> While struct khugepaged_mm_slot is just a wrapper of struct mm_slot, there
> is no need to define it.
>
> Remove the definition of struct khugepaged_mm_slot, so there is not chance
> to miss use mm_slot_entry().
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Acked-by: Lance Yang <lance.yang@linux.dev>
> Reviewed-by: Dev Jain <dev.jain@arm.com>
> Cc: Lance Yang <lance.yang@linux.dev>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Dev Jain <dev.jain@arm.com>
> Cc: Kiryl Shutsemau <kirill@shutemov.name>
> Cc: xu xin <xu.xin16@zte.com.cn>
> Cc: SeongJae Park <sj@kernel.org>
> Cc: Nico Pache <npache@redhat.com>
>
> ---
> v3:
>   * adjust changelog
>   * rename the slab cache to "mm_slot"
> v2:
>   * fix a PF reported by SeongJae, where slot is changed to next one
> ---
>  mm/khugepaged.c | 55 ++++++++++++++++---------------------------------
>  1 file changed, 18 insertions(+), 37 deletions(-)
>
Acked-by: Zi Yan <ziy@nvidia.com>

Best Regards,
Yan, Zi