From: "Shi, Alex" <alex.shi@intel.com>
To: Christoph Lameter <cl@gentwo.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Chen, Tim C" <tim.c.chen@intel.com>,
"Huang, Ying" <ying.huang@intel.com>
Subject: RE: [PATCH] slub: remove a minus instruction in get_partial_node
Date: Sun, 2 Oct 2011 20:55:37 +0800 [thread overview]
Message-ID: <6E3BC7F7C9A4BF4286DD4C043110F30B5FD97584A4@shsmsx502.ccr.corp.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1109290917300.9382@router.home>
> -----Original Message-----
> From: Christoph Lameter [mailto:cl@gentwo.org]
> Sent: Thursday, September 29, 2011 10:19 PM
> To: Shi, Alex
> Cc: Pekka Enberg; linux-mm@kvack.org; Chen, Tim C; Huang, Ying
> Subject: Re: [PATCH] slub: remove a minus instruction in get_partial_node
>
> On Thu, 29 Sep 2011, Alex,Shi wrote:
>
> > Don't do a minus action in get_partial_node function here, since
> > it is always zero.
>
> A slab on the partial lists always has objects available. Why would it be
> zero?
Um, my mistaken. The reason should be: if code is here, the slab will be per cpu slab.
It is no chance to be in per cpu partial and no relationship with per cpu partial. So
no reason to use this value as a criteria for filling per cpu partial.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-02 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 10:05 Alex,Shi
2011-09-29 14:18 ` Christoph Lameter
2011-10-02 12:55 ` Shi, Alex [this message]
2011-10-03 13:55 ` Christoph Lameter
2011-10-08 2:48 ` Alex,Shi
2011-10-10 17:11 ` Christoph Lameter
2011-10-11 9:50 ` Alex,Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E3BC7F7C9A4BF4286DD4C043110F30B5FD97584A4@shsmsx502.ccr.corp.intel.com \
--to=alex.shi@intel.com \
--cc=cl@gentwo.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox