From: Zi Yan <ziy@nvidia.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
"\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Mel Gorman <mgorman@techsingularity.net>,
Rohan Puri <rohan.puri15@gmail.com>,
Mcgrof Chamberlain <mcgrof@kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [RFC PATCH 1/4] mm/compaction: add support for >0 order folio memory compaction.
Date: Tue, 12 Sep 2023 13:38:01 -0400 [thread overview]
Message-ID: <6CE0050A-96A4-4AAB-8B59-52D079857AF2@nvidia.com> (raw)
In-Reply-To: <20230912173238.GB34089@cmpxchg.org>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On 12 Sep 2023, at 13:32, Johannes Weiner wrote:
> On Tue, Sep 12, 2023 at 12:28:12PM -0400, Zi Yan wrote:
>> @@ -1439,7 +1478,8 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn)
>> if (!page)
>> return;
>>
>> - isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false);
>> + isolate_freepages_block(cc, &start_pfn, end_pfn, &freelist, 1, false);
>> + sort_free_pages(&freelist, cc->freepages);
>
> Can you make isolate_freepages_block() put the pages directly into a
> sorted struct free_list?
>
> AFAICS, the only place that doesn't technically need it is
> isolate_freepages_range(). But that's then also the sole caller of
> split_map_pages(), which can be made to work on struct free_list too
> without notable overhead.
Sure. Will do that in the next version.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2023-09-12 17:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 16:28 [RFC PATCH 0/4] Enable " Zi Yan
2023-09-12 16:28 ` [RFC PATCH 1/4] mm/compaction: add support for " Zi Yan
2023-09-12 17:32 ` Johannes Weiner
2023-09-12 17:38 ` Zi Yan [this message]
2023-09-15 9:33 ` Baolin Wang
2023-09-18 17:06 ` Zi Yan
2023-10-10 8:07 ` Huang, Ying
2023-09-12 16:28 ` [RFC PATCH 2/4] mm/compaction: optimize >0 order folio compaction with free page split Zi Yan
2023-09-18 7:34 ` Baolin Wang
2023-09-18 17:20 ` Zi Yan
2023-09-20 8:15 ` Baolin Wang
2023-09-12 16:28 ` [RFC PATCH 3/4] mm/compaction: optimize >0 order folio compaction by sorting source pages Zi Yan
2023-09-12 17:56 ` Johannes Weiner
2023-09-12 20:31 ` Zi Yan
2023-09-12 16:28 ` [RFC PATCH 4/4] mm/compaction: enable compacting >0 order folios Zi Yan
2023-09-15 9:41 ` Baolin Wang
2023-09-18 17:17 ` Zi Yan
2023-09-20 14:44 ` kernel test robot
2023-09-21 0:55 ` [RFC PATCH 0/4] Enable >0 order folio memory compaction Luis Chamberlain
2023-09-21 1:16 ` Luis Chamberlain
2023-09-21 2:05 ` John Hubbard
2023-09-21 3:14 ` Luis Chamberlain
2023-09-21 15:56 ` Zi Yan
2023-10-02 12:32 ` Ryan Roberts
2023-10-09 13:24 ` Zi Yan
2023-10-09 14:10 ` Ryan Roberts
2023-10-09 15:42 ` Zi Yan
2023-10-09 15:52 ` Zi Yan
2023-10-10 10:00 ` Ryan Roberts
2023-10-09 7:12 ` Huang, Ying
2023-10-09 13:43 ` Zi Yan
2023-10-10 6:08 ` Huang, Ying
2023-10-10 16:48 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6CE0050A-96A4-4AAB-8B59-52D079857AF2@nvidia.com \
--to=ziy@nvidia.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=rohan.puri15@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox