From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BC2C61DA4 for ; Thu, 2 Feb 2023 20:22:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 901B56B0072; Thu, 2 Feb 2023 15:22:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B1CF6B0073; Thu, 2 Feb 2023 15:22:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77A8C6B0074; Thu, 2 Feb 2023 15:22:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6471E6B0072 for ; Thu, 2 Feb 2023 15:22:41 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 381F9141031 for ; Thu, 2 Feb 2023 20:22:41 +0000 (UTC) X-FDA: 80423474922.28.AA7A7A1 Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136]) by imf21.hostedemail.com (Postfix) with ESMTP id BF34A1C0012 for ; Thu, 2 Feb 2023 20:22:37 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=zytor.com header.s=2023010601 header.b=UFfeQLpd; dmarc=pass (policy=none) header.from=zytor.com; spf=pass (imf21.hostedemail.com: domain of hpa@zytor.com designates 198.137.202.136 as permitted sender) smtp.mailfrom=hpa@zytor.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675369358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dXToUAE7pJaQg5q02/GLa3Mz5KxM6AhfOCiviB9LkQ0=; b=uR98Cr6wkYfUQlK6wLGyl/15F3XaDGgcYdrjzX/0Ll9JqwHK7E6LZZ0XmCFYYBVssC+i92 mkVzL8T6ZK/KG1toWRKpiJPkfE/uZO7rzRWZ1zg3NTYhA9SylqHTQQ9V4MboQDVKWDq1O5 4KOTf3AK/GAd3WUMMibkaCT7LWGDyRo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=zytor.com header.s=2023010601 header.b=UFfeQLpd; dmarc=pass (policy=none) header.from=zytor.com; spf=pass (imf21.hostedemail.com: domain of hpa@zytor.com designates 198.137.202.136 as permitted sender) smtp.mailfrom=hpa@zytor.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675369358; a=rsa-sha256; cv=none; b=SlyhNvi+hc019BPD+eBj+HeJPYUo7C+1t7CBeLRulCcOFqMBkBwNEcF/cddmPiV0mKd8Bf SyOiDCxQorkRhJyHLaeEpralf/jeDaVfphG4QWif4ETO8bAI3yt/FWjJuEELTc7VjkJmke co5UjtmStjqg658KXxTxjK1h0vZHIbI= Received: from [127.0.0.1] ([73.223.250.219]) (authenticated bits=0) by mail.zytor.com (8.17.1/8.17.1) with ESMTPSA id 312KLhl02116280 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Thu, 2 Feb 2023 12:21:43 -0800 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 312KLhl02116280 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2023010601; t=1675369310; bh=dXToUAE7pJaQg5q02/GLa3Mz5KxM6AhfOCiviB9LkQ0=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=UFfeQLpd1CqaHNn2oWCKbjD/Ifu3loYs//M/YBH4IzNZ5zM+uQu+ca+o7wZeN5w3F DsbUdz66y666X/uc3jG3vgwkg5rRf6GtVkLag+fJE2MvpK5A0UNEmO1M3fnQXeE1Lo Fnl4Ppvdj9DkLLQ/AJYxM7e3cAS5zRrO/+4y12Pny3EZtxFITNqL4C9j1UlDEGI9HH V7hreJiSU/iR392Npg1nWQoPfZXJyKUx9354wvJDSamVNEibIAyoENMY/UFznsWzLs NKi29eZOby3JTQ76f7S8MgceIaH2aMGDaJX/L7Onx4h96zynB+LoMD69Q9XjMUGe2n iFW315XTSuLfQ== Date: Thu, 02 Feb 2023 12:21:41 -0800 From: "H. Peter Anvin" To: Peter Zijlstra , torvalds@linux-foundation.org CC: corbet@lwn.net, will@kernel.org, peterz@infradead.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v2 01/10] cyrpto/b128ops: Remove struct u128 User-Agent: K-9 Mail for Android In-Reply-To: <20230202152655.250913242@infradead.org> References: <20230202145030.223740842@infradead.org> <20230202152655.250913242@infradead.org> Message-ID: <6B45ADCF-4E3C-4D01-92AB-87BFF6BEE744@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BF34A1C0012 X-Stat-Signature: 354imef3ziwphd61zwy1tddtcm3t7ec4 X-HE-Tag: 1675369357-983700 X-HE-Meta: U2FsdGVkX18TDhK4fOwXPMtx1JNkS6i7KxiN01g2gQyRwg1WLIAq0HfaH+wvutzbW+sXwis0tWQAfJVTt4F4DGfTIVg1zUO7ky6Y8E2uDGYZdz9Bi69nYXYVLWzqNAq79yDGbXN8L7ydU1aGqIawexC4SH9XMeTCrRvzU7SZknN3hjfTQ9Fvi/ZEd0WEoVqYbHA9/wDWoguyEtkzdytRabyJafL3+NntdstmNcyxd7M5W7U9YYf0it1igYrE6t6nrNwt8mR64zNcKsWLzl/uxxwdvEGADyRhpaE0wsAivouM2FepVEYG3DDjVNeltFuA1Unu4EKH/9IEHSehZIHQPwXUXI0zUf7djugSwP+xg3CQgBHduL5H1y+IRgQLBhb8Nu5fYxNMRSswlHkHa63Y7LxFBXdpPF5vnHDUCTTJrguTrcjhoUczgq4blNcxB3qbmj439oiGsh71xMFKc8Zey786pzQ3Ja8s7H5yEHcHG+7JoAC+tZJlAQq16eR0nb9YERNOWgSZc9myENJ5Jl+jR69RsGHbgfcX/vhjEHsyz3nN9N1GEqX515D/eGN3WUkuOR51n5h/e5gUEMOlsgQXjGbGNnwp1temL+nfD7NSCfJqATjzc2zaq/Bh86LG6hWv+p7aB0ftLxIUl2wrFMRTaDj0dYsGIVJN19OlyZ5G0OVA2vh9HE9t5hI9JaKh5T010fhkQKAhs2I4aI05vBeJTA53ZGvEI9H6xxyO5fKCPeTpiI76wG2qRpKb4hAHBMsqoCLIehoglOnUEhwq9IAnmcapaNFaRLIyf2vwT6wUeAkJcePYgAq7hwkkxvNkaUFSDRBzKmHI8jqunWPTJ1MGChHJ1hXAUck71LvhFid9WNcVCKuJsD+9v6FIma8nvCtRhvWeVdafurKZ0t/eusBrEzk2pxlHKAqvYASc5V0QnqwMbfy43Oaj4s0Oj1Eo9b+a5rHp+CawfvvvHQlAOZG 4Rt3cZMT zdOEt2SvunQH/BdNuUR9xzPOE4S2Pgy/rkh4IgCX0gmjCHdSK0sZTsZQpGJ2rZWTonoYStztmsosJzfEcdyyGR0UueNAC9EoXQpRvLXKHoLYnXnHPo0yeLzrO7Aeeyvkcn28zw7NmqPIK+nYd4ZxXhGbCogao5WFnNd/r3jlMbvcD5R3MnoyG1WGreVnQ5br2T/8P8lkywjEuelOSSqHoJhyx2VdJhGG/KXA/I4KhkJrx9OM8fPdL5Sv5Y1gf3/7dXRp6psvnlMttJ7DJSB9/JHsw/2caQVNqvHlq5lHa1MeFvTUefo1P3mxgS9naYcgPoDf5/+NxOoLJhQY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On February 2, 2023 6:50:31 AM PST, Peter Zijlstra = wrote: >Per git-grep u128_xor() and its related struct u128 are unused except >to implement {be,le}128_xor()=2E Remove them to free up the namespace=2E > >Signed-off-by: Peter Zijlstra (Intel) >--- > include/crypto/b128ops=2Eh | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > >--- a/include/crypto/b128ops=2Eh >+++ b/include/crypto/b128ops=2Eh >@@ -50,10 +50,6 @@ > #include >=20 > typedef struct { >- u64 a, b; >-} u128; >- >-typedef struct { > __be64 a, b; > } be128; >=20 >@@ -61,20 +57,16 @@ typedef struct { > __le64 b, a; > } le128; >=20 >-static inline void u128_xor(u128 *r, const u128 *p, const u128 *q) >+static inline void be128_xor(be128 *r, const be128 *p, const be128 *q) > { > r->a =3D p->a ^ q->a; > r->b =3D p->b ^ q->b; > } >=20 >-static inline void be128_xor(be128 *r, const be128 *p, const be128 *q) >-{ >- u128_xor((u128 *)r, (u128 *)p, (u128 *)q); >-} >- > static inline void le128_xor(le128 *r, const le128 *p, const le128 *q) > { >- u128_xor((u128 *)r, (u128 *)p, (u128 *)q); >+ r->a =3D p->a ^ q->a; >+ r->b =3D p->b ^ q->b; > } >=20 > #endif /* _CRYPTO_B128OPS_H */ > > Can we centralize these ordered types, too?