From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCA8C433E0 for ; Sun, 10 Jan 2021 11:58:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 61114238E5 for ; Sun, 10 Jan 2021 11:58:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61114238E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 66F306B00EE; Sun, 10 Jan 2021 06:58:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 618E76B00EA; Sun, 10 Jan 2021 06:58:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4693D8D0018; Sun, 10 Jan 2021 06:58:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 2B3E16B00EA for ; Sun, 10 Jan 2021 06:58:56 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E94E5362C for ; Sun, 10 Jan 2021 11:58:55 +0000 (UTC) X-FDA: 77689719030.23.taste42_4e0a76927503 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id BEAA437606; Sun, 10 Jan 2021 11:58:55 +0000 (UTC) X-HE-Tag: taste42_4e0a76927503 X-Filterd-Recvd-Size: 5162 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [85.215.255.83]) by imf29.hostedemail.com (Postfix) with ESMTP; Sun, 10 Jan 2021 11:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1610279932; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:From: Subject:Sender; bh=suxnFiUZXehwYdxu3HHH3yerlSomJchhrhNdK2IYwzY=; b=J9t7Rz8O0EKNl0xZnT0ZdEtSch22w4CHNPJKYUvxKsYdLO2RKlFvElGir/vXeaWfLJ qTPWqEX1SZBkwY3qSMB7A8W8v+f16Ly3erv6b9UFaHaPiapDK3uob7ZkjJGNxcMvuSKM LwUWJxtjW1zHfB/xvBy5pGaksPxBbeQL+0s/5OP8cuBiN3J3li5IOtmjULzb9/pGxMO3 xv2JdHXwuvsMQtjmfoyR5Aaj/dZFZlK3eARNMwvGB3ygL5btB2b1VDSXAvb0kBcSbQ3J 0UL6YZ7+bs86ZktsLzWejHxbNrJCNSSq0cnNtCUVUw21TdRKxhfbeTThH7SaB87GTBl2 O/eQ== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGHPrrwDOsPyQ=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.12.1 DYNA|AUTH) with ESMTPSA id m056b3x0ABrBL8P (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sun, 10 Jan 2021 12:53:11 +0100 (CET) Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=iso-8859-1 From: "H. Nikolaus Schaller" In-Reply-To: Date: Sun, 10 Jan 2021 12:53:10 +0100 Cc: Thomas Bogendoerfer , tglx@linutronix.de, airlied@linux.ie, airlied@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, bcrl@kvack.org, bigeasy@linutronix.de, bristot@redhat.com, bsegall@google.com, bskeggs@redhat.com, chris@zankel.net, christian.koenig@amd.com, clm@fb.com, davem@davemloft.net, deanbo422@gmail.com, dietmar.eggemann@arm.com, ML dri-devel , dsterba@suse.com, green.hu@gmail.com, hch@lst.de, intel-gfx@lists.freedesktop.org, jcmvbkbc@gmail.com, josef@toxicpanda.com, juri.lelli@redhat.com, kraxel@redhat.com, linux-aio@kvack.org, linux-arm-kernel , linux-btrfs@vger.kernel.org, linux-csky@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-graphics-maintainer@vmware.com, Linux Kernel Mailing List , linux-mips , linux-mm@kvack.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, mgorman@suse.de, mingo@kernel.org, monstr@monstr.eu, mpe@ellerman.id.au, nickhu@andestech.com, nouveau@lists.freedesktop.org, paulmck@kernel.org, paulus@samba.org, peterz@infradead.org, ray.huang@amd.com, rodrigo.vivi@intel.com, rostedt@goodmis.org, sparclinux@vger.kernel.org, spice-devel@lists.freedesktop.org, sroland@vmware.com, torvalds@linuxfoundation.org, vgupta@synopsys.com, vincent.guittot@linaro.org, viro@zeniv.linux.org.uk, virtualization@lists.linux-foundation.org, x86@kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <6B074439-2E91-4FCF-84C8-82AE13D8C7F0@goldelico.com> References: <20210108235805.GA17543@alpha.franken.de> <20210109003352.GA18102@alpha.franken.de> To: Paul Cercueil X-Mailer: Apple Mail (2.3124) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 10.01.2021 um 12:35 schrieb Paul Cercueil : >=20 > Hi Thomas, >=20 > Le sam. 9 janv. 2021 =E0 1:33, Thomas Bogendoerfer = a =E9crit : >> On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: >>> On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: >>> > Hi Thomas, >>> > >>> > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this = commit. Just for completeness, I have no such problems booting CI20/jz4780 or = Skytone400/jz4730 (unpublished work) with 5.11-rc2. But may depend on board capabilites (ram size, memory layout or = something else). >>> > >>> > Any idea what could be happening? >>> not yet, kernel crash log of a Malta QEMU is below. >> update: >> This dirty hack lets the Malta QEMU boot again: >> diff --git a/mm/highmem.c b/mm/highmem.c >> index c3a9ea7875ef..190cdda1149d 100644 >> --- a/mm/highmem.c >> +++ b/mm/highmem.c >> @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, = pgprot_t prot) >> vaddr =3D __fix_to_virt(FIX_KMAP_BEGIN + idx); >> BUG_ON(!pte_none(*(kmap_pte - idx))); >> pteval =3D pfn_pte(pfn, prot); >> - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); >> + set_pte(kmap_pte - idx, pteval); >> arch_kmap_local_post_map(vaddr, pteval); >> current->kmap_ctrl.pteval[kmap_local_idx()] =3D pteval; >> preempt_enable(); >> set_pte_at() tries to update cache and could do an kmap_atomic() = there. >> Not sure, if this is allowed at this point. >=20 > Yes, I can confirm that your workaround works here too. >=20 > Cheers, > -Paul >=20 >=20