From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BCEC83F03 for ; Thu, 3 Jul 2025 18:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1235F8E000E; Thu, 3 Jul 2025 14:49:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AD4C8E0009; Thu, 3 Jul 2025 14:49:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB81E8E000E; Thu, 3 Jul 2025 14:49:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D69FF8E0009 for ; Thu, 3 Jul 2025 14:49:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 531BD1A05FD for ; Thu, 3 Jul 2025 18:49:39 +0000 (UTC) X-FDA: 83623842078.19.918E8A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id BB58AA0008 for ; Thu, 3 Jul 2025 18:49:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KvYTr/d8"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751568577; a=rsa-sha256; cv=none; b=Fos3vM7Jb0aG9b/jkek4ztSRQ/PQiO1WQbF1gv2kNiMunxdLgw4OTGHUNoWh795NjYz+6R YAwdtC3rJB396Cjedu67/bQRfM5sYGkVFxauSAvjIcLuXUjurrCrPPnPspKXcatsy7OM2/ NtEIVvLhrfL4rcyHYpaGY9NT6OApI4Q= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KvYTr/d8"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751568577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NOH1xRpy/YyBfozfJ8P2ZweRpbpKUCYA87qs5I4Iy+k=; b=v+/VkzszlWsMR93BSs7Jp6/a66hlO/LM2AEePVO8HFL0jrsf1Ztqf03McfY06p4ferzPZ/ KUlgEV4BFA2k2iJPSVYdNqrYOaP0syGXF5i4GN6FnYj9hI4L7SQQnF8rdssFZI7MwLauNv axAYaHmohuJpO/S3V2CC4gYmfClfjdU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751568576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NOH1xRpy/YyBfozfJ8P2ZweRpbpKUCYA87qs5I4Iy+k=; b=KvYTr/d8dT+LqbzA4CnZDEv7qSqSIUqh/VXmhpFzk/OladmXlhg8IkhIDSHU6hf87EM+o3 5LLUPT6IrGA6v1ZOOaFRUyq+tT6Ux+bgLvW/TUoDWFwPyFWIGKZW0hsF5rmY0lvkVIvMBk XV18vIHCs5E1lFCymYAe7J8kxUfTwRk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-yeiwsqXJPb-HCR5C3XXFNQ-1; Thu, 03 Jul 2025 14:49:35 -0400 X-MC-Unique: yeiwsqXJPb-HCR5C3XXFNQ-1 X-Mimecast-MFC-AGG-ID: yeiwsqXJPb-HCR5C3XXFNQ_1751568574 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a503f28b09so110954f8f.0 for ; Thu, 03 Jul 2025 11:49:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751568574; x=1752173374; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NOH1xRpy/YyBfozfJ8P2ZweRpbpKUCYA87qs5I4Iy+k=; b=cvu3eAXBzMygjUiVADplxI6VWvfO2NUEbvsCjUpACX/CeH+14AEudtGkvz/8h6ODz/ 1mP7KsEYMSygKdAkdY3g45jd1cGTN2AkcfGXo/xRzY6iae3ADC7UJ3Uq2HAOEaXEGIYW 4bgaumvsbDS39aoHDyVa6673ac+CCjmOsstnmcp4o+ywDEqrfRELE1bdeNdyeHGfBk+4 Jw6XICCTCaF217OFnHb7L/EhkOxNFWetm5jdw0kKReN9htQ5/3PW4oN5NGWOzszCjHUv 5VMrEqJzrHekyGOMEAIVy9GqHTLtQseCnrLeMUxRyMq8PNRpctQQ08zqnSuL/WLvjHjQ Twzw== X-Forwarded-Encrypted: i=1; AJvYcCV8r5imfBWHDjCfc97UlMUth5oLRrr67T2JYSA5CBFQXTp9/VJg7DofuUbAeU9WW4UlP/bRU1oN3Q==@kvack.org X-Gm-Message-State: AOJu0YzMwrFIZmQnIhDB2wYY/KI1IZsUbQf8thglj2MlvxXoMhxckaAE dPsSGMeknGT3H1GyrYiNLu+o9RvKa7t/LAD2vdH3lMbgwzx7GR5aUr6WP801uPeJQFJmz0Y/Pjf 6D7zWq6js78XCNSvSyhK5MD9W2LwGFWm9Lx64PMY3W1/NmvL7WAb9 X-Gm-Gg: ASbGnctYA11R+8o1HrvKArMgaiXHYMylK7Nj4+k6O6IDoOqC+O7nZKHJ19wkq2BrZaK 9cGewnk7WwOa6DOG+5NE8uiZ5Oi9qi8u0VvvrNjvb2dmzs5wCdTzo9QgVKQq/ii8PmtxQSGHP4+ 9F+6qU2G0yb3rRc1pYYss8aLTFf/srsUElA9CgDl2UsdBkds12Jp49+GIVGDRIG6j/TodkiqVnc UzD5N6kshqTB36m9sW0bL/XJwNDizZQuPu0nkwB5cniB5HRSr+3axjGOxLuuthamO9gf/2rdJWE Mstuw1j+H40t//OjyS6ifF9tHTsvbZbaDtmz5+sXSEagQPXlkvJ6BGU/f0cAY50xeH+3z5Utuye TOWkQeAhbi1SYki0Jh5nkyMmUkn0J/f1pFV47WunJpSmIhcnFgg== X-Received: by 2002:a05:6000:26c4:b0:3a4:cec5:b59c with SMTP id ffacd0b85a97d-3b495590309mr240836f8f.25.1751568573809; Thu, 03 Jul 2025 11:49:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9gTIMf/to8++VYHHGbgp/BIq0/O1H+7QZCYXM4dHpEr3MszFw9yUH4JFqTCZrQH3dXjvpsQ== X-Received: by 2002:a05:6000:26c4:b0:3a4:cec5:b59c with SMTP id ffacd0b85a97d-3b495590309mr240820f8f.25.1751568573393; Thu, 03 Jul 2025 11:49:33 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:e700:2bf6:1031:382d:5a85? (p200300d82f1be7002bf61031382d5a85.dip0.t-ipconnect.de. [2003:d8:2f1b:e700:2bf6:1031:382d:5a85]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47225b23csm446536f8f.84.2025.07.03.11.49.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 11:49:32 -0700 (PDT) Message-ID: <69f8a565-f9d5-47d7-9243-9c0e4769d948@redhat.com> Date: Thu, 3 Jul 2025 20:49:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/memory_hotplug: activate node before adding new memory blocks To: Hannes Reinecke , Hannes Reinecke Cc: Oscar Salvador , linux-mm@kvack.org References: <20250702073913.58247-1-hare@kernel.org> <20250702073913.58247-3-hare@kernel.org> <3a790038-cd63-4c4f-af05-e98aecb56bb8@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HAz0c9LK9cfltRsH6ppWWJa0eYIY8627quaYCi1R4FQ_1751568574 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 597s9t3anubno8qecsozm7dn4hb3h5sd X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BB58AA0008 X-Rspam-User: X-HE-Tag: 1751568576-327320 X-HE-Meta: U2FsdGVkX18jVWYvjxBIK1/EO42I4L+IEtQROFaSFZyE837No6dGAveQ61Rd8ZiF4LXb8Ma//zUFCdRhL10q8Xrpm6fEcobfSISjDZ8scP0d9fDPTbm7Eyv0v2//O/+pQnJ591QSbLNa5Jcy0tqyKIHg6zdJmina4BuaK2/mCMdb4JgLazzVksjbIIi+yb8CEYBRbBoCSvEvH2Ri4EZkzaD5YPL3442FJoSJIcU1CmW33rO5tuvNDREHFYXqZ9COwjTInQKUVWSigR9LR0wdtK45JFBAp9ZavNvr3ePvvEpxrZixijUuGckmPAi+AR3IjyefNGdJ0kurRw1xfGAr3LHpOB24yM6I2dwfu+tenrOaCWmyvSZIdsrmSJuJNyT+ZM+axngWVcvmLVx7F8dbN0lMaNZ+aKgui0yhpXSMuudy47Yh+l+WQIGJBAyEC2pUWsJgmWVMvZFZP8uJpKinL+Ih0/PtfZ4c/vViN7afHkFQjch9Jbm2MJKOsLUdUyxPG4F2DAcduNBQfGs6Z3QQSx4OpeEoW+qQ5ISNCNq23x55HyBBoI8nLbpp9wFWuDuGwOA5UdqMDRfrrwhfvOv3mP6laM/h5P5lBTTdS0bOn0HZ+zAUJdOSwgh11lBiPNVfQfwz0VD3Co+cjUnOkGqH0TrxhVQ1y684XW35kSjj+bszfS43v/Ewsk1AL21qRrh90DNdloTPmn4yULko5Ar7wHoVlGknt/l43e37dPpMKrtGEW/KFtdg2qwGsc8/gPlPCp7dypZ/2ar1aMgd0rgiCSMLJilidcrFynnW5srGjHi/9p1m7FALRwoV4bU1SrNF8JGHtRZGILU7TiXVSq5o2LMDSLDlJ6OpNXB+q/LoRp9VeH+Jg7CCFxRcktzQnlss6eO0j5ZEM/to9x0xrUxehAhrvLIQQhLW3dummmkzgdyOZSwEaYBhum82l5H/aBip11hVwgYgRIrG15dRjmt 47ShuGxc kCCvf29U20zjmwuaSQqlHcq3wPK7KJP/9h5J6z5ge/i+/JqI38VbG2NFngn8u68NMehHkGeVpgVrC7Yh6VLuaJ/C+Zy3eWhodl8ad57WHcfmQeaVECQUPhLcJJGUBb0oBkdEKobuBT+hKywb++sP2wlOFzI5P7RQr9sk2B5cdy1fFVCTP7dBSrWPXnRjeujBrmp898z77DSf3SyQs+tAOcKGgGY7E27ryl9EuAHzWGpvza+xj4MRrp1KN+jknYXyY2HjrXz5ckcCzBqzlnXQtk2v8h6c6dcGW2p5eDCFDjEqZ1lKFqpqoVDOpDM39niFOr+Qc/KHkLzghRXV7oFJPcOR/O8s5O/7brUovlM020UhAFUZrTXulA22x/def+6L9Wj9neVWjqu2uWwnh1/mYaYvxxmG93QpvPLaZWxjS21Em/cHFxfh81cblQd267q1rNNNaJJD2HLtKSE7Fy+zCUwzaPIaKlHRzRbzAsS9Bja6uGdLzO7azc5DwXebP4hLtU9OEzuFndSncCuWpLmhpx0yoXuKvn1gegE7UNKZbJxYmvMNKsWMobbFNXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.25 13:54, Hannes Reinecke wrote: > On 7/3/25 13:29, David Hildenbrand wrote: >> On 02.07.25 09:39, Hannes Reinecke wrote: >>> The sysfs attributes for memory blocks require the node ID to be >>> set and initialized, so move the node activation before adding >>> new memory blocks. This also has the nice side effect that the >>> BUG_ON() can be converted into a WARN_ON() as we now can handle >>> registration errors. >>> >>> Fixes: b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resource >>> use __try_online_node") >> >> We should CC stable. >> > Yeah, that's probably not a bad idea. > >>> Signed-off-by: Hannes Reinecke >>> --- >>>   drivers/base/memory.c  | 19 +++++++++---------- >>>   include/linux/memory.h |  2 +- >>>   mm/memory_hotplug.c    | 32 +++++++++++++++++--------------- >>>   3 files changed, 27 insertions(+), 26 deletions(-) >>> >>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c >>> index 2b951e5f8a27..d24a90e0ea96 100644 >>> --- a/drivers/base/memory.c >>> +++ b/drivers/base/memory.c >>> @@ -810,15 +810,14 @@ void memory_block_add_nid(struct memory_block >>> *mem, int nid, >>>               mem->zone = early_node_zone_for_memory_block(mem, nid); >>>           else >>>               mem->zone = NULL; >>> +        /* >>> +         * If this memory block spans multiple nodes, we only indicate >>> +         * the last processed node. If we span multiple nodes (not >>> applicable >>> +         * to hotplugged memory), zone == NULL will prohibit memory >>> offlining >>> +         * and consequently unplug. >>> +         */ >>> +        mem->nid = nid; >>>       } >>> - >>> -    /* >>> -     * If this memory block spans multiple nodes, we only indicate >>> -     * the last processed node. If we span multiple nodes (not >>> applicable >>> -     * to hotplugged memory), zone == NULL will prohibit memory >>> offlining >>> -     * and consequently unplug. >>> -     */ >>> -    mem->nid = nid; >> >> I would not perform this change in this patch. It's not required here, >> right? We're simply re-setting the nid. Patch #3 can clean that up. >> > > Well. You tell me :-) > > Thing is, we already have a 'nid' value as argument to > add_memory_resource(). > So I would _think_ that it should be the same value which we end up > with in memory_block_add_nid(). Yes, on the memory hotplug path it should be the same value. Everything else would be really broken. > But if that's the case we could've set it during memblock > initialization, which we don't. So I thought there must be a reason > for that, and the only reason I could think of is that 'nid' is not > known during memblock initialization, ie that the 'nid' value in > add_memory_resource() is a different 'nid' value from the one used in > memory_block_add_nid(). It must be the same. Only for boot memory, we can have multiple nids. And the current behavior is to set mem->nid to the So unless I am confused at this point 1) You can avoid changing this function in this patch. We will reset the same value in case of memory hotplug which ... 2) Will be cleaned up by patch #3, where we simply call the function only for early memory. Makes sense or is the warm weather affecting my reasoning? :) -- Cheers, David / dhildenb