From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88245C678D4 for ; Fri, 3 Mar 2023 09:10:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBD706B0074; Fri, 3 Mar 2023 04:10:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6D746B0075; Fri, 3 Mar 2023 04:10:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0F406B0078; Fri, 3 Mar 2023 04:10:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B444A6B0074 for ; Fri, 3 Mar 2023 04:10:44 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7DE0D12114A for ; Fri, 3 Mar 2023 09:10:44 +0000 (UTC) X-FDA: 80527016808.24.ABCFC1C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 61ABAC0002 for ; Fri, 3 Mar 2023 09:10:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A+hERbnK; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677834642; a=rsa-sha256; cv=none; b=1503leCr7bkA7S0FTtSe2snOX0NB+ozpR2UL/Uj2tgcvI7dLzodLkJ0Oz6iqGOh1Qt5u9u b+HIYmSd0PzZlyi/sgIi/AAbyJ81L32rKwZ0cAIIPwBQiWh8tOLC/If9Xtshjas7a9Draz 71Tv7hbgdvO2Yy+dyGy6EUHUzfgwOT0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A+hERbnK; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677834642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HXI/KwXPhFbkBH6af+6R7enVWQYOnZi8AQZj8HTOjaU=; b=jPqEoE+0OEnP1lMkAKOg+OttCEaRApOUyWJdZol7OlFR9N0u7HGhWn0clkBGHGC38PgcKu Db7Q2tsW0J7UUV9Z27eV5Rjh0upEVVneEWfxkONV3wIL3Xm9clMmEmpzsqtm9hd4xq0INi uxgVAnkVov1nA/Ebstj2no7239TYibM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677834641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXI/KwXPhFbkBH6af+6R7enVWQYOnZi8AQZj8HTOjaU=; b=A+hERbnKHtn4yv/d0bZhUDNopqXvOwbJaygUJkugst4OsSSHzWtSuhz5q+50VjdMxXoN/d 9B9qw/IsObnPlgw0fT/IRzlegEFZN52zy+xVlmnAvMV/ghjdgyTwTVZ0KEvumF9la1yaIq sFKKeycBYWj3j+mkEINBGwgbaBVNuPw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-T7wy1T6oN-CJ4QyQsmr4qQ-1; Fri, 03 Mar 2023 04:10:40 -0500 X-MC-Unique: T7wy1T6oN-CJ4QyQsmr4qQ-1 Received: by mail-wr1-f71.google.com with SMTP id y11-20020a056000168b00b002ce179d1b90so270301wrd.23 for ; Fri, 03 Mar 2023 01:10:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HXI/KwXPhFbkBH6af+6R7enVWQYOnZi8AQZj8HTOjaU=; b=zSStiBXc6LSFw9O//BxiK5Q/QHKivThX/7+t8rWovo2XArMR2tKyJZDkZjjKIUn6L/ hV3Yj13t7naLhiFI2fig+N7SX2UkN7sEaA1pezXtltXxgBPxe8fvfGjs4qLBCIGXmv/U u2qIcdj2iHLESEuaXRkQNmzsumQEDlhGVJCnuIgbUWrKFydd0MFfPIaxHq+CZxUtKwml BIBBgLZoGnk4rZOQORmD2DLgzO8ch1GV3qjpy/FVYgPP60MEDbnPcwaesCWzXcHVuWMH NIbd0tfbdf71U7zhftQomjbyRuf5ag5g7bHISxg0aKUA0wyOOenZX6RdLmt3FAwYlHQ5 +00g== X-Gm-Message-State: AO0yUKXgcsqRDTt/4kt3PfVc79WxwZtkdzNwqkwcdivEgTt56RdjQ7CD jI/F1dXWoRYXCKhzYP3o7DcYJuj+DngeNdb/tgO9+xehj7KhRYeQLV5S35zCJafZIbdzKwYFesC 94MA55fZqAQY= X-Received: by 2002:a05:600c:3506:b0:3e2:153e:6940 with SMTP id h6-20020a05600c350600b003e2153e6940mr928708wmq.3.1677834639428; Fri, 03 Mar 2023 01:10:39 -0800 (PST) X-Google-Smtp-Source: AK7set+nfWELVtc6ZcZE0RJVtqWlo1SAKeb38bjkeXY1Tqv3v2p5b+b/BgiTKzEB/8+zsdo8s/cDHQ== X-Received: by 2002:a05:600c:3506:b0:3e2:153e:6940 with SMTP id h6-20020a05600c350600b003e2153e6940mr928690wmq.3.1677834639084; Fri, 03 Mar 2023 01:10:39 -0800 (PST) Received: from ?IPV6:2003:cb:c702:6100:f5c9:50a5:3310:d8ac? (p200300cbc7026100f5c950a53310d8ac.dip0.t-ipconnect.de. [2003:cb:c702:6100:f5c9:50a5:3310:d8ac]) by smtp.gmail.com with ESMTPSA id x8-20020a1c7c08000000b003eb2e33f327sm8915498wmc.2.2023.03.03.01.10.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 01:10:38 -0800 (PST) Message-ID: <69e08e1c-88f6-bf93-523a-b65ffb9235c5@redhat.com> Date: Fri, 3 Mar 2023 10:10:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm: teach mincore_hugetlb about pte markers To: James Houghton , Peter Xu , Andrew Morton Cc: Axel Rasmussen , Anish Moorthy , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230302222404.175303-1-jthoughton@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230302222404.175303-1-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 61ABAC0002 X-Rspamd-Server: rspam01 X-Stat-Signature: gqioip9tqnrrs1fx1wgn9jzdp54c7fee X-HE-Tag: 1677834642-305697 X-HE-Meta: U2FsdGVkX1/iFx8U1tsK6pjKKjJjdUbUF/8VbowkGDAm+Y+6tdq+259+bNvIEX/+1AXRdIA/DDKwbJneB4Zeqiks0srkggeDopeu6Bx2QgNAJlaaqZpSnXPOqIgKq2ObLVVfnYW9rJ42HrEKoR8H8XU+vlTfmzNQQQvL9bN1xMKTmyOJ6vD5RBlkRHySfLBrQmN1XwWVeZu5WU+khelebM+rgJIhRA8DeeuQ2PuqHQe7RGnb4BfiEZoSLHAFY4EISVLWtOCFuhprk8SWSKiGRjBJuZBnc7dAycK7BUUxhozcTXL2Ut+TN6oVbYhT2Qa1LqDYB6C4WmCnX5kbC9WUI80HiIsynba5IxqaozN5vRUnUTvvnB87TbprIGgq0Km4x0COTTi94fx2tepT8WBjlbHeQt1jdo1fI5nQuzcAi4esQXazQ+ogJpEbJ+YAYMq0Ash/9cILAqc14UVpfJvWeLpC3EjwqSg4h7Wi0hDK7q5How4o0zGcxKDUQEKhQeOF9wlyzgybH/6VIACu1q0w1ZdZ4XSB8zdS3HJ1/2NoHss1mTQXAgNrAx0TXxWeTEDs68GzX27E3hF/CxBc4/Tl5T7SgG4Tw4tPExbWqdurxTOxDil0Ud+4RPYjKqvv4fV6BYZIqeee/bv725BQ19BVjQBOfRL8wO0eSCp6333dqCprhcmMDMWPuPZ5tz8+ah0MX1H/DXDkae6uq32pDVln61TeLIynKT3D+IAALmsDfSJ+D10eVhxE7fZFhUa2C1GDmeywMmnRnZkyVceehJhI6V3rdVG56sHyDkA16qZPK13YZ6wxJR8AaaGB9uc72Ds9+snGay/rqPI6x3eQCoCLomhTz4nCKM317HlYTXs+M43gyH26qokNfbkCKaXn/YDieps05e7RSSIQJ/RMXckyc8yzAjz/6SrIRmtsMdLgH10zI//G0txJ/QTyC41USsWjXs4Xg3uWw41vUUUlIir qZnv28y2 OUc0QgFQXoNiavLmtxC53ofl2uaYKSCvF8IV55ke+dt+3U1JyYJzRIXJQsr0FwxNQkL60V3Q2L8h03l8lI8Klduh+JBBw+AmqUQkUY7/VEE4z84H2602rlBwZwC2gxY1bDou/Rqo/Ift0JYACSiVJ5QuPgnBZJpOK4mjaTaTL+SDJIjTq1/Cv+O4BwqRbGYJlCxOSqUFE50NUJSro9GWvsocsonDQzLCe/D5QHLanqFBgWxkjTIrouJdDTg/bH0SxIybaZ+/oMKqi6GGU2LMIYaGSdeklW7LW0IKRfi9lLkm5i9JPGQBxfBXJmcS4ZaPS6W6vz5XCiNM/l+3jCOlBXq4HST3SynJ2HjK+pZKTOvobKI7F+IhnrFruRDDzbCcBX1IGzjH3/+c0TOE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.03.23 23:24, James Houghton wrote: > By checking huge_pte_none(), we incorrectly classify PTE markers as > "present". Instead, check huge_pte_none_mostly(), classifying PTE > markers the same as if the PTE were completely blank. > > PTE markers, unlike other kinds of swap entries, don't reference any > physical page and don't indicate that a physical page was mapped > previously. As such, treat them as non-present for the sake of > mincore(). > > Fixes: 5c041f5d1f23 ("mm: teach core mm about pte markers") > Signed-off-by: James Houghton > --- > mm/mincore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mincore.c b/mm/mincore.c > index cd69b9db0081..d359650b0f75 100644 > --- a/mm/mincore.c > +++ b/mm/mincore.c > @@ -33,7 +33,7 @@ static int mincore_hugetlb(pte_t *pte, unsigned long hmask, unsigned long addr, > * Hugepages under user process are always in RAM and never > * swapped out, but theoretically it needs to be checked. > */ > - present = pte && !huge_pte_none(huge_ptep_get(pte)); > + present = pte && !huge_pte_none_mostly(huge_ptep_get(pte)); > for (; addr != end; vec++, addr += PAGE_SIZE) > *vec = present; > walk->private = vec; Acked-by: David Hildenbrand -- Thanks, David / dhildenb