From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44AAAC021A4 for ; Fri, 14 Feb 2025 18:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEEE4280006; Fri, 14 Feb 2025 13:49:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9EC9280002; Fri, 14 Feb 2025 13:49:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A17E7280006; Fri, 14 Feb 2025 13:49:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 85C50280002 for ; Fri, 14 Feb 2025 13:49:02 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 378B6A0640 for ; Fri, 14 Feb 2025 18:49:02 +0000 (UTC) X-FDA: 83119437324.29.48202EC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id D9C1F18000D for ; Fri, 14 Feb 2025 18:48:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JI7DaFAS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=02+Eo2Pg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JI7DaFAS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=02+Eo2Pg; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739558940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TgF96WhEEyLdK7gvLBgbFBvWNi860WyYSRk9rPBUMrs=; b=r+zVCUdAKkiQ4nxzH7sPVy6gB1PHxPE0xSOhxS40+p1Z16uC9gV3VRIIgYwBWi8V2y9Tho FSMzxJDo94KBt1VAFo6vtJ7D+hmFhK3/JEcpsPoOkkPI6nNT3parCRdJCmip6x0njrGDpm Z2zq3f1aTzsXvkeZieOdcWOp0HpU7EU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JI7DaFAS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=02+Eo2Pg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JI7DaFAS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=02+Eo2Pg; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739558940; a=rsa-sha256; cv=none; b=tdehNHzhZG07fHBgtBSzLDDsEzarc1GaNHzYTwqWScPgDGQx8z8qWsZ/GMoeL07h+AnWPf 8q8tNzzMAFxxKkCjJzZ0Fez88jRfraw/EkKQbBP4BcWdYvPXdsa3BYMt7iKqHKDz48AUjd DQU6t1THGd3HgpStps3wLfQ6EYN6jrc= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6381521163; Fri, 14 Feb 2025 18:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739558938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TgF96WhEEyLdK7gvLBgbFBvWNi860WyYSRk9rPBUMrs=; b=JI7DaFASM8mlAgVz3BWcKmSQ+DtTpXzJg3iacTvhDamjBNJm7AfqZVxprlB/1ntbUGxEvg co3e/di1ZTMPBVstvKrH1hHvXhR+9n97kCSeEs0Fkv2DGxiO1/HUVTcU+Y74gDv4ZoryWv i6umuO9EWPRgTmfU6tRldXbBMhH+Tyg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739558938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TgF96WhEEyLdK7gvLBgbFBvWNi860WyYSRk9rPBUMrs=; b=02+Eo2PgLPmEeQbX8acZzMaaxuPdLsrVUSkcV2HH0BgKJ5ff580SP23lLpck9c5v1MJOw5 1dV/kkq4S0haAJAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739558938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TgF96WhEEyLdK7gvLBgbFBvWNi860WyYSRk9rPBUMrs=; b=JI7DaFASM8mlAgVz3BWcKmSQ+DtTpXzJg3iacTvhDamjBNJm7AfqZVxprlB/1ntbUGxEvg co3e/di1ZTMPBVstvKrH1hHvXhR+9n97kCSeEs0Fkv2DGxiO1/HUVTcU+Y74gDv4ZoryWv i6umuO9EWPRgTmfU6tRldXbBMhH+Tyg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739558938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TgF96WhEEyLdK7gvLBgbFBvWNi860WyYSRk9rPBUMrs=; b=02+Eo2PgLPmEeQbX8acZzMaaxuPdLsrVUSkcV2HH0BgKJ5ff580SP23lLpck9c5v1MJOw5 1dV/kkq4S0haAJAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 364DE137DB; Fri, 14 Feb 2025 18:48:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qptGDBqQr2dWdAAAD6G6ig (envelope-from ); Fri, 14 Feb 2025 18:48:58 +0000 Message-ID: <69dd9d1b-0a8e-4e39-b37a-20f60d0928b6@suse.cz> Date: Fri, 14 Feb 2025 19:48:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v8 3/6] locking/local_lock: Introduce localtry_lock_t Content-Language: en-US To: Alexei Starovoitov Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Sebastian Sewior , Steven Rostedt , Hou Tao , Johannes Weiner , Shakeel Butt , Michal Hocko , Matthew Wilcox , Thomas Gleixner , Jann Horn , Tejun Heo , linux-mm , Kernel Team References: <20250213033556.9534-1-alexei.starovoitov@gmail.com> <20250213033556.9534-4-alexei.starovoitov@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D9C1F18000D X-Stat-Signature: zxuso6ra1dqrjiyij19dcg8pwhzfj7x4 X-Rspam-User: X-HE-Tag: 1739558939-678595 X-HE-Meta: U2FsdGVkX1/9pJMl/KKqHG1LXKzAfZhmIJMvTDmyZc3MSu9inDfrTII70jSWXS0/xyRXw/44I0NA53q7afjBn0Hlyd80N0+Ls7a4lxdB6Jf4h3LLXc26Kjs0VdMuRWDGq2Rq+kEPvzus4HrWY8xmoyZuYvInX3JZd6sIBK4gT/JCtNXwGij+eutqQ12hfcALfPiD9oAKojbM3LTAK/kVbgz4bqSSFxUMmQCdE73lKr/v9uPO7Yr55e3CpEjvo+fCapQT+CZjV4ozRaaCFDytDxaXFZXlamHzlcOpPN6Mzkvs1JzB72Al0AVm0k+lP+2j7HxxTaComOM0n7LqD3M4/NszUVlGBwCBJtc/Zply4O7oZx6YpY4ra9n0PXA83QJitg6h5HkZeKz2zabnLqlEDWzcDaQPqC48dPLuD7cJN3TJmtqPG/2DQuyq/T3+fKktiW8qjvUQzDpPdEUmJW/lV0kcyyxwFb7NNSCt5BqRoI5YfPrs3CXMz0R017V6jOIFbdMFtKZgwpZtkXD/DvWdtYJST9dVdRmHzynNRwTJzLkSPtIu0WY4Wj08O5QjeiGmIyWYIuoK2CyKpCAi3AtAez+7MFVXsxi6cTjw5O7n8KgO5eBmATpouZc3SP61WY0Dz4xT0nuecxHcZ6BZ0jI3pnfP4Mt1UPz1efu/f2ca/SrWp9gZHTjZ+KnfO4Adypha9quYeP1nTnSTYWdHqr9buMGvCNxTZWfRPjXudIURETM5giApRzRCw97ieASyoWU9Eo/O/omqY0nEbUVNwfzgALCwKpv+Ri+wcak/6MhUvY4b1L0uqxxfQPVkd5ueggez+OvXAIzOBMyLu/ozHgFeaALfITTEUlbd4bnfSmlyjQeMsZpm+E4LAoUIvhoI9g+2zyXheRZ9bmoBk3hK2DivVo6ej2xpK+0q8YjjTvuawplj4WI2B4P78axqxyXNLdDIqQXSHFJ/z+vqhLr5GmR gdiA6vxc 2Mj8bq59R0400OE+QaVQ/Fy8CvJFlhlo1n81+mB5BqnEJpMaM/lHQnZdEUmQR6i0v8xdYqe2mr6aNIIG4MWtMKYVUbKy6W4MbYfZ056Chrz0Q6v5Od7TDY4zjmHBtcJTCf5y70YNdk89qvfiKgn4qr62BjTSDqsCQghTC8gL35kMEBIB0YGoyxPXpc5HBG7hW0vWL3hq15Ees3UBgHklpo7I1IURiIPdv/6FIdXR3lpNC6+IDm476beC6ANF5LBfsAi4z7ZDS6pc9TgjFP95FF4ThXFjpMdKwcQH8a/Z/ggNervwJ7heyLErkoZP4ckwmUldfkBJVaYsvrDmVsvCmSxjgcQtdnWQhBlT4VTTRE+DXIk+7RpRdkj60sis67LBH61G1lOwobzW2kBNebwloGTIOyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/25 19:32, Alexei Starovoitov wrote: >> ({ \ >> localtry_lock_t *lt; \ >> @@ -275,12 +293,10 @@ do { \ >> #define __localtry_unlock_irq(lock) __local_unlock(lock) >> #define __localtry_unlock_irqrestore(lock, flags) __local_unlock_irqrestore(lock, flags) >> >> -#define __localtry_trylock_irqsave(lock, flags) \ >> +#define __localtry_trylock(lock) \ >> ({ \ >> int __locked; \ >> \ >> - typecheck(unsigned long, flags); \ >> - flags = 0; \ >> if (in_nmi() | in_hardirq()) { \ >> __locked = 0; \ >> } else { \ >> @@ -292,4 +308,11 @@ do { \ >> __locked; \ >> }) >> >> +#define __localtry_trylock_irqsave(lock, flags) \ >> + ({ \ >> + typecheck(unsigned long, flags); \ >> + flags = 0; \ >> + __localtry_trylock(lock); \ >> + }) >> + > > All makes sense to me. > > Since respin is needed, I can fold the above fix/feature and > push it into a branch with stable sha-s that we both can > use as a base ? I doubt sheaves will be included in 6.15 so it's fine enough for me if you fold this and perhaps order the result as patch 1? > Or you can push just this one patch into a stable branch and I can pull it > and apply the rest on top. Ideally we'd have PeterZ blessing before we get to stable commit id's... Thanks.