From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF56D2E006 for ; Wed, 23 Oct 2024 01:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC5626B0083; Tue, 22 Oct 2024 21:27:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D75316B0088; Tue, 22 Oct 2024 21:27:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C16926B00AB; Tue, 22 Oct 2024 21:27:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A1AB06B0083 for ; Tue, 22 Oct 2024 21:27:59 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8472F80679 for ; Wed, 23 Oct 2024 01:27:44 +0000 (UTC) X-FDA: 82703130048.25.51BCC81 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf07.hostedemail.com (Postfix) with ESMTP id 8052240019 for ; Wed, 23 Oct 2024 01:27:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of zhengyejian@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=zhengyejian@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729646800; a=rsa-sha256; cv=none; b=bvnTnaaFEs54zUykZ9nEcgB9bNm5QjlY4g/c05B5xOkaCK6k2Gwgzose33NPEFImPMjSbz osLS3sMjGZe/esArzqKnJgJyzobrmMaAA42BgUDgfMfkaxVkbIWlIxbelcCs7oP7S+MsyW 1gnUJmdMVMg9kFWl0s2O8ncpRdG59aw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of zhengyejian@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=zhengyejian@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729646800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvwTY6LbErNUsgvTPsLI6qE7bfN25hTc8JZ/STLDhMw=; b=m7kylTc3UNz85Lc05hG0jwemizSQswtyPYm0gDP1mAY7WYS+72OhhNwJMu3z/FwcK8+hGs 0YhRENgVtxP3A34BHfXtypn0kYFGPtxS+47mSsFX42WMAVT8SZ5hTP8gOX225JdilhmHIq yIQ85/iMGZgtKv2olknid2ASFrOpNag= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4XYBHX56GPz4f3jk3 for ; Wed, 23 Oct 2024 09:27:36 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 0ACBF1A0568 for ; Wed, 23 Oct 2024 09:27:49 +0800 (CST) Received: from [10.67.111.172] (unknown [10.67.111.172]) by APP4 (Coremail) with SMTP id gCh0CgDHR8QTURhnBDttEw--.15426S3; Wed, 23 Oct 2024 09:27:48 +0800 (CST) Message-ID: <69dc6dac-b353-b280-4874-68466e817299@huaweicloud.com> Date: Wed, 23 Oct 2024 09:27:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 0/2] mm/damon/vaddr: Fix issue in damon_va_evenly_split_region() Content-Language: en-US To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, foersleo@amazon.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, shakeel.butt@linux.dev, sieberf@amazon.com, yeweihua4@huawei.com References: <20241022180537.42492-1-sj@kernel.org> From: Zheng Yejian In-Reply-To: <20241022180537.42492-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgDHR8QTURhnBDttEw--.15426S3 X-Coremail-Antispam: 1UD129KBjvJXoWrZr47WFy8GF43Xw48trW5Wrg_yoW8JF4Up3 Z3Wa15tFyvkry8u3Wxua1av3Wkt3y8J345GFyUtrnYkwnYga4ayF1Igw4jk34UCry3C3W2 va10qFZ3CFn5AaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkKb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AK xVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFyl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j 6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU17KsU UUUUU== X-CM-SenderInfo: x2kh0w51hmxt3q6k3tpzhluzxrxghudrp/ X-Stat-Signature: seigpt87fnp4i95d1fho9ob4he5tzo6k X-Rspamd-Queue-Id: 8052240019 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729646851-60643 X-HE-Meta: U2FsdGVkX1+ZQGooLlzmcDIV3498XWpb8h8CqR5S0nE+DlsdBwE9Hkq55qKHalrYXNZw6CGGzJg+G+p/AsEv4vrqw+JS+j3h5l1jEKZMDApJ9fEGi/5zjq6Diwvz5XNv96hws3oKQ4sUJwOhbFNf3k/SCHt/lzRGAjKpveHC2iCjCs/i2zCQqNsNn9kpcaWQL4ALkzJjEmm4vmht1SJd8hlsPhisw2re44/3Lxo+1FjyjZveEZclRIEzFsUztb+dtKWYg00lim4EAJbUn0OWwjfMwpkWI6y5D+ap1HfgsmRUcdgJUIvoGskJhhY4V2keJIEvqD0XA6IMtVNTpiSxNbB2mV8WLa8+YhMh5FbZU12bblE3bmF3u0gwunFivr2VRcs7XyPxo5aj0zjq69JUjihNEPDVrSs5OAkdoKLvp8pGAAKI86V1usXzcHhoCSeWhYFFIb45lrIzE5OLJnff5xw4eaa+WfwzlRBlh3dwrlejfzir89hTZPjpfZvn5RKctoyoi8elcviFTsNWBitUyqgGVeyfb6Y2zIM6FanCDEJuP9GPVmgmR1t7EWugUCk0EmZ9Bs6hatSHWdsDSWizM7U46rjABFlKXc3At+yCowhZ03H/QkVl8C9zFHo96+tpH9qFCUQyaQ0+TjNh40I5P9BHBNDbgGg5HZHL0Ee0J4HeV/Bmfy0TNBFkKxXyhnsdsiqCmFFL2386QXpLqbiysqHaDZg6aa7GBrzIHE3UZyr+XMluNrwRZxcJ/6eP5KmQjQHIuF6F+9XJBTEd7j4iGKIp5YYil0lkA1fhkhoICEDB35X4f8b3fU1khYSpLxkxBJSns5/IRI7yooOuNtOV2HMDanodoi3LfxdZTFblPvqRBlpvLpHpnlxZFUEti8Xi8HHQ+KbhWmtuV026SYJxFfHUZLDJNzXZzfGafXs8+3DgpBFyry1Nwx9hppSGls6JMf4at1Ua4iUGIPOtVJF N5aS1s/p ll37OeokUhARquRma1uzIfPqiTkOPQqrSUPy6NRb6tA3Dt/J/77JQf9FGVublKnGZYNwI7cD5WSV73uK0WN7G0yr/BCVeHokBnjv6BBIb4rM56PIG+7HDDT5/Fyd3mOKdyYLkpFYVC7kX4cjgGl4ZgGsEmZJQ4n2iElzNfg+aPE9yhuoiCryt1gm8X7GR5MVaIJCz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/23 02:05, SeongJae Park wrote: > Hi Zheng, > > On Tue, 22 Oct 2024 16:39:25 +0800 Zheng Yejian wrote: > > [...] >> To fix it, count for each piece split and make sure no more than >> 'nr_pieces'. In addition, add above case into damon_test_split_evenly(). >> >> And add 'nr_piece == 1' check in damon_va_evenly_split_region() >> for better code readability and add a corresponding kunit testcase. >> >> Zheng Yejian (2): >> mm/damon/vaddr: Fix issue in damon_va_evenly_split_region() >> mm/damon/vaddr: Check 'nr_piece == 1' case in >> damon_va_evenly_split_region() >> >> mm/damon/tests/vaddr-kunit.h | 2 ++ >> mm/damon/vaddr.c | 7 +++++-- >> 2 files changed, 7 insertions(+), 2 deletions(-) > > Thank you for addressing my comments and posting this new patch series. I > added my Reviewed-by: tags with some trivial comments to the patches. > Thanks for your review and comments ! > Btw, at least on DAMON mailing list, we usually post new revisions as new > threads, rather than as a reply to the previous revision. If you want to make > sure involved people aware of the new series, you can send the lore link for > the new series as a reply to the previous revision. > Got it :) > > Thanks, > SJ -- Thanks, Zheng Yejian