From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 828EBC02194 for ; Fri, 7 Feb 2025 14:33:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0DBA6B0085; Fri, 7 Feb 2025 09:33:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E93CB6B0088; Fri, 7 Feb 2025 09:33:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0D796B0089; Fri, 7 Feb 2025 09:33:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AEDD56B0085 for ; Fri, 7 Feb 2025 09:33:35 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 646F71C7EBE for ; Fri, 7 Feb 2025 14:33:34 +0000 (UTC) X-FDA: 83093391948.26.FED46C5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 3A34140004 for ; Fri, 7 Feb 2025 14:33:31 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738938812; a=rsa-sha256; cv=none; b=j53hZmSwIjPQUfDqiEF/eTOshDhjyVzM+4fsdSfIPcadZ5YN7u1T7bvuRTTE5+iCXYv8DJ pI+CuhovxQfP4IJpgOUnDNJjnyOu8ub9dOCJcirVn3C1yYHgffa3lxJt844w19Oo6N9SKO jrFRDNWWWJg16isHBJzDAYDLKKDArnw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738938812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=snMwSaLP8lnNXVIs56gsvdEex7XhNiEE64iH6ynGayQ=; b=syx1EyIJIrEzkvt4bnNy5y9TmZtyM9yYel9Zy86aCDzqBbbsLTpaDk7IQZXcrwVhHiesB5 TbuxLRScRB9RJAaD2srvrUHUi0+firja0DJFkUILX2Dz6d7ddqK9HwPKo/v9+0/vatB4WP ZFG21LXF9iC5LxRM+jPKAYQ5n7T+N/s= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBAEA113E; Fri, 7 Feb 2025 06:33:53 -0800 (PST) Received: from [10.57.80.179] (unknown [10.57.80.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AEA383F58B; Fri, 7 Feb 2025 06:33:26 -0800 (PST) Message-ID: <69b78d77-0dbd-4257-8076-260a3c64a81d@arm.com> Date: Fri, 7 Feb 2025 15:33:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 08/15] mm: Introduce kernel_pgtables_set_pkey() To: Linus Walleij Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Mark Brown , Catalin Marinas , Dave Hansen , Jann Horn , Jeff Xu , Joey Gouly , Kees Cook , Andy Lutomirski , Marc Zyngier , Peter Zijlstra , Pierre Langlois , Quentin Perret , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , Qi Zheng , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, x86@kernel.org References: <20250203101839.1223008-1-kevin.brodsky@arm.com> <20250203101839.1223008-9-kevin.brodsky@arm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3A34140004 X-Stat-Signature: s9zmfq11jb5kmj3tpizb5nkj6qp4uib4 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1738938811-835799 X-HE-Meta: U2FsdGVkX18i1lyszybJ+Jj+ywsOKpY5p+kkhALOclDA7BzI5uwXxvvY7+16KkeXxRxjXFTtg3kQHjkvmkLzW5Y8w7i4C4ePp0FQYzhLw44IDp7aeJOCpsf0Pb2VD3ZabGbOiMXarjCtpZCoaej40wMT7Ss+6wyG2YtOMLBzct4YMIdnmIpzcatXCsaz4W4Nx/q4DJmi9uUubJ5ytDclFb0dgmSXvJzn3U9BN2zrONmtWSeF+Up2wSEAHME0s9lNz1uUEotvT8oD8hUC1pe5gjqWKOOCM9vqorGLbTTjt51LAvz50ry94/TvKMtQ+MmREoMlSW+SrF1I3HVs+krK1Nlqz1d8O94qDH+9DQVDhVQSyWTfjBpvR56sgzxtQviw5QDxTjqikfhBZPD7xvKJOaHNW71k0wxoYbFfTWimKtb6Bbx8Pqg/Zw4fQpMtF8jaBzMcSQtNXJLj2S/SfLVanVnNJkZigDbzm2LVx5WtMVt9HjvhjTHvAbjUFN5g5LzQB8MXMvOeP2bZLSUCsd7c1izVYwTku4/kCY8pb1/Aai3BXytFLrIYdYmuOJLUNqkON2hIY7tKYaVNBgqReXWNFpJbd9T8rA0eAdaG+ts10t6HpM9Jnj5nRVmXut01kF5ZjfcKNA0zN+VenJkmLTgaq1efCJB06OHS5Bu4UHJ36QyUqpnMgGBirMlXtf0YOwQ/CA5ETHiBw06xAQ0o5HCog149xXbgQpM6fWU+GKwXnBQCDmHL2akIBml8g4r1o2LO+QzfgGFNqm4glbE0ON/khxT3ZthrAZ9D+Iui3tzMkCSrm7dRoevBiwwUYgX9jMdnaDMb+9hdtrarG+3MPZdEIBH08AfAVqB8m73HRWHIa2NESpt5rXLppolQvJI+dXLzyVpMvvDiNBUe9r3PxqD1e2pyghG/ZeYaFSDaoNFC9edR4PuSm+wXl55ssabLwE/M3C6MvsQvulNs/qQDdRz AiazaXv/ LGuS7QVzd+TO7IFrXMrn4N6sc/8J1lS5FCWHc49Af84MkM8Efso7e4bjW1OFHkXKmN7aqulD/uIGdSLMvpmsW/PkiyeTUUCb1M6/9/03m5KJgj5iD1spH6Bz4JeoGGdPWt+kme4JBF8BTETw8HYD10CnJEx/fyJwdcotjvUJypoUmBCy6zRR5NgUTj3JfPeoFq7iE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/02/2025 20:01, Linus Walleij wrote: >> +static int set_page_pkey(void *p, int pkey) >> +static int set_pkey_pte(pmd_t *pmd, int pkey) >> +static int set_pkey_pmd(pud_t *pud, int pkey) >> +static int set_pkey_pud(p4d_t *p4d, int pkey) >> +static int set_pkey_p4d(pgd_t *pgd, int pkey) >> +int kernel_pgtables_set_pkey(int pkey) > Aren't these all discardable after boot, so the whole set should > be tagged with __init? Good point, I was thinking of this function as a relatively generic one but in reality there's probably no use for it after boot. In any case it's only called from a function marked __init at the moment, so it's safe to mark all those as __init too. > Other than that it LGTM. Thank you for the review! - Kevin