From: Ryan Roberts <ryan.roberts@arm.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Zefan Li <lizefan.x@bytedance.com>, Marc Zyngier <maz@kernel.org>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Oliver Upton <oupton@google.com>,
kvm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Huang@google.com, Shaoqin <shaoqin.huang@intel.com>,
Linux-MM <linux-mm@kvack.org>, Cgroups <cgroups@vger.kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, nd@arm.com
Subject: Re: [PATCH v7 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses.
Date: Wed, 24 Aug 2022 18:40:13 +0100 [thread overview]
Message-ID: <69b50235-b77d-5310-2cc6-040f936b8864@arm.com> (raw)
In-Reply-To: <CAJD7tkbn7mFvf0oiUKPZtu92GtuMht-s5iPBRfEuUfTxXC_j8Q@mail.gmail.com>
On 24/08/2022 18:25, Yosry Ahmed wrote:
> On Wed, Aug 24, 2022 at 6:42 AM Ryan Roberts <ryan.roberts@arm.com> wrote:
>>
>>> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
>>> index e7aafc82be99..898c99eae8e4 100644
>>> --- a/Documentation/filesystems/proc.rst
>>> +++ b/Documentation/filesystems/proc.rst
>>> @@ -982,6 +982,7 @@ Example output. You may not have all of these fields.
>>> SUnreclaim: 142336 kB
>>> KernelStack: 11168 kB
>>> PageTables: 20540 kB
>>> + SecPageTables: 0 kB
>>> NFS_Unstable: 0 kB
>>> Bounce: 0 kB
>>> WritebackTmp: 0 kB
>>> @@ -1090,6 +1091,9 @@ KernelStack
>>> Memory consumed by the kernel stacks of all tasks
>>> PageTables
>>> Memory consumed by userspace page tables
>>> +SecPageTables
>>> + Memory consumed by secondary page tables, this currently
>>> + currently includes KVM mmu allocations on x86 and arm64.
>>
>> nit: I think you have a typo here: "currently currently".
>
> Sorry I missed this, thanks for catching it. The below diff fixes it
> (let me know if I need to send v8 for this, hopefully not).
>
> diff --git a/Documentation/filesystems/proc.rst
> b/Documentation/filesystems/proc.rst
> index 898c99eae8e4..0b3778ec12e1 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -1093,7 +1093,7 @@ PageTables
> Memory consumed by userspace page tables
> SecPageTables
> Memory consumed by secondary page tables, this currently
> - currently includes KVM mmu allocations on x86 and arm64.
> + includes KVM mmu allocations on x86 and arm64.
> NFS_Unstable
> Always zero. Previous counted pages which had been written to
> the server, but has not been committed to stable storage.
>
Looks good to me!
next prev parent reply other threads:[~2022-08-24 17:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 0:46 [PATCH v7 0/4] KVM: mm: count KVM mmu usage in memory stats Yosry Ahmed
2022-08-23 0:46 ` [PATCH v7 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses Yosry Ahmed
2022-08-24 13:41 ` Ryan Roberts
2022-08-24 17:25 ` Yosry Ahmed
2022-08-24 17:40 ` Ryan Roberts [this message]
2022-08-23 0:46 ` [PATCH v7 2/4] KVM: mmu: add a helper to account memory used by KVM MMU Yosry Ahmed
2022-08-23 0:46 ` [PATCH v7 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats Yosry Ahmed
2022-08-26 20:20 ` Sean Christopherson
2022-08-26 21:25 ` Yosry Ahmed
2022-08-30 21:52 ` Sean Christopherson
2022-08-30 23:48 ` Yosry Ahmed
2022-08-23 0:46 ` [PATCH v7 4/4] KVM: arm64/mmu: count KVM s2 " Yosry Ahmed
2022-08-24 13:43 ` Ryan Roberts
2022-08-24 14:24 ` Marc Zyngier
2022-08-24 17:03 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b50235-b77d-5310-2cc6-040f936b8864@arm.com \
--to=ryan.roberts@arm.com \
--cc=Huang@google.com \
--cc=akpm@linux-foundation.org \
--cc=alexandru.elisei@arm.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=maz@kernel.org \
--cc=mhocko@kernel.org \
--cc=nd@arm.com \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=seanjc@google.com \
--cc=shakeelb@google.com \
--cc=shaoqin.huang@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox