From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBF7C021A4 for ; Mon, 24 Feb 2025 14:38:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAEDA6B009B; Mon, 24 Feb 2025 09:38:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5E4B6B009C; Mon, 24 Feb 2025 09:38:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C00106B009D; Mon, 24 Feb 2025 09:38:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A10026B009B for ; Mon, 24 Feb 2025 09:38:07 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F0AA381797 for ; Mon, 24 Feb 2025 14:37:22 +0000 (UTC) X-FDA: 83155091124.05.F8360AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 7F37F40011 for ; Mon, 24 Feb 2025 14:37:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OStW1OMz; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740407840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8cBqLVMO9KyDdhAhicbfLxQ0QgptAxHHChSiZfSWUp8=; b=L0cX+XEmBvP/qNXzYWIw57+BY3YaFgyZo8GgNpTYWyQqdwStto9zYMp6Rh/g5uItEsfW6e f5hdFvOmAP8JewWtyA941pSEpSEaep6iqG8eu1fBDuvqznIQsVnPfVkqEjMGjdVVXLaZKs ehvoMdvBqXlOnH6r1NKHoOFNsVgb1K8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OStW1OMz; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740407840; a=rsa-sha256; cv=none; b=ytRzgs0hPNcW9WNj1lrdC1znZEuQ27NxUtLvQGEDTdKhQRosRLckkboy7q81IO3KFP3tur dFIiQsiVQTMjK8DgIfR2jvbtI7JOLKSBeIzhU0dk74fVbOZqS8uqo9mWcXeyQA8yqp78+e 1HpoKaBXgQ7Cqyf4/NadJoAfCa36yOY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740407839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8cBqLVMO9KyDdhAhicbfLxQ0QgptAxHHChSiZfSWUp8=; b=OStW1OMz+r+OrkXiLp7mXZneyJgAQMze10czdTbNIwvMtSJT+XvEDENzTMFzHO8oYNOn3L iokJ5O7E/JpAv1v8kD0NMkJEHj8dmEFftDguYl714GnKFcK/PxvllZ5t/W01V1N9RKvdmc ZU0iny9okgX2XuDWsHg/cXLorNDLj7E= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-xmIPwH86N1yJ1VwzwE2YHQ-1; Mon, 24 Feb 2025 09:37:18 -0500 X-MC-Unique: xmIPwH86N1yJ1VwzwE2YHQ-1 X-Mimecast-MFC-AGG-ID: xmIPwH86N1yJ1VwzwE2YHQ_1740407838 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43943bd1409so31707625e9.3 for ; Mon, 24 Feb 2025 06:37:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740407837; x=1741012637; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8cBqLVMO9KyDdhAhicbfLxQ0QgptAxHHChSiZfSWUp8=; b=VntF4iG3bpSvLKq1Qdvzsw4EyOPVaVWb2YPOGQf02Ug67w5iOD40UCmlMWOPo3FgRe 43DX+vSyOhPdWAUbW5+HxdshiXRy/JyKBNqBgjHOunV4V5CLzvTMkh3eecCGGDi7C57Y HDDFZO583IcIzUW4W1ZUB55YKpWwYyL8AMEZP2eETMfloJT22zyVFzB2e5Q6UsRZ3HKH 6lw2vIBZH0AXvBQBmkKwV4yJ7WbdGRGtn26n7dzX83knf7ybugzIitHNj1ZPq1QPjvyA UV4qPHIlrTypqlR8Nig2q0vq4SOTZJEw3i3XSLtl8BUQyxlQLCqXgYZfBIrjuEC2wkg1 XYMA== X-Forwarded-Encrypted: i=1; AJvYcCXVPJxx+2e/vXU6q2rX5OtB7SsDh+sezIyIf50IOdvbsIRRcIJTFE8GpOQSKqpUSQLmqhXgKuV2PA==@kvack.org X-Gm-Message-State: AOJu0YyhHQkPlvd9VyIrXyzhTqcln3il4h3erwprr1ExKJ4/y3enfI04 ULQSifjnpDD01Ti1q+lOxK8YIVkJpqq0LASoYm9qC1BPKcYQgJ56WDrzyIGUSnK9fWb49GVqkH0 w7yAtwEVtBAn5TcVzOWR+mmBbVOOBiqOok/lvoM8aoobOZuUB X-Gm-Gg: ASbGncsNmoWE9bpfqKzVKn/WL9ve2+AokrBeTJb+Zsk5DEVRSmt2fZEgzrqBTKK0DuP mzsg4aJy+bQ4c8DWVJDteWgXDOzG/sOzRcMIozj6TlnjQPwVT/hjrTHcpmbZMxmvs4HwomtJyOc 2y60wb+GMKHOeqqbMuGeFCD9IxBUO0N6RneSPC76Yi4FBt76Gwfo8A7gJu5JL2+wLx0QYgd+m4s vnS9dLU4jgBwp5F/E+7E2Pnk90TAaPyyFAxPqowBkisbKycVlsoOucSwaItlz35OY72B+u24WBS qoHFZpRWIQb057MrkBwg+5aMlFaA6CpRxxtPJ10ZbUY/a2L1P7VdU9ZACZVfuk3+LljzqYjGkzN vcJ6MFxlwHGqT1yc+bhXspQsSEh9yth807mol/h3NQRg= X-Received: by 2002:a05:600c:4f02:b0:439:689b:99eb with SMTP id 5b1f17b1804b1-439ae1e6668mr111032655e9.7.1740407837357; Mon, 24 Feb 2025 06:37:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsgWIR7iUmkg5e2QIW4/Xk5GM1LXoMIZsAwAYVXVELaDEwSw/hfMUlejuAwccBjLpngSd3iw== X-Received: by 2002:a05:600c:4f02:b0:439:689b:99eb with SMTP id 5b1f17b1804b1-439ae1e6668mr111032365e9.7.1740407837022; Mon, 24 Feb 2025 06:37:17 -0800 (PST) Received: from ?IPV6:2003:cb:c735:1900:ac8b:7ae5:991f:54fc? (p200300cbc7351900ac8b7ae5991f54fc.dip0.t-ipconnect.de. [2003:cb:c735:1900:ac8b:7ae5:991f:54fc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439b030c615sm108844235e9.32.2025.02.24.06.37.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 06:37:15 -0800 (PST) Message-ID: <697ca5a0-174f-441e-a27e-6a1652235a87@redhat.com> Date: Mon, 24 Feb 2025 15:37:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm, cma: use literal printf format string To: Arnd Bergmann , Andrew Morton , Nathan Chancellor Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , Frank van der Linden , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20250224141120.1240534-1-arnd@kernel.org> <20250224141120.1240534-2-arnd@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250224141120.1240534-2-arnd@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZvhU4ozajXpKeOMGd7FsKmmja0i2hasU1INksbyosW0_1740407838 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7F37F40011 X-Stat-Signature: 36559o3bkiahz316wubkfdhyqde74k7m X-HE-Tag: 1740407840-8307 X-HE-Meta: U2FsdGVkX18IoXUU9DLadpgugtllw7HJy/Tk7bAGE6k/JkfWfIbQtXBSphZNvrTZQOueRdrRi6R+QkUBjzLm2nYYrEp7D80yfecZypt+Jta1Htdi80HdZ//fXaxfunER7oW0Vlm+jtnGd0v6mbZf9d6WC8AxzhPWdhWKRqplmvRzLoQJDXRtzquiqCXQLW/1DdFu/G84VbEMm68cN90SqDXc39XAeDk6xz9d7uKVgPFohaaHWwhS3m3J4PytstW90MjzjgOUyT1f6DuYsHDqT+bElPwKdVeH05H4OjL9Ka1wz4yX81n8VlHrirf8BoS8sYVGfrgrtervASfv3quhW2zL3hT9x0QMZbgbm4vYBNfZYssuq4fIf+ntr4flK3Tcyh2UHQBxo67MQHvpM8MiTWmp8dOn0kSicVC+YyEQ6U2Glh73KiqeEm5u51SwMGCdBBLdFH6ewFVXIJr89jrcLSLOcnwfuCz0I6xIl4SmQS+G+T4XneToeoMeIF9Sy8Qt8uBGpVNxS44mvA2UUOYQeX+HrzdIA+zgoyCrar2gJNBSUfJ0OLYCDvzYX3n/yfmVNzFJNsury20F6hg6lltswID63Bobub27/18rSIRND9cdQEB1zlWvjXBfi+BKrszNvkC2DJVWpJ9JWdNobI6AMsK8eUtxq0cHDW6jASR8OChkeI8qOphQMeWnZ1Y1tXS4wHlZ/A6DD235mZJ2fh4CpYDqSpOD6oHowtmqUjMqFWhQqc2qnUfv1ne2POjBZH4bPRMyckkJWUSh5zG3Cw9p8i/Wu/2b48gl4/w6LsctPd+A/vtZ1xd7h2bKNo+8vbvSzJLul20JuFCHMfmLAE6nVZ2GILM+TKKUlcLsXFdJ2LVQgAek7B02zkOlpr6sOS8QqlWQ/JRGqx+1STm1yzZ+jMg+OFj//lZSJOVGbtVOaVu/h0KgQN5ewX9hL+7/L9Ixt5eQmb1YFAFLuRZh9jX CX6RIKGC QzDT8Z0S7mAwFY5ooshCA/IhYtS0hMCuc1NPIOj/3d3lYc4lwC/Vij+BpUabhi5jdF64NEDMwFn3AUZzGm5ndYoxScRDYVLC6W/idJkvzbR+6QgE+G8YZ86ZdRrNnvFS84kHID92rTKr6QBalQlFqG8E9nGEb1fbJqumE1mGnJk0qKN8X63Vmkrd05DIvOusHIqUejFgEcD3QuoTApCEOKxMyS1NIGrVrBWP4TJlfm5qlgC4ujpTJF/sg/FzeUwFNKQS1z9l/hDAjZrB5E59pWbBidgW5VHtb9nHiT/5RWjPdI/CyZ6kpK42898hp4r2EaZzmClVyQJVRWZEgaY3VKkf2qwDAMiOJqQNGk+Y27W0XwQLaZe3JiMStBL8qhGCk3BpHS7c0FnVeOgcvLhTopIvxkT6xUOVtoWhQMTn1jar5+EGM29hHkU0M0HHTlPw70T7bs3TMR7WCrV4Pz4szcp1BY+xA3FIPFnX3FCSiDVS2GTGCPKUvYiqmJzviPxPYmt11TJhvd8Wk8SZTGgDvSO/SdfbeilmEqMDyo0MzXrAhK9oKzrVkYjQDcYpqz3pKLdv21zSno3yOTp+6WyI9r5ZPWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.02.25 15:07, Arnd Bergmann wrote: > From: Arnd Bergmann > > Using a variable string as a printf format can be a security issue > that clang warns about when extra warnings are enabled: > > mm/cma.c:239:37: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > 239 | snprintf(cma->name, CMA_MAX_NAME, name); > | ^~~~ > > This one does not appear to be a security issue since the string is > not user controlled, but it's better to avoid the warning. > Use "%s" as the format instead and just pass the name as the argument. > > Signed-off-by: Arnd Bergmann > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index ef0206c0f16d..09322b8284bd 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -236,7 +236,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size, > cma_area_count++; > > if (name) > - snprintf(cma->name, CMA_MAX_NAME, name); > + snprintf(cma->name, CMA_MAX_NAME, "%s", name); > else > snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > Acked-by: David Hildenbrand -- Cheers, David / dhildenb