From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3322C48BF6 for ; Mon, 26 Feb 2024 04:54:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D3406B015C; Sun, 25 Feb 2024 23:54:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65BF16B015D; Sun, 25 Feb 2024 23:54:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FC386B015E; Sun, 25 Feb 2024 23:54:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3CCAD6B015C for ; Sun, 25 Feb 2024 23:54:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D5E83160649 for ; Mon, 26 Feb 2024 04:54:26 +0000 (UTC) X-FDA: 81832738932.29.24188EC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id B159D10000D for ; Mon, 26 Feb 2024 04:54:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AKzOxPFn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of xiubli@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708923264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LrACz5Anp3j5np9PgzWbTRqtplHvhtHaAYkW+Lelxj8=; b=IMZ5M0RRjiLFFBogu/eAIljR3MvOkmEic4R0x+ghPRP7uyHgHQLVfLK16CJrjl55I4tSHJ +/9Dnc2JoGx9dfGNn2+xVH/H3L+75QYvia+rhFpKDzg8wbpe/kzt4baZiH0TaxpbAAmEk4 Ygs6RcU+Hzr6wpzcueHAN2iC58fD3qM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AKzOxPFn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of xiubli@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708923264; a=rsa-sha256; cv=none; b=mKnS1DUQX07WXTBZ9aDk4ys1wBdXyM+QCDbSTRRipeS/HkASzdDmTOQwqv9inZg7Z5OAAO 9cceVJxSGm5PA9+jRVCJbuBsfyPNsNv/qAcPRlTXAOjKdOwA8Vsv8YwGJ3839KGRKkYAqx 13GHWyJPMIT/fUS456opjviRtJ26M2s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708923263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LrACz5Anp3j5np9PgzWbTRqtplHvhtHaAYkW+Lelxj8=; b=AKzOxPFnRZH9L+HqXSvWMTv3MDsndaXicm/kzATfZhwwXlvJROdfsmpor6TPOwJrqkDwaO wFA7nSQVlnBQgRvWm5Tbu8l9Ojr1d2eZYqJfWVGExqZto9wpf5d0v7kTU9KYDvmV9yeAxO /yFuQ7iLYibLA1AWzES0X/vE27z4j6k= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-xNvwT5YOM3yFHpSQSxEOwA-1; Sun, 25 Feb 2024 23:54:17 -0500 X-MC-Unique: xNvwT5YOM3yFHpSQSxEOwA-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1dc8ea2b12aso6169815ad.1 for ; Sun, 25 Feb 2024 20:54:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708923256; x=1709528056; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LrACz5Anp3j5np9PgzWbTRqtplHvhtHaAYkW+Lelxj8=; b=aMmxReYlh2LlTeumv1VokJnAxzEvIcRIN6KkaXblJtlRE7YP2sH8mqD4a+wHOZCeuQ 8GQFsfn3LtT3qJ8NwRCbxZE6YaCGTFzOubgFDk99DhGj8fzMs2WgmMWMACDI9njV/42W ttge6Y0QJ2S6mQS6pOc/VNtkHZr/ZZr8kFzqL7gf8cyLFsnpmX454hb7ZpRuhVLa2fYO CxAH1VC0iSiVsjSbp/61ePzO5TNtL8b/T7WnUtRvT3kO5NIisxC/JklA85zFgu5JDmYM M7ZqfeFR3PjKOG/7Rm8VKKaZ809Ma/PHLpUMUaWYkNZrzvW9hdj7IUnjhf7nj+7JT+C4 EGjA== X-Forwarded-Encrypted: i=1; AJvYcCUcg6NBQrm8wNCBKtIPzStX10NFcuL0t3Y0zkgP59itmj/0K13iGYFrBTclGd7gbA3TAiSuSXi+Ek+WZLbsJrGgnqg= X-Gm-Message-State: AOJu0YypurCNB+HZ2GHLpOaRxhLh1xcLQcVDeCbY0CatX7VuWDkHiUFj RvEcYL4NR+KbTVnU+O4TzBddm/PPL02GUiuF4ZlW2rZCQGDH1fMg4WpW82m73fvApXF8PhEfy/3 m8PE7GJ0XPwYVylCbrkqh4xcbnhBoGZvW5iuL1EPFO6dulY5l X-Received: by 2002:a17:902:e94f:b0:1db:fad5:26ad with SMTP id b15-20020a170902e94f00b001dbfad526admr106869pll.51.1708923256455; Sun, 25 Feb 2024 20:54:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyKSYx40AByF4zUBPndjhdof7ntq9QRkH11f6LHVqj7dhRZ4H2OOxvIvoeVBF5e07hTyRZTQ== X-Received: by 2002:a17:902:e94f:b0:1db:fad5:26ad with SMTP id b15-20020a170902e94f00b001dbfad526admr106860pll.51.1708923256169; Sun, 25 Feb 2024 20:54:16 -0800 (PST) Received: from [10.72.112.214] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id ks16-20020a170903085000b001dc6528d49asm2993994plb.250.2024.02.25.20.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Feb 2024 20:54:15 -0800 (PST) Message-ID: <69589d2f-978d-4d14-9e5f-6bd6b3a43062@redhat.com> Date: Mon, 26 Feb 2024 12:54:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ceph: remove SLAB_MEM_SPREAD flag usage To: Chengming Zhou , idryomov@gmail.com, jlayton@kernel.org Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou References: <20240224134715.829225-1-chengming.zhou@linux.dev> <35df81f5-feac-4373-87a3-d3a27ba9c9d4@redhat.com> <82c2553f-822e-40c2-9bf8-433689b3669d@linux.dev> From: Xiubo Li In-Reply-To: <82c2553f-822e-40c2-9bf8-433689b3669d@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B159D10000D X-Stat-Signature: jrycir9mfgsa5u444cnwxa3aer9q6j9q X-HE-Tag: 1708923264-31477 X-HE-Meta: U2FsdGVkX1+Zzvs5Ir7K07MuzlgsLO7lz9NlC3BZlg5jFHeR042BJsYqRLmVOsIBw9IDFHwjIa1sj5xUb/QT+0gKlb2PQsbH39yOmsjD8IBj0gBG9AWO05VXwskypOifDMDLH+YurVU6gKqmFNGJdKI9PqPP8IHmpxtgnaCQSBunwuLy8C7JniA8ma+/5yOnbembKUvNm5M/D2d8m69cUq25fSGWPtSqsBsxQwvhls69a2pOwiAWGtoFZUPu9IHMpyp/Gek/1NIDiVCxne/1sdaAhl0l2fZsDNxt7ZdgWPqHQmxwFvd0ifei9RyhnnuSQUuwfUMqat4c604eLOTxsruLzdtYLH8Eqhm6Qv0kmQdR1Io5AnkQPhDi2qNpWwwEjDbgJkkyFGZJGrl1iLiYZuofV0huAgHaOqojfLOtbTbNSnUGnn+/MKQzti+V06cAZ78EFmgbGa/skuYBcSdBzkZlPVfPNwmQVhY0V0e1rCRXzyPnbUxHiPe4aRoO+PUmzwv1Ys0htHeyQ2P53DUkoCd0Lmfg1mxFkpGcvmPf8gvCIFBX5152F9hDXj9LdgPFZqe/0R+fK/XRUsKew4kXwl3/OerS2z5u/kIFGgB39qARFmnkAGgjljeqfdh+gU4R6YThojUE2iQoG//Mom1LZ25QXUgjDfIUuohOcyz53xS111MdXvggKm1zLCTdonO6G984SA1SYOUiYZaWHpbz80WmwzMGtucbSiRHqIC/sJKv46nJvXIu+FLq3CclJKBs9sboMYegLiMv4zZOkFpvjq2O466U33PoNbBagU5zC8FL6Enple1R6S93J0JqvbsQdTGRnpoFoXTmAPdm3nTs8Gt9MQOBc70rtH1kSUNKJcb5Hupb25boDMIX+MUX0IG73Weu7cWRjQBLNizp8ghw2uaz4ERl7XyrDWOfZSJ/bFKwuwQJNKU2bErNZ9mT0XdBL0S9g2yFKnyoyyCYR7y uw+UNtZk tXkGWlx53D5WJblw5oqiYaS3OSnZQj8dZ/ACXzgvRC3zLJEqwoWTstKetp3NhXrgsIlZuGBsYp+BjkXcPQm4c7pTNC1G9YQaLZVxu52D6LgxA8V7rFaSWFfeMqhYBJVSxB4LFGTvGebUHzyZj7R+24FIlA6k1zGnzfNxQ4TQz7oo5v+mi3Q1ss6Mnmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/26/24 12:30, Chengming Zhou wrote: > On 2024/2/26 12:23, Xiubo Li wrote: >> On 2/26/24 10:42, Chengming Zhou wrote: >>> On 2024/2/26 09:43, Xiubo Li wrote: >>>> Hi Chengming, >>>> >>>> Thanks for your patch. >>>> >>>> BTW, could you share the link of the relevant patches to mark this a no-op ? >>> Update changelog to make it clearer: >>> >>> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was >>> removed as of v6.8-rc1, so it became a dead flag. And the series[1] >>> went on to mark it obsolete to avoid confusion for users. Here we >>> can just remove all its users, which has no functional change. >>> >>> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ >> Thanks for your quick feedback. >> >> BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master. >> >> Did I miss something ? Or has this patch been merged ? > You're right, this patch hasn't been merged. But it's already a dead flag as of v6.8-rc1. > > Update changelog to make it clearer: > > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed as of v6.8-rc1, so it became a dead flag since the commit > 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the > series[1] went on to mark it obsolete to avoid confusion for users. > Here we can just remove all its users, which has no functional change. > > [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ > > Does this look clearer to you? I can improve it if there is still confusion. Yeah, much clearer, thanks! Maybe we should just wait for the [1] to get merged first ? Ilya, what do you think ? Thanks - Xiubo > Thanks! > >> - Xiubo >> >>> Thanks! >>> >>>> Thanks >>>> >>>> - Xiubo >>>> >>>> On 2/24/24 21:47, chengming.zhou@linux.dev wrote: >>>>> From: Chengming Zhou >>>>> >>>>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >>>>> its usage so we can delete it from slab. No functional change. >>>>> >>>>> Signed-off-by: Chengming Zhou >>>>> --- >>>>>    fs/ceph/super.c | 18 +++++++++--------- >>>>>    1 file changed, 9 insertions(+), 9 deletions(-) >>>>> >>>>> diff --git a/fs/ceph/super.c b/fs/ceph/super.c >>>>> index 5ec102f6b1ac..4dcbbaa297f6 100644 >>>>> --- a/fs/ceph/super.c >>>>> +++ b/fs/ceph/super.c >>>>> @@ -928,36 +928,36 @@ static int __init init_caches(void) >>>>>        ceph_inode_cachep = kmem_cache_create("ceph_inode_info", >>>>>                          sizeof(struct ceph_inode_info), >>>>>                          __alignof__(struct ceph_inode_info), >>>>> -                      SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| >>>>> -                      SLAB_ACCOUNT, ceph_inode_init_once); >>>>> +                      SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, >>>>> +                      ceph_inode_init_once); >>>>>        if (!ceph_inode_cachep) >>>>>            return -ENOMEM; >>>>>    -    ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); >>>>> +    ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); >>>>>        if (!ceph_cap_cachep) >>>>>            goto bad_cap; >>>>> -    ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); >>>>> +    ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); >>>>>        if (!ceph_cap_snap_cachep) >>>>>            goto bad_cap_snap; >>>>>        ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, >>>>> -                       SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); >>>>> +                       SLAB_RECLAIM_ACCOUNT); >>>>>        if (!ceph_cap_flush_cachep) >>>>>            goto bad_cap_flush; >>>>>          ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, >>>>> -                    SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); >>>>> +                    SLAB_RECLAIM_ACCOUNT); >>>>>        if (!ceph_dentry_cachep) >>>>>            goto bad_dentry; >>>>>    -    ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); >>>>> +    ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); >>>>>        if (!ceph_file_cachep) >>>>>            goto bad_file; >>>>>    -    ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); >>>>> +    ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); >>>>>        if (!ceph_dir_file_cachep) >>>>>            goto bad_dir_file; >>>>>    -    ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); >>>>> +    ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); >>>>>        if (!ceph_mds_request_cachep) >>>>>            goto bad_mds_req; >>>>>