From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2794AE77184 for ; Thu, 19 Dec 2024 11:15:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FB616B0085; Thu, 19 Dec 2024 06:15:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DB126B0088; Thu, 19 Dec 2024 06:15:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A766B0089; Thu, 19 Dec 2024 06:15:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4CCE16B0085 for ; Thu, 19 Dec 2024 06:15:30 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CA5E9C1546 for ; Thu, 19 Dec 2024 11:15:29 +0000 (UTC) X-FDA: 82911451266.19.85153E6 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf24.hostedemail.com (Postfix) with ESMTP id 55903180013 for ; Thu, 19 Dec 2024 11:15:21 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734606897; a=rsa-sha256; cv=none; b=E/Ko3LatDaioegXU0gMcSd21M6+Zwo2q3wmGW2HiF+jFh3P7BNchF3VgchD5loNWgZSZeT f3z1Z2LLRnASBS9qId01nfoit1KilBF6/Iqt0wXV9dDBU0ASUegIQ/pj0C2/BqpPfSJkkm JgAPfZvYnFx4apvfQHBQ1XPCOWY0WDs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734606897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AT7hnQ4t+kn/QvYdhv+E4I5B5X3+GsLzJNwkMlT+fUk=; b=SvSWp8++i1qkk+blvKEe2cMSQJx2vz3G6kKr9oxwnZRk7YvJ/KTJ4Mm/MRfSvKp/rxt21A iPh0cA6sbnD3zRD73ImOwl2QZEA7Yz/QacEMt1cp0GHmcAhT3gN96vVdid8/F5aXxActZm OIy/HvHjL1IlgBLuFfvQEHMEFuHGQj4= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YDSbC6M4Kz21kWm; Thu, 19 Dec 2024 19:13:27 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id 601141A0171; Thu, 19 Dec 2024 19:15:21 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 19 Dec 2024 19:15:17 +0800 Subject: Re: [PATCH v3 -next 00/15] sysctl: move sysctls from vm_table into its own files To: Joel Granados References: <20241010152215.3025842-1-yukaixiong@huawei.com> <79b33640-fc81-b4c1-4967-30189d9a4b23@huawei.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: <69509584-92c2-6bcd-0aef-406af7606239@huawei.com> Date: Thu, 19 Dec 2024 19:15:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml100006.china.huawei.com (7.185.36.169) To kwepemh100016.china.huawei.com (7.202.181.102) X-Stat-Signature: 1okir47h91n8x65174rf1qa9d43acd15 X-Rspam-User: X-Rspamd-Queue-Id: 55903180013 X-Rspamd-Server: rspam08 X-HE-Tag: 1734606921-50419 X-HE-Meta: U2FsdGVkX1/NjGhdGMDyi8+BFOpb897SH+rlrapXndB2JPRB2YK9kdXiXDzibIEd+z0F4bqKVM0JuaJODjsH4FCeNF5TBSKBXttC+z7ytQctAJImxqlvsEYApOJToTofcsYll1Vld43nll6knDsDBbKJR1pVOdBwjeMzhlKnm4bMmZUZb4+aRFub/q1zZooJQOE2BB9Y4vk8iv7gXQ8RuDxzKXK4JQCfRhkTtc3R0pyxC4YBBVXpc2GvVlrfjJ3ExpA3G8V/Skb2bgF/Uq0VkdemrDv31/m6WcmdtO1RyMSH7fV6Wfo/fZhxNLeP9xUt3xRVDEdD70h8niXle4CzloL0BA2kAFG70QIjaDqQneY89MRny/p58NnPkl/HYqxunu//e9jwgcwavXKMcvRLSBbrywpritJ+PGOtS45tZRmN9Urd/cNg4bOv3wqhtLkdVrokrfuxSws0Qjm7lQb6g0nPhDHEDYTpw86WL0/HV+JyhcRhdF5/Mh2dMSFeEzLLZqZx+7ufnGs0O0Y5o778EAzruXvNzxiWM+pX+renewPBTLdQREL6XJFH4zifQc6hrH1nnrRHqXRjEybT+Rjc5ipIVLZRvjgupqLTKWEpAAs6NfXladh+/LT1gZocKeGkaSlsIX+jAN4wT8XhYNkQAkfzvANn9sS1cJV0HmaJKPEd5kcR0zj/f1AYBIZ302xbp0EACXX8AXkOWQ8xxo4kkvXzHXrnfn6ObB1gQ2PErIvSSjC0v+ydlP3gb7xGQLxOESnU7oz7RE/hSUsyLWBWYN6io9rcqXnhiwjGQcnuL/2fcbkd1TcbZl2FbOXJ42rGHlu2hVL+PX/Z9t440wZdthdE5PGyOtNiCSalqMFl1lBhlxcl4PRyIg6HmeIqdMAEnmu4jkubLOCQ3O9EcOIAWq9vgzf5UyfwtBE1KECDMZj6lui3JA2XEZaDgNA9VUWZVq6+ugrMxTufAGjt53M 4e1DMI7e igjbQYpKpOhseq5v80KqUBz2/3+KKtCMpDI9Yb7d4OdswNGpF6QjbAmjBCugW8VrLKswphfHuO00bbQKWLu4sBg9y4imrmPeQ0VlhiS/WNm7k+hIh9Lti/sf4adp/PXNPspiSLO7k1FYHGEyQcSRSicHxYmjOev5ZJ7gp4Xz6tZKb32+puBEynfExXAcFH4E7XbTbQrdJjjES+6U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/24 16:59, Joel Granados wrote: > On Thu, Oct 24, 2024 at 04:07:10PM +0800, yukaixiong wrote: > ... >> >>>> mm/swap.c | 16 ++- >>>> mm/swap.h | 1 + >>>> mm/util.c | 67 +++++++-- >>>> mm/vmscan.c | 23 +++ >>>> mm/vmstat.c | 44 +++++- >>>> net/sunrpc/auth.c | 2 +- >>>> security/min_addr.c | 11 ++ >>>> 23 files changed, 330 insertions(+), 312 deletions(-) >>>> >>>> -- >>>> 2.34.1 >>>> >>> General comment for the patchset in general. I would consider making the >>> new sysctl tables const. There is an effort for doing this and it has >>> already lanted in linux-next. So if you base your patch from a recent >>> next release, then it should just work. If you *do* decide to add a >>> const qualifier, then note that you will create a dependency with the >>> sysctl patchset currently in next and that will have to go in before. >>> >>> Best >>> >> Sorry, I don't understand what is the meaning of "create a dependency >> with the sysctl patchset". > The patches in the sysctl subsys that allow you to qualify the ctl_table > as const are not in mainline yet. They are in linux-next. This means > that if these patches go into the next kernel release before the > sysctl-next branch, it will have compilation errors. Therefore the > sysctl-next branch needs to be pulled in to the new kernel release > before this patchest. This also means that for this to build properly it > has to be based on a linux-next release. > >> Do you just want me to change all "static struct ctl_table" type table >> into "static const struct ctl_table" type in my patchset? > You should const qualify them if the maintainer that is pulling in these > patches is ok with it. You should *not* const qualify them if the > maintainer prefers otherwise. > > Please get back to me if I did not address your questions. > > Best Thank you! Now， I decide to const qualify them. Maybe, it will be better.