From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD2AC021B1 for ; Thu, 20 Feb 2025 15:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB2BD4401F6; Thu, 20 Feb 2025 10:58:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E62724401F0; Thu, 20 Feb 2025 10:58:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8E1E4401F6; Thu, 20 Feb 2025 10:58:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A86D64401F0 for ; Thu, 20 Feb 2025 10:58:29 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F270161AC2 for ; Thu, 20 Feb 2025 15:58:29 +0000 (UTC) X-FDA: 83140780338.07.700640D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id DBED2180020 for ; Thu, 20 Feb 2025 15:58:26 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J+gSPNUr; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740067107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RHvc5S6H1uLcgkSFHsa3fLswmnJodsiLrQqMBCtbC38=; b=SEbjqDocMjkETrlhzQBO+ghC85145LKN5JdQmKGJTktEL0EtoGJmweP0uhdj44MtV3YipB 0OEF7JVwK0f2x6UCW2ps4glPKkVV0J6BO+wDbcEywPKThsE8Fpit12IAlLTtD3cFYrvjUC KHfr32zV0FviZ1iISdZal5fV5ruO+nA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J+gSPNUr; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740067107; a=rsa-sha256; cv=none; b=W8WUsqkfn/XdpjDcEIJmiR3lcQwCAwcMsdjIX8XzAoZAYg46mxIfmsqxmeiiaZaBFCm8ud c41zJHOSUZFz2+guBNhk6Lugk+hkywgioyhqwSP3gwirAWo9q4InthNBz0bpLcgVuIXlk3 5+suUEEy2p7e5oQnCUCb0YvfYLjFz70= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740067106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RHvc5S6H1uLcgkSFHsa3fLswmnJodsiLrQqMBCtbC38=; b=J+gSPNUr6HZ2Qwa82zXepHYLz2N88vUCJbFnvvMP5XlMxaqtlixcdryI/Jp/uBNIzJ2jOm GsZiRpsIjcjZR2rCbIXKkG7ou+aoSeS5X4UO1R9Hv4Rw1P1+QWc35MWXofo56fidW4FKPS 6i2rLqGW6RLPw7mIsxOe4DvCCoIBCPg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-216-fGPM258fO3Oa8yYQegDRiQ-1; Thu, 20 Feb 2025 10:58:25 -0500 X-MC-Unique: fGPM258fO3Oa8yYQegDRiQ-1 X-Mimecast-MFC-AGG-ID: fGPM258fO3Oa8yYQegDRiQ_1740067104 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38f4cce15c8so575196f8f.2 for ; Thu, 20 Feb 2025 07:58:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740067104; x=1740671904; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RHvc5S6H1uLcgkSFHsa3fLswmnJodsiLrQqMBCtbC38=; b=OzDqWi8ViXuQPeSgcy+fwtQPWFbKnen5wqqpcnljLs8a4kIUg4qYp9L50k7FhCS3F9 f+AlKL/IZcnGc500IloqXDIeyHNLA4pGx8b8iCEr10X3p5HXkga5z3KkfDaN4fwlTvpx ThiDJz0vykV+8n1xMgIsA7lfgfP61pgHorVnme65r5YSilrJJKgM+Upjtt1b/kRJzmyP BZ6IBok27dxTlCyO/bf39X/3r5kmD4Hd/4m0R23dSbijaCZxYBsYs1FekWa4PQlMDXei 6jnJOMVyVAUn10CM4QwJwwTbc/+u4o7CjZykSmCcIvLy0MhBIHfKTpoeCyRCqythRdD3 Pm4Q== X-Forwarded-Encrypted: i=1; AJvYcCUWTfRYpymI9IzjEYbUaD2KwCC0PFejj1pVX98Edz4bPF/vbM1v26L+h38NX5u9wHfRUPrlGcxsFQ==@kvack.org X-Gm-Message-State: AOJu0Yx5EBnKFR0UtErNWI5XbkC3FALVpBO/3yatOd71svcx9m2yMRLd 8lc+C3JbjkSWU/GwOussg6ZKYWwTXRyN688QRSN9Usne5h62w8Q+fUq1BrPQVnrP+UkZvG6X639 Vk1+cXn06GLkveoHpgpWfj47fnGfsv7yBDnYtMT7x/p1OR7F/ X-Gm-Gg: ASbGnct0tKdnEwZ49FWpQ+1502uVqxVGhIDj5jDzc5pQepc1GxG0RDv6YZqbYkVwQle qirG03B4LzCjJ3/K7a9zOesfrapshY0r6LmY379AaNJ1Mk+1dAwJoYtErh00kM1/maxFJoRCiMZ kU9a9ZzbDZHNwkR4JVsUWew/DVM4Za/m0xFqUZsYsy01ezmM6Blpwr+ylr/frYL8RQ9gKabmSzp D4pwF2zLfbeAJUsx49rTcvy1OkMv2SZZ9GWKef3LIydD7bRF4xWeDduaQElCg2c8cC9cqY8M1S+ X6UHTJPiZ0n572TeTzzuVLZ35VbGr/vPJmzfvc9sA9z/NkOQnP5M98PxVVfBDTvJXcGbPKXqwiC nsOtUcdBW0wqI7u31DZKRQd1R0QTDXA== X-Received: by 2002:a5d:4b85:0:b0:38d:b610:190b with SMTP id ffacd0b85a97d-38f34171092mr16542429f8f.46.1740067103707; Thu, 20 Feb 2025 07:58:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfJGqycV76uVRKSjkWnj9Y4WfxFgKNNfpkf+6XMdiVNlsvOAZWzbgO9Z0+I9UfKqAarTz9Sg== X-Received: by 2002:a5d:4b85:0:b0:38d:b610:190b with SMTP id ffacd0b85a97d-38f34171092mr16542354f8f.46.1740067103233; Thu, 20 Feb 2025 07:58:23 -0800 (PST) Received: from ?IPV6:2003:cb:c706:2000:e44c:bc46:d8d3:be5? (p200300cbc7062000e44cbc46d8d30be5.dip0.t-ipconnect.de. [2003:cb:c706:2000:e44c:bc46:d8d3:be5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b4123sm21580707f8f.17.2025.02.20.07.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 07:58:22 -0800 (PST) Message-ID: <69467908-17a5-4700-b5da-efc0446b8663@redhat.com> Date: Thu, 20 Feb 2025 16:58:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/10] KVM: guest_memfd: Allow host to map guest_memfd() pages To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250218172500.807733-1-tabba@google.com> <20250218172500.807733-4-tabba@google.com> <2cdc5414-a280-4c47-86d5-4261a12deab6@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: R46zdJwnDXNzCndOUqxSMyJusxVvKTV5qoig66agLJk_1740067104 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: DBED2180020 X-Stat-Signature: osr8y6zmk9xpwz9hpcyj9pjesstjztn9 X-Rspamd-Server: rspam03 X-HE-Tag: 1740067106-214740 X-HE-Meta: U2FsdGVkX19wVvT6uJNThGfamxD5Cys3dxO4kBKnezX4fPAne65hNGMHtPJi0v74CGRPZdujcvBazXbtNwFHszyw4lkeHmg/ZnhOA8y0L8kvRe6nabujyWAtKHSVYuvQwJh1+gYiRNRBZc2TFvw35BQFXkwhccfXQPTc1MRxSXqWX08nGguY3OrvA0PO2EI6sUtD4Gkj8qX2EhAWoujBADbuA5tVC0uZk4lbM4lqELjG4J98f1BsxmiJl9RUV4UO5oseaRBXdCZ873THjbUumi0ycONObXp3uQaF8CYFySChG/LI8S1kWqln5UbIb73JWX85USLzLBAv0ik3mZXiik7DGOjnR+kpX0zheapvUTVZ+CY9QGBQabVpKPoF3FIEAOCpTdek7Iu+UqVMzhmfL1vu4o0t/p3dzz/0jYdENq45mBIuOncVSr5VVdazsloRlViYtpFg1YQcgzZ7lzodFjIJ18TrbERQgoXT1G88V9hCe4UK9S8kWTOuT3fjtzKmZc4ZT2uQrYO8iVYlQY1mIyS4LOjmgukMlAgxxE4SaV9r/dJf8el74f73GvFCCBiy16qQ6JQ+35GfYN04iNOldZSlNZE4Xjb2R12I0orSJMrotoNdagL3/AArAJCclqddyVL3NJ+druYjak4LT0qjRXkz9Iaoh7VzfYRbxIw6/DrvdRXT4mLA8FHiMy7Re5FbablPDlqfQcaDCza5IfSvtkUVNFpSa5+UL55cWAzDxc/PxDUbTJ8wQ72HNVQdzFaQwH8dl46mwfAmzfJSiJJZ3LZbsXrrjpSvQtUIGRL1Dtl+HfhCKywFPCkcK59Gwdk3LC4sA/+Ee8A3C/Uq6pZZsGNr7dWEKRMEOchelKM1haQbaQ5xChSFGTEDq4y8SdWtL+4gYgN5GdY72ijDOqa+1SVv1JQ3rx7+6MxhAwOceU/syXAdv8kpEW5iAJs00Vp4Ep2jdnJZMUCLtoqbWal Xmy41p2C Qm86TO7GTISWHUPj5INV0RJ5TsghmKCk7K9rX7otV4aOcTc3uUyGp8RWHhXbYHiAC8QzDmdWACppz9H03V+hvU8wRmZhcjvKhSDRcRsDt6/PACd8cUEsyd3PMRhVSGjVJPQ9J/ErVlLEcthfvi3d5c3FncB6gvX0AMdMInUb44cp/zC1E4qGOOQFygZAztmoG5lCuZmByjgzeb7D4KaZV5p22q0nG9so9f1mKbgVDb+O9QMQdIl7HSiaGihpB1b4Cw7YKY1ifemVOLdwikH7g0JtoxYJ3Dg2TecSLYyGr3hIK0zMkyKhiJ8wtwlwkWdqKHH0visQwBUqXtrpsOW0JkG5Nusq6pS9HTiSjkNrGa1oDdw1LyO1xUOQqXmeNRDrmsHF4aFePAljRuBX8Y+0ToiAqelXz/7T1Ntrky/5FDybC0BVw2heddd4JU1xvJUcgkjKkibx8y+nuWEafZtf9lWK7jgqQGG/PRZVbhnuiDIHp/q+Vp6Ayowm9D99TkvrSTQvZZhDzhhLH/qVoJG2V/9h6IpyMC3v4mhgEwNGdkM5UPgUGIoLHFA5oyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.02.25 16:45, Fuad Tabba wrote: > Hi David, > > On Thu, 20 Feb 2025 at 12:04, Fuad Tabba wrote: >> >> On Thu, 20 Feb 2025 at 11:58, David Hildenbrand wrote: >>> >>> On 18.02.25 18:24, Fuad Tabba wrote: >>>> Add support for mmap() and fault() for guest_memfd backed memory >>>> in the host for VMs that support in-place conversion between >>>> shared and private. To that end, this patch adds the ability to >>>> check whether the VM type supports in-place conversion, and only >>>> allows mapping its memory if that's the case. >>>> >>>> This behavior is also gated by the configuration option >>>> KVM_GMEM_SHARED_MEM. >>>> >>>> Signed-off-by: Fuad Tabba >>>> --- >>>> include/linux/kvm_host.h | 11 +++++ >>>> virt/kvm/guest_memfd.c | 103 +++++++++++++++++++++++++++++++++++++++ >>>> 2 files changed, 114 insertions(+) >>>> >>>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >>>> index 3ad0719bfc4f..f9e8b10a4b09 100644 >>>> --- a/include/linux/kvm_host.h >>>> +++ b/include/linux/kvm_host.h >>>> @@ -728,6 +728,17 @@ static inline bool kvm_arch_has_private_mem(struct kvm *kvm) >>>> } >>>> #endif >>>> >>>> +/* >>>> + * Arch code must define kvm_arch_gmem_supports_shared_mem if support for >>>> + * private memory is enabled and it supports in-place shared/private conversion. >>>> + */ >>>> +#if !defined(kvm_arch_gmem_supports_shared_mem) && !IS_ENABLED(CONFIG_KVM_PRIVATE_MEM) >>>> +static inline bool kvm_arch_gmem_supports_shared_mem(struct kvm *kvm) >>>> +{ >>>> + return false; >>>> +} >>>> +#endif >>>> + >>>> #ifndef kvm_arch_has_readonly_mem >>>> static inline bool kvm_arch_has_readonly_mem(struct kvm *kvm) >>>> { >>>> diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c >>>> index c6f6792bec2a..30b47ff0e6d2 100644 >>>> --- a/virt/kvm/guest_memfd.c >>>> +++ b/virt/kvm/guest_memfd.c >>>> @@ -317,9 +317,112 @@ void kvm_gmem_handle_folio_put(struct folio *folio) >>>> { >>>> WARN_ONCE(1, "A placeholder that shouldn't trigger. Work in progress."); >>>> } >>>> + >>>> +static bool kvm_gmem_offset_is_shared(struct file *file, pgoff_t index) >>>> +{ >>>> + struct kvm_gmem *gmem = file->private_data; >>>> + >>>> + /* For now, VMs that support shared memory share all their memory. */ >>>> + return kvm_arch_gmem_supports_shared_mem(gmem->kvm); >>>> +} >>>> + >>>> +static vm_fault_t kvm_gmem_fault(struct vm_fault *vmf) >>>> +{ >>>> + struct inode *inode = file_inode(vmf->vma->vm_file); >>>> + struct folio *folio; >>>> + vm_fault_t ret = VM_FAULT_LOCKED; >>>> + >>>> + filemap_invalidate_lock_shared(inode->i_mapping); >>>> + >>>> + folio = kvm_gmem_get_folio(inode, vmf->pgoff); >>>> + if (IS_ERR(folio)) { >>>> + switch (PTR_ERR(folio)) { >>>> + case -EAGAIN: >>>> + ret = VM_FAULT_RETRY; >>>> + break; >>>> + case -ENOMEM: >>>> + ret = VM_FAULT_OOM; >>>> + break; >>>> + default: >>>> + ret = VM_FAULT_SIGBUS; >>>> + break; >>>> + } >>>> + goto out_filemap; >>>> + } >>>> + >>>> + if (folio_test_hwpoison(folio)) { >>>> + ret = VM_FAULT_HWPOISON; >>>> + goto out_folio; >>>> + } >>>> + >>>> + /* Must be called with folio lock held, i.e., after kvm_gmem_get_folio() */ >>>> + if (!kvm_gmem_offset_is_shared(vmf->vma->vm_file, vmf->pgoff)) { >>>> + ret = VM_FAULT_SIGBUS; >>>> + goto out_folio; >>>> + } >>>> + >>>> + /* >>>> + * Only private folios are marked as "guestmem" so far, and we never >>>> + * expect private folios at this point. >>>> + */ >>>> + if (WARN_ON_ONCE(folio_test_guestmem(folio))) { >>>> + ret = VM_FAULT_SIGBUS; >>>> + goto out_folio; >>>> + } >>>> + >>>> + /* No support for huge pages. */ >>>> + if (WARN_ON_ONCE(folio_test_large(folio))) { >>>> + ret = VM_FAULT_SIGBUS; >>>> + goto out_folio; >>>> + } >>>> + >>>> + if (!folio_test_uptodate(folio)) { >>>> + clear_highpage(folio_page(folio, 0)); >>>> + kvm_gmem_mark_prepared(folio); >>>> + } >>> >>> kvm_gmem_get_pfn()->__kvm_gmem_get_pfn() seems to call >>> kvm_gmem_prepare_folio() instead. >>> >>> Could we do the same here? >> >> Will do. > > I realized it's not that straightforward. __kvm_gmem_prepare_folio() > requires the kvm_memory_slot, which is used to calculate the gfn. At > that point we have neither, and it's not just an issue of access, but > there might not be a slot associated with that yet. Hmm, right ... I wonder if that might be problematic. I assume no memslot == no memory attribute telling us if it is private or shared at least for now? Once guest_memfd maintains that state, it might be "cleaner" ? What's your thought? -- Cheers, David / dhildenb