From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F06C0D711A9 for ; Thu, 21 Nov 2024 17:32:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 914B46B0085; Thu, 21 Nov 2024 12:32:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C3DD6B0088; Thu, 21 Nov 2024 12:32:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78CB56B0089; Thu, 21 Nov 2024 12:32:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5B0B66B0085 for ; Thu, 21 Nov 2024 12:32:47 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D17E9814F1 for ; Thu, 21 Nov 2024 17:32:46 +0000 (UTC) X-FDA: 82810795452.21.37C4BD5 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf23.hostedemail.com (Postfix) with ESMTP id 50A17140003 for ; Thu, 21 Nov 2024 17:32:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=AUZeXvlh; spf=pass (imf23.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732210160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dGIvAVVhr1XQ+IBWwKJiytD8adIRDF3znbGFVaI1CE8=; b=6V9iUzgKz2xpFkW7FY+o1/Vx5qQMU0AIZUetWLY3DfpUn5YCXEed62S4hpZreTNWW5I74e mbHNUJJC+8g0f8jYYz3tEJkJnJ6vDSyPrtjYaBY6bSEUSCvFuXuHK10AXYMat7x7WgWNbd quJSln8NzA07aX4VCgdX3h3k+K2fvx4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=AUZeXvlh; spf=pass (imf23.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732210160; a=rsa-sha256; cv=none; b=OXkOptq1lJskKgEbDhFD+XnHneCqKZkCdtF6g4P/8j+j0Uxr/kw2sr4GbkgbMx4CxsTBqy VwlsnmzPvRYoQcSdQukuAL5I7BtPA+gn604o17BGxplipvio6L7/blB5+oNGMPa6RYFCti J3sfc0shK3u+wNfxnh2etkZwWI6lU7w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1732209808; bh=dGIvAVVhr1XQ+IBWwKJiytD8adIRDF3znbGFVaI1CE8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AUZeXvlhRTQXOreYKQ5tM6otggSm6Vmlfpnt6jWROdE8oB9IViP6vwvSzWiBSxH3B m+s13vkh7TkgT+a+wMGPI53H4oy4UB4eV3H+LH5QLoKAJvLaR/fxnklp+9E6qBAh5i SHbp4BMgosdGgvJTZj/UC6b9OP4roggPYEssKGzs= Received: by gentwo.org (Postfix, from userid 1003) id 8CC9B401F4; Thu, 21 Nov 2024 09:23:28 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 89830401EE; Thu, 21 Nov 2024 09:23:28 -0800 (PST) Date: Thu, 21 Nov 2024 09:23:28 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Geert Uytterhoeven cc: Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jens Axboe , Pavel Begunkov , Mike Rapoport , Christian Brauner , Guenter Roeck , Kees Cook , Jann Horn , linux-mm@kvack.org, io-uring@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache() In-Reply-To: Message-ID: <693a6243-b2bd-7f2b-2b69-c7e2308d0f58@gentwo.org> References: <80c767a5d5927c099aea5178fbf2c897b459fa90.1732106544.git.geert@linux-m68k.org> <4f70f8d3-4ba5-43dc-af1c-f8e207d27e9f@suse.cz> <2e704ffc-2e79-27f7-159e-8fe167d5a450@gentwo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 50A17140003 X-Stat-Signature: j5k51dzr87exu9bay1rzrnpqes5wi7pp X-Rspam-User: X-HE-Tag: 1732210330-495156 X-HE-Meta: U2FsdGVkX1+JuSe1kDTyRU+OUPIg9rrTPV0POfRWZ8r9EgVSGu4E5vOFbvaHz4gkrkRUw84opSPV77bTWtiZ7/qHFM9d39lnKGXJN8cHLSPiCtqFFtfTOMjGa36la7h95oRTAJG7N3tVcp2IhVQUMrXTXvLn8NZfNcUtUPrdeKfV81ahwd7sfgHdTwwNQvwRpY69PlXjJvggCPxmNjyFWtNsofZquCb50ywxsQZpnR232FsvOnoqQ0jXkNKI+qnGQ/7b0lv3TwSBG886hx3jXXUBEoU82ZM83rW5DWKwDTBmYBKDZ1PhLn2RsvRlMLGgOSAUfeERE6q2yRh59ECfE9aquLNaGH6AqvaLsaX75uJGOFN6DDwEU1UT7982zhH90O8NTW4Ysby0r0z90jnG/TRhSk0BYF4p6AqgZWCdRbR0izs2+k6oHZpY9EOTlIFnYgj58KovzaQLAPzFeDRjEPS0NVUh5SZ0tAJhjIuiqje1GyADza9Z3nPjLG818qYrN/D99GP80XDvcOUPoX2Vw1xkPkpcpc/njb2ETWXa3JvgIYN63zsUmidAlpHlqiedLBt66dgDRVWhCD7A917IEr/Y2Wg0DK2C7If8gIHWAFIFEGKfim/cTPv1uLKKggBRU/X68BhC7M82Se34pmwLTGxzQIEt3xM535rYrx7QV8EKKw2Pe2ZnVRizUJDLymDfDmu5/O+Qq2OzzeakWHNXTc4HtomPSoL8LYUeDj9v1SuOL7EYJVb5/9sT+czlS7zgYXKKy4IvUYEB+p5Wrkt3Gpr4zT8C326m0MeYx46xHRHhfOVGcW7v8HrLiJriCiAHP9Zy8xkESlQstgdNojO7K3RQr7/N5dwT5uuwtZlxilMepzOl2EtHy+Vis44H/dO4K6AnjIsCMMmrY+hrNOSGyIXP0snBbHdIrAWBSKJCkefMGt3WYUSn2t4/oDamGgEQG2GiyFimp/6I3o49ADw LvzMORRE d01wnBxtc4z/klyffFGI8dcIg0hSkfh2njspmBDXjfEgRSmqs4BIICgq5a38bUe6B+RFKWIjDeUX4wE8QtRq5oNqe6nQFkWSCk+5J2sG+tbSFyrbS4fv4Bd2ZR/FqXy7CDbV652AX+h7XUuhLBaQzpUPLWyLo2d0ekuaUoF0OKBsjorkKrGbk3UrWFXXnCX0fhcN5jtZV/5ACW6EOfvLdXCbS9kFiZxlGwUaKiCwPiA0OtY9uljBR4r2A2wHnNfhAqOwV9NfkCkyctmddpsjXyx36AihiXYI0FZh+mjdveHBq8Dm16R0LjX6kFyirBpFHJA9Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Nov 2024, Geert Uytterhoeven wrote: > Linux has supported m68k since last century. Yeah I fondly remember the 80s where 68K systems were always out of reach for me to have. The dream system that I never could get my hands on. The creme de la creme du jour. I just had to be content with the 6800 and 6502 processors. Then IBM started the sick road down the 8088, 8086 that led from crap to more crap. Sigh. > Any new such assumptions are fixed quickly (at least in the kernel). > If you need a specific alignment, make sure to use __aligned and/or > appropriate padding in structures. > And yes, the compiler knows, and provides __alignof__. > > > How do you deal with torn reads/writes in such a scenario? Is this UP > > only? > > Linux does not support (rate) SMP m68k machines. Ah. Ok that explains it. Do we really need to maintain support for a platform that has been obsolete for decade and does not even support SMP?