From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3EEC28D13 for ; Sat, 20 Aug 2022 02:29:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 018E48D0003; Fri, 19 Aug 2022 22:29:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F09E38D0002; Fri, 19 Aug 2022 22:29:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD1F68D0003; Fri, 19 Aug 2022 22:29:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CE7678D0002 for ; Fri, 19 Aug 2022 22:29:30 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ACE89140497 for ; Sat, 20 Aug 2022 02:29:30 +0000 (UTC) X-FDA: 79818389700.18.5B7C8A0 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 6E09820021 for ; Sat, 20 Aug 2022 02:29:30 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id g18so6189387pju.0 for ; Fri, 19 Aug 2022 19:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=h/HJ65cb2+nIGwhv5QH5QTgJ4jWxy0giXVXsSHB7yko=; b=iuCRhwHvRBHWpZ+AfOlPMiIE4kR6hweHfR1SBEN6YW20gjBM2ixZbR8hui4zb1FfIH KONz0WtxxHeYRsbXWN+bjJviEfSFdSqRGJdlYqSqh5cRn/Px1liqn3nUwC/MUpWEDAEN WlbKswo9JvZGBBdDfcbkhIz9dANcSE7v1j1JETjYFPobMcWHjdOPimg+iKnFUaGrIEgX vtxMk8zhKjKbYER1nFnXhJikpbg6sBLINjhe6EkPkFRBJsyYXLaD+70sjpXYUbpihqFO deEFYRZKvN3dcYDAA4FHkW7+m5urs0X7b06MlsxndKKUnI27es9IuyGrEWZ22Fw4uaIR 6hEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=h/HJ65cb2+nIGwhv5QH5QTgJ4jWxy0giXVXsSHB7yko=; b=h4WR51mk3OtDoPW3fnVLMMuswrbv9bataXssAlmh3sn6IQIzeGcRlIflTG6PcY/GKF 4CdfeCwBfiif4u3Fl8tUov16XMk/9mzsioYRBbBDBti8xwXclVJJESjQwOk6R+WejQrR 8pYrWkhXRlZaouFwvuNE38awpEtGtcgA37Nn4ONJOdln23Vha0QWk/HB4Ni84jt7h6KG CAV5SNAkM33Y6KaSsmH4bCqEB3leU5VdB1BjZiibenEdpKL10RTZa9boa4qbI5UY2EkA utqoqVIW2+xrX1NNMwkbaFieJoy0edCnSIFwSMLi9f3FXD037vJGK9vs/GfQLjmWpqxI Im7Q== X-Gm-Message-State: ACgBeo0SUpoT2U/Omr54XzTkUqqoms8M1HAQabW7/3VXvuIvVrMGzQ12 Yjg0lcx0Csd90I0Rqbx+wZI= X-Google-Smtp-Source: AA6agR6Zpo21opq2l8HWg7HLYMOJyGVGl/tr0rum0zXAixFaKrG0xIztTBKPV4VCL7tZ2YidfzXR0w== X-Received: by 2002:a17:902:ef96:b0:172:abb9:657e with SMTP id iz22-20020a170902ef9600b00172abb9657emr10056786plb.48.1660962569323; Fri, 19 Aug 2022 19:29:29 -0700 (PDT) Received: from [192.168.43.80] (subs02-180-214-232-69.three.co.id. [180.214.232.69]) by smtp.gmail.com with ESMTPSA id u6-20020a170902e5c600b0016d88dc7745sm3793478plf.259.2022.08.19.19.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 19:29:28 -0700 (PDT) Message-ID: <69366c8b-9bbb-7d4c-4d0d-4948d04e71bb@gmail.com> Date: Sat, 20 Aug 2022 09:29:24 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2] mm/damon/dbgfs: avoid duplicate context directory creation Content-Language: en-US To: SeongJae Park , akpm@linux-foundation.org Cc: badari.pulavarty@intel.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220819171930.16166-1-sj@kernel.org> From: Bagas Sanjaya In-Reply-To: <20220819171930.16166-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660962570; a=rsa-sha256; cv=none; b=5GPG5jya5YLzZqTNaMXkjuG+0SHaMMQopGKxO+frFr0aNkkEVxd+sShiiYs1EsX4zqylWJ sIjSA+OzpwKEUs4S/ZYCxaB3T8/+mDp45qCiXzfFSkCLJF7gh2P3CoYrRKlR+Ej2r9slAU aOt1WudKf9vVJiSHh4pMsgn/AKloWik= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iuCRhwHv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660962570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h/HJ65cb2+nIGwhv5QH5QTgJ4jWxy0giXVXsSHB7yko=; b=Fsro9IRXBJURwOmSdHKO0mtQcmUYON7icAbioODg6QbaxzYWo+4zZXkJJgWDUYuT6SYoqw +0juMDm+6BBxA8F3omNom3Y+7XzqoGgj1Vrd9TWJBwdfMi+0pY/csYCqC5lgHiiXCWNnid kvU6M2/oj8HvhWX9R/PDnV3l2trCo6A= X-Stat-Signature: w88cw1dsctmg9her9hhx8oduouy1zdpw X-Rspamd-Queue-Id: 6E09820021 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iuCRhwHv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1660962570-188488 X-Bogosity: Ham, tests=bogofilter, spamicity=0.011648, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/20/22 00:19, SeongJae Park wrote: > From: Badari Pulavarty > > When user tries to create a DAMON context via the DAMON debugfs > interface with a name of an already existing context, the context > directory creation silently fails but the context is added in the > internal data structure. As a result, memory could leak and DAMON > cannot be turned on. An example test case is as below: > > # cd /sys/kernel/debug/damon/ > # echo "off" > monitor_on > # echo paddr > target_ids > # echo "abc" > mk_context > # echo "abc" > mk_context > # echo $$ > abc/target_ids > # echo "on" > monitor_on <<< fails > > This commit fixes the issue by checking if the name already exist and > immediately returning '-EEXIST' in the case. > Meh... SJ, I have seen most (if not all of) your patches uses descriptive mood instead of imperative. Better say "Fix the issue by checking ...". -- An old man doll... just what I always wanted! - Clara