From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8214CC83F22 for ; Wed, 16 Jul 2025 11:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 130B46B0099; Wed, 16 Jul 2025 07:02:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E23E6B009A; Wed, 16 Jul 2025 07:02:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F13E96B009B; Wed, 16 Jul 2025 07:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D6EB86B0099 for ; Wed, 16 Jul 2025 07:02:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F6098034E for ; Wed, 16 Jul 2025 11:02:47 +0000 (UTC) X-FDA: 83669839974.28.9D8DA29 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf19.hostedemail.com (Postfix) with ESMTP id 5104C1A0006 for ; Wed, 16 Jul 2025 11:02:44 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BAcvOfFM; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752663765; a=rsa-sha256; cv=none; b=aYWboxIwyGtmKYoC/GdV2BsloRZC7G5SdAZyhTIfsKpa+UPP8BN6ladnOqG4K+ZSxyIoCq oRs+52EeZFki9AZuioYYpkPrp6vzwHyHbRiFFtNyZxCqQgWPrxqdQSSjYNnKNRhq0LuvxG Bchtkn5b0AOb1D/yiVjZn4/kSFABkJ8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BAcvOfFM; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752663765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k9GEObhlbEUt92Do62d83VZnRT3ktZEclZUgLVvenIM=; b=pWoW1zi8mttlx9qsw11FM8zrpGvRUApUaex6dD+RpFUhrECLQuLFQAUYIbjVoKI1uvFsvB 9X1UszVSbrPamY1QQmvc5ys3DZNIMLz4MOqwmoHHhUCZeMUR3em9U9Np4UilJ0qi09py/p VlkbgET/c8nfGt/4f438mnz31mhRw/U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752663765; x=1784199765; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lER+t0W/+OnaqRUfd8abPlZ0d7DVYXV25GgqbWYg6VI=; b=BAcvOfFMpd+bF+aJzXgtAd64w9CTZIxFnbpO8L0j0C8u/6oeZ8/YNNon sDyIMMe8P1rBfb1DJTWPqocpD/LEadl8SsNqTQ1WPeu8R8ACX3olPgFKz JhFhhd/UVm7i42OpYQe2H7bgwy/VRs7ApjP0OawT9SVqQ+B9djlYgK+jM V5wvYyRyd8njwGVPqvXmwJbIO4Bwjdiv18NMtDs6L60A2DUF52mTvy7eK JyYeVWgmCPZr/pYacI+9qKeqYERYKJKzMKLUp1Ra9OiYsKduNAOEZklgh KZu//mNMEOKDDgdkwuVUiV2aotqTL85+MdoT8ZXoDYIlFB9NV+rIN9dLD g==; X-CSE-ConnectionGUID: WcpYYTGdSa+kvz5DnznYPQ== X-CSE-MsgGUID: Knb28AWiTaSIAbOXwUKAVw== X-IronPort-AV: E=McAfee;i="6800,10657,11493"; a="66260402" X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="66260402" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2025 04:02:43 -0700 X-CSE-ConnectionGUID: OH68QhdZSpC5tEXA5T8uig== X-CSE-MsgGUID: CfH8gGxYRD27Pg1cRecICg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="157281588" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2025 04:02:27 -0700 Message-ID: <6927a67b-cd2e-45f1-8e6b-019df7a7417e@intel.com> Date: Wed, 16 Jul 2025 19:02:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 02/21] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_KVM_GENERIC_GMEM_POPULATE To: David Hildenbrand , Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-3-tabba@google.com> <418ddbbd-c25e-4047-9317-c05735e02807@intel.com> <778ca011-1b2f-4818-80c6-ac597809ec77@redhat.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <778ca011-1b2f-4818-80c6-ac597809ec77@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5104C1A0006 X-Stat-Signature: zm1n7gnzngbsitg1mox8ce3jk513nxc6 X-Rspam-User: X-HE-Tag: 1752663764-25859 X-HE-Meta: U2FsdGVkX1+9Dx4ilY9Kkfzw5PwTvoActoMo0ka+5WnKIAdIewRuTCR2pldBd3yNUJ5v9JRXmQne9UVvy/9dVIeo+bVk/LEXMZ93AdUEqPrTqoQr29H/CR7FHZFW0H3ps/DvBoURTHNIEVoCKpMsF+oZnm8X7fzhFh/y5Skpe2HxGSbKiRktXRNwLqna1PevG6ON48gJD95eXvSXqn2vaASvZoCb9HPgf2M4klwHFdDf4B+6SBTiZW5HB1AbFdf0JEqvYQrrvZ7Kda8V126taUh+fQogARZhOuM8tTk31rr4KTO7dcwFwyc0IYXdIKjQNYOy2sFWR8cgjFxwqrDHWwjhwUILEQckTH9ZmMcJo6kIl59CKRkSYK2iZFW9A1C3y0cj3EtRgou3xVT6sfrHnBccbLgGf7PwYKOBiiyPCwgXew0c785/Ldg36Fk9OTJwPb0KY0TNDJ3CkoYV0fW+UPTsLmQUBfhOWkTx10VYZL7sGHPCx/Az0fXr0NZ5+Tibi0oJdcKaq1DaWhQvDITM7sQ04xnRINtQti6reSqBsilo695QdKQ+UaqruJ+yO+aiidtwudYFqYb91em2v0BcnhFRx8/zZSxYwpom/URfnbi8Zr226XVBFcEiMwdBuhwmpzY6ha1hm15vcFQcDyADpFrKkckxflNz3fxLNqxmnhImtOzqSntGjoQ9dDliqn9cWF4iBp4yOWDGk9gJWgcb6oz04K43zR2RyKLkejVx47CtlFyMvAa8kJIyS0IXsgfYpNmL5A5kFnLq7s3Qhh98K4QrVX4+Moc4B4pRdSPQuGE50IONgOvZD07ccgMTDCvOFaKOGTb0Ab07jtMEQqjhVLtvZTo3kR2pGLI5d7JYwFfO8Va8u2Ov0SU79gvlq+Uina6oGHL5GZT9iWvV25cbXS9EFYD4Ol/b5ynuNK+yQpnTwj+0ydMfWeLqUAiPYmhKfwkKeMvOCgNEmpdaZG2 B0/ylCXe bNRa+fmxskH4AzSMa/d7bbdECkHaxxycS41JJyGVDtr7AaqZ7HGqSv1Eu0Sgf1aezGEXGm6+Ia1MXBMV06SN8oF1izw1JI5qvINoAx5KadasG3DGhKGq8FacpsedyBLEvTMb78RYNqMmUcKhbin6aCnpXFC3mzXwPYI7w/1fAi1Q0spv+3BCBGQFOjjPU2LErOe/ic/dRPEjoCUQoW1AgM/KNR658Nh12TXHiMlsbAUAUWYjr1oZoF0PbitXEBJ2ivHV4XGT8mcGTbvvXkY9m7ktuWJMjhltYNtIZJdPzVb+Q7eatyIL5q03Qj2rolfT3LHlh4yhsIGCNiQJMBNo142bMNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/16/2025 6:25 PM, David Hildenbrand wrote: > On 16.07.25 10:31, Xiaoyao Li wrote: >> On 7/16/2025 4:11 PM, Fuad Tabba wrote: >>> On Wed, 16 Jul 2025 at 05:09, Xiaoyao Li wrote: >>>> On 7/15/2025 5:33 PM, Fuad Tabba wrote: >>>>> The original name was vague regarding its functionality. This Kconfig >>>>> option specifically enables and gates the kvm_gmem_populate() >>>>> function, >>>>> which is responsible for populating a GPA range with guest data. >>>> Well, I disagree. >>>> >>>> The config KVM_GENERIC_PRIVATE_MEM was introduced by commit >>>> 89ea60c2c7b5 >>>> ("KVM: x86: Add support for "protected VMs" that can utilize private >>>> memory"), which is a convenient config for vm types that requires >>>> private memory support, e.g., SNP, TDX, and KVM_X86_SW_PROTECTED_VM. >>>> >>>> It was commit e4ee54479273 ("KVM: guest_memfd: let kvm_gmem_populate() >>>> operate only on private gfns") that started to use >>>> CONFIG_KVM_GENERIC_PRIVATE_MEM gates kvm_gmem_populate() function. But >>>> CONFIG_KVM_GENERIC_PRIVATE_MEM is not for kvm_gmem_populate() only. >>>> >>>> If using CONFIG_KVM_GENERIC_PRIVATE_MEM to gate kvm_gmem_populate() is >>>> vague and confusing, we can introduce KVM_GENERIC_GMEM_POPULATE to gate >>>> kvm_gmem_populate() and select KVM_GENERIC_GMEM_POPULATE under >>>> CONFIG_KVM_GENERIC_PRIVATE_MEM. >>>> >>>> Directly replace CONFIG_KVM_GENERIC_PRIVATE_MEM with >>>> KVM_GENERIC_GMEM_POPULATE doesn't look correct to me. >>> I'll quote David's reply to an earlier version of this patch [*]: >> >> It's not related to my concern. >> >> My point is that CONFIG_KVM_GENERIC_PRIVATE_MEM is used for selecting >> the private memory support. Rename it to KVM_GENERIC_GMEM_POPULATE is >> not correct. > > It protects a function that is called kvm_gmem_populate(). > > Can we stop the nitpicking? I don't think it's nitpicking. Could you loot into why it was named as KVM_GENERIC_PRIVATE_MEM in the first place, and why it was picked to protect kvm_gmem_populate()?