From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B074C36001 for ; Fri, 21 Mar 2025 13:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D10F8280003; Fri, 21 Mar 2025 09:17:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C99C5280001; Fri, 21 Mar 2025 09:17:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC695280003; Fri, 21 Mar 2025 09:17:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8B850280001 for ; Fri, 21 Mar 2025 09:17:19 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 893001422D3 for ; Fri, 21 Mar 2025 13:17:21 +0000 (UTC) X-FDA: 83245609482.27.7BB3998 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 5662D40002 for ; Fri, 21 Mar 2025 13:17:18 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F3S2Cpri; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742563038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dq3Hj8gPeDCA8YR5G45cntVoKw1hN2KoBbCsLCkkwSo=; b=q7e2RxIESs/RCaH2Wqk2JN8HZhCRoxAxT++1+zE9aCQQehcHMOY3ceb/1EULJcweqrgyNj xWjLBfqanJBqiNkcoaM2d5fOUmXJlcvSWad91pnegWRFHG3Lbgv6JF50kz/C1L0NASLFKL MG54FOc4Pw4xZ28yF0nKdenRcVYBb6g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F3S2Cpri; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742563038; a=rsa-sha256; cv=none; b=l839tc4SskbNp4x8RXnmt1pwUsnYcSpl9OCmvucX1+TImjtxhiK1AfYtQLM962DlHh6rVg RXWB18u38LhnyTlDgEp4WZPZbDexQ5ZffIzIN9waXJgkm9KwC0sQlbxPc+mFjEuFpG0G4D bjfOiId4bMB0qW2c8UM3tmGRADnsU0g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742563037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dq3Hj8gPeDCA8YR5G45cntVoKw1hN2KoBbCsLCkkwSo=; b=F3S2CpriR1xdy2NFYAJS/80OK7+YibUTyBnAAdQINFzmvaZJyq0fpbqauOL8YWGPxhtkjR XBLuPzW6zEzTGqkbQ7g0fjb6wZH1H+ajW/e9XAd+RnYrCBQ6PWKFkdmEknYEFdFdS9PX4t oIf3mLZUUWd94EDQY8ZsEXLmKLHzlUg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-PAJvoNQRM1qawj5egKdX_w-1; Fri, 21 Mar 2025 09:17:16 -0400 X-MC-Unique: PAJvoNQRM1qawj5egKdX_w-1 X-Mimecast-MFC-AGG-ID: PAJvoNQRM1qawj5egKdX_w_1742563035 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43935e09897so13176165e9.1 for ; Fri, 21 Mar 2025 06:17:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742563035; x=1743167835; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Dq3Hj8gPeDCA8YR5G45cntVoKw1hN2KoBbCsLCkkwSo=; b=LOdhNm4083fW0bYyYbXxEuIo8ILVk6wYcTLzPCM+hogrDfRWL7Pq61U2R8yJJVuxZ0 n0o6caAIIRwsaQ9asi4Rt8VTHgj3CkavO6zTHXkwBQLsa56JuvZZE7m31Kr9AOWdhBRh +6tO4V+4+JDSID1oCfY1ONFe4t0S6DNKDg7Sjsm6lKa83vqSS6V6pczD5QvpY3/4gQRm Sbh6b0DHSbiO1IrEDCo0neTuIvqwkD/kF+nRX/iEgHKA2rpvhxRuL/gup130rUlaGLk2 FDmEC5IP6xTpTNO91/7r8Q7fuh5JG9n2wdl1sp2tdu4RGy97RQtZMQOTxiOHfWh9v0+s mnIw== X-Forwarded-Encrypted: i=1; AJvYcCVODm1D0OjfKFUr6gyenfPJLFGeFbMDXsEjkwm9Zc/gdq9EN5Qh0Cjs1oj0kfINWpJliiCjgZxz2A==@kvack.org X-Gm-Message-State: AOJu0YxJLGHd50kQYqXs3QljLT0BdUZIti3Yq11iLKvKw1QCS5kCI8IZ myy+uPI8hPEbs47FLopnt4opKfv5/danM+bi/5tE4VfMkm+RKW9RYqb3wr+2p3EasyTBnVK+Qw1 N/vW3wZl6JHb90Z4aLd772/Y27yNdY7Rw3Y/tDnX3V+ShlvX8 X-Gm-Gg: ASbGnct1bjsrXTthfobHHC4fOR5P+AHEgTdKY+0PPqcwheWGwYFNsvoDXtLDyUTx/A9 K5hzlo5c9koE5hH+XRHTFHzp2pGaEwIP0+tNKCydm8gWa/QNg+eqW83lIoaVFrMFVO+nymnTpEk yrW+FaDvRbVCCpGS9D0h3VRTZVv9jBuW7bL9QusoA0tj2wkLGrRULUiuf8NjY0Qpvdoub/bkUaG xhITICMEOL/ekq6GkaJp3Np7w3iKlDBgPq/KMH5sWacG32z42NsFM18s4MBXElaHh2VfRQb+kbQ o2pMYuLA+j/fVN7cgJFARtzDQw/c3viup/w2VF3UyozwHg+7jptsGrrABCBXw4+uyEFKoebI0eg LbscEgVRnJLLuSmeG/76/Gf+fWhwQUWD+c1RTOLC2gM4= X-Received: by 2002:a05:600c:1e0d:b0:43c:f689:88ce with SMTP id 5b1f17b1804b1-43d50a1d1b4mr32164175e9.20.1742563034969; Fri, 21 Mar 2025 06:17:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0Zz8OTC0SBn9u7TvheCk2N+jYIOaRrdB9xOl+x7aeYutuqY8BRuH9FouxASHDSollfi9sWw== X-Received: by 2002:a05:600c:1e0d:b0:43c:f689:88ce with SMTP id 5b1f17b1804b1-43d50a1d1b4mr32163515e9.20.1742563034538; Fri, 21 Mar 2025 06:17:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c72a:9100:23d2:3800:cdcc:90f0? (p200300cbc72a910023d23800cdcc90f0.dip0.t-ipconnect.de. [2003:cb:c72a:9100:23d2:3800:cdcc:90f0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f47196sm77012285e9.16.2025.03.21.06.17.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 06:17:14 -0700 (PDT) Message-ID: <69256f08-1d1c-45ac-945a-495ef4ffc558@redhat.com> Date: Fri, 21 Mar 2025 14:17:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] kernel/events/uprobes: uprobe_write_opcode() rewrite To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , Andrii Nakryiko , Matthew Wilcox , Russell King , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , "Liang, Kan" , Tong Tiangen References: <20250321113713.204682-1-david@redhat.com> <20250321113713.204682-4-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Lvg7eep7ttTWYDVnmMalCcW5dmTUTb_L27r_KBm2t2A_1742563035 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: btmo9a4udk9m4pwqtha5hb8id86m6guo X-Rspam-User: X-Rspamd-Queue-Id: 5662D40002 X-HE-Tag: 1742563038-59788 X-HE-Meta: U2FsdGVkX19DoswuZC8nMdoYAKXQGMmFNbxa1IS6frfhRzFtH9vNVmiByM562y9JB+NuvQYJL83GpZCIn846AzPnOH2Vf42EfLLVMGulN+tHKLYkHheGpbpUQNFYnuKcbX1cR78tTxaa0HGX8na0A74sMm4Q+n++ODkpFsBg/rYZvaH8rFEzUUVXLI2g1xOfFWHXB0xHqfCFSNg7uKlEPqWtpfio3ZIoVCGkbXmeqYDjKQG22hSWWnNb8Wic7EHwuq8kW2uexZEtf9bIeMlKMY5Ga0QcONJSjxvAh4WrhxABXekCnQD2rQsXQI61vkcXkOptMyChEmyd8jGmSZgPyhJrwsSjYsGME98i+oy1grEtSdq0Vtv1wUB63OIe5eMZMmcYrKf9XLrSn8BKLtMQyFflqIab6q4ajoIBOwhWvVbliINKCfSB7B91JKRiIlUB8NQaI7H8fNC9krCSRN7yHBmmCD1qGk0ZkSS7eQFKK7d9xDqX2aVgb8BRM4hLuip34TP4DASmFP0CljysjR8QPB1t5SVa3tRdxp3khJE+0nGMZuf5BuXUgquLl74Irb3BIrxhENBnHfgvKCN+OmoduYvS1RCfVioq2Z7EOlzL02ZEBtjgccBfnxFDMYdDhTcIMfJhvw0pMJBCse4svUvBM2itB1emyhkhWy69yC27DGscPedBYc/GqrZvnIIzwTaaejHnRzITXHtRA1YjFxxIj+rSXy+yJtyGoJWwpfwYzRIdh4LI3q6E+EwCGN7NTVPYvqOaeqJIFqoVc/Hi8QEottI3glnyCZZlmA01CC8NlMWRM1E9PGmcc/I/tKKLpC9VdVAoMNCEbz67EQQzeCrAnLcnnjx/83jDH0BKO1CFPpoX63xyvRljt7uSW7S5mdagush2mPxNVOSmvliwGMHQtgqbBBjMl+1YL4cx0FkqwJtCYVQ9NLTRlIY9HK8i9rErJWDQrklwAmNZg1No1eG 64Bd8rcd JwUEUUY/y1gCk2TYt+swLObVSE19vX5YZQ37jiqBtLycraF3d8kXmLaglOdNCx4bNF3aE7StuCQYr8X9KIQ/b2z17crqmCREwkOpy8437x3IbokOSIeLAVqFwBBQ3aKJFry9oM37azLNvXudkAutkaWpvw/9ovdclVeAO9ZWGDr14wlKAQULqJILYrO1qKS6xDrgePLzL+dTZJxjakgGRFuVRLHjWIHlEipnr2vdx7d5ZmPh0p41L6FfTboq2/TaB3CiS1HDvk33tMxjlQnyIx80WDST1BWMQvwCdVfvrs4NBeLy+PCPC1IN6wEJEH6A7vGoj6eTQ4o/i12D9Uwk38Crx5uY7K+BoFtUVThzX84Avgi2JzXX47VaAIzlpbm33ibZKe9merlVg6A3UYT9SbsJfOSMaAXRqJBEDv0n4/BVyAQXUK2J1RlNaSozQOr+uWQzy2BygznvZ96owiDtQTlG5t7zX0olbKRRZY+Y2spOBVJtKjN8WKuate8+7CQGmoJSMw8mbMX19qfo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.25 14:05, Jiri Olsa wrote: > On Fri, Mar 21, 2025 at 12:37:13PM +0100, David Hildenbrand wrote: > > SNIP > >> +static int __uprobe_write_opcode(struct vm_area_struct *vma, >> + struct folio_walk *fw, struct folio *folio, >> + unsigned long opcode_vaddr, uprobe_opcode_t opcode) >> +{ >> + const unsigned long vaddr = opcode_vaddr & PAGE_MASK; >> + const bool is_register = !!is_swbp_insn(&opcode); >> + bool pmd_mappable; >> + >> + /* For now, we'll only handle PTE-mapped folios. */ >> + if (fw->level != FW_LEVEL_PTE) >> + return -EFAULT; >> + >> + /* >> + * See can_follow_write_pte(): we'd actually prefer a writable PTE here, >> + * but the VMA might not be writable. >> + */ >> + if (!pte_write(fw->pte)) { >> + if (!PageAnonExclusive(fw->page)) >> + return -EFAULT; >> + if (unlikely(userfaultfd_pte_wp(vma, fw->pte))) >> + return -EFAULT; >> + /* SOFTDIRTY is handled via pte_mkdirty() below. */ >> + } >> + >> + /* >> + * We'll temporarily unmap the page and flush the TLB, such that we can >> + * modify the page atomically. >> + */ >> + flush_cache_page(vma, vaddr, pte_pfn(fw->pte)); >> + fw->pte = ptep_clear_flush(vma, vaddr, fw->ptep); >> + copy_to_page(fw->page, opcode_vaddr, &opcode, UPROBE_SWBP_INSN_SIZE); >> + >> + /* >> + * When unregistering, we may only zap a PTE if uffd is disabled and >> + * there are no unexpected folio references ... >> + */ >> + if (is_register || userfaultfd_missing(vma) || >> + (folio_ref_count(folio) != folio_mapcount(folio) + 1 + >> + folio_test_swapcache(folio) * folio_nr_pages(folio))) >> + goto remap; >> + >> + /* >> + * ... and the mapped page is identical to the original page that >> + * would get faulted in on next access. >> + */ >> + if (!orig_page_is_identical(vma, vaddr, fw->page, &pmd_mappable)) >> + goto remap; >> + >> + dec_mm_counter(vma->vm_mm, MM_ANONPAGES); >> + folio_remove_rmap_pte(folio, fw->page, vma); >> + if (!folio_mapped(folio) && folio_test_swapcache(folio) && >> + folio_trylock(folio)) { >> + folio_free_swap(folio); >> + folio_unlock(folio); >> + } >> + folio_put(folio); > > hi, > it's probably ok and I'm missing something, but why do we call folio_put > in here, I'd think it's done by folio_put call in uprobe_write_opcode Hi! We're zapping a page table mapping mapping (folio_remove_rmap_pte()), so we have to drop that reference. That's the folio_put(old_folio) in the old __replace_page(). Thanks! -- Cheers, David / dhildenb