Re: [External] : Re: [akpm-mm:mm-nonmm-unstable 66/67] fs/ocfs2/aops.c:1133:17: warning: variable 'i' is uninitialized when used here

[Mark Tinguely <mark.tinguely@oracle.com>]

On 4/22/25 7:55 PM, Andrew Morton wrote:
> On Tue, 22 Apr 2025 13:12:41 -0700 Nathan Chancellor <nathan@kernel.org> wrote:
> 
>> Hi Andrew,
>>
>> On Sat, Apr 19, 2025 at 09:21:13AM +0800, kernel test robot wrote:
>>> tree:   https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git__;!!ACWV5N9M2RV99hQ!NYsFjZmx0oSNmGPOQ57M8FqiwN9x_0uNHOsZ0H_bxMZw11U8F1-i2FIS7wctmB4sSockZwPpufGxuROeTnhBAaPs$  mm-nonmm-unstable
>>> head:   d1a9b961293d30be9a865d8685590635db282957
>>> commit: 89e3e963129e945e0333e474709bde627b6a9cee [66/67] ocfs2: fix panic in failed foilio allocation
>>> config: s390-randconfig-001-20250419 (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20250419/202504190950.rq1NDlDz-lkp@intel.com/config__;!!ACWV5N9M2RV99hQ!NYsFjZmx0oSNmGPOQ57M8FqiwN9x_0uNHOsZ0H_bxMZw11U8F1-i2FIS7wctmB4sSockZwPpufGxuROeTvSadMWN$ )
>>> compiler: clang version 21.0.0git (https://urldefense.com/v3/__https://github.com/llvm/llvm-project__;!!ACWV5N9M2RV99hQ!NYsFjZmx0oSNmGPOQ57M8FqiwN9x_0uNHOsZ0H_bxMZw11U8F1-i2FIS7wctmB4sSockZwPpufGxuROeTvn1221-$  f819f46284f2a79790038e1f6649172789734ae8)
>>> reproduce (this is a W=1 build): (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20250419/202504190950.rq1NDlDz-lkp@intel.com/reproduce__;!!ACWV5N9M2RV99hQ!NYsFjZmx0oSNmGPOQ57M8FqiwN9x_0uNHOsZ0H_bxMZw11U8F1-i2FIS7wctmB4sSockZwPpufGxuROeTuWmwFGg$ )
>>>
>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>> the same patch/commit), kindly add following tags
>>> | Reported-by: kernel test robot <lkp@intel.com>
>>> | Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202504190950.rq1NDlDz-lkp@intel.com/__;!!ACWV5N9M2RV99hQ!NYsFjZmx0oSNmGPOQ57M8FqiwN9x_0uNHOsZ0H_bxMZw11U8F1-i2FIS7wctmB4sSockZwPpufGxuROeTgKlYSkL$
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> fs/ocfs2/aops.c:1133:17: warning: variable 'i' is uninitialized when used here [-Wuninitialized]
>>>      1133 |                         wc->w_folios[i] = NULL;
>>>           |                                      ^
>>>     fs/ocfs2/aops.c:1101:12: note: initialize the variable 'i' to silence this warning
>>>      1101 |         int ret, i;
>>>           |                   ^
>>>           |                    = 0
>>
>> There appears to be something funky going on with "ocfs2: fix panic in
>> failed foilio allocation" in your tree, perhaps as a result of applying
>> v2 to mm-nonmm-unstable and v1 to mm-hotfixes-unstable? If you compare
>> https://urldefense.com/v3/__https://git.kernel.org/akpm/mm/c/392a664f6d2740eeae23df0d29b56f444f558a7c__;!!ACWV5N9M2RV99hQ!NYsFjZmx0oSNmGPOQ57M8FqiwN9x_0uNHOsZ0H_bxMZw11U8F1-i2FIS7wctmB4sSockZwPpufGxuROeTnnwerZK$
>> to https://urldefense.com/v3/__https://lore.kernel.org/c879a52b-835c-4fa0-902b-8b2e9196dcbd@oracle.com/__;!!ACWV5N9M2RV99hQ!NYsFjZmx0oSNmGPOQ57M8FqiwN9x_0uNHOsZ0H_bxMZw11U8F1-i2FIS7wctmB4sSockZwPpufGxuROeTnn7W1rC$ ,
>> the second hunks do not match, which is what this is warning about. I
>> see this same warning in next-20250422.
> 
> Thanks.  Confirms that the universe is a plot to confuse akpm.
> 
> I dropped everything and remerged the v2 patch.
> 

Thank-you for remerging the patch.
I did see the automaic tool complaint and I visually verified the 
indexes and discredited the complaint.

--Mark Tinguely