From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 667D7C369C2 for ; Thu, 24 Apr 2025 17:15:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCA556B00B4; Thu, 24 Apr 2025 13:15:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4DCA6B00CD; Thu, 24 Apr 2025 13:15:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7BCD6B00CE; Thu, 24 Apr 2025 13:15:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 873496B00B4 for ; Thu, 24 Apr 2025 13:15:03 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 20052161475 for ; Thu, 24 Apr 2025 17:15:05 +0000 (UTC) X-FDA: 83369587770.19.C07DD90 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf19.hostedemail.com (Postfix) with ESMTP id 001471A0006 for ; Thu, 24 Apr 2025 17:15:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2hZyWLWf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wn+UeLPQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2hZyWLWf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wn+UeLPQ; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745514903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8jA/Yq2sLS38l5G8KlTT+Pd1kKyunnmm3yQ5Qp9zrVQ=; b=XpEjsPZA1shYsCl+c7RBXeBDUBRgmNr1CmGfyyIIsxqQX0/3bpTuUkPqvWyuIBFvzdwZJV oxMZPGAmTh3RNpurdX/f+Trb0lCyf5HXLbRdTOWDA3vM9M6y5ZobvNA2ZPF42/YYOQJGHR F72AJYjCsjlaP33vO4+HJpesbbEWZL0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2hZyWLWf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wn+UeLPQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2hZyWLWf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wn+UeLPQ; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745514903; a=rsa-sha256; cv=none; b=V8mQqqyERQgBKQb3QgGt3+CYTboyDqvflmcJ4L0VwAlxIFMMMTGkDhiHbY+ytS/5IdypUc LTOgZ78zT9r51llwKAzVBX74Nl6lw7Kg2rrss6YRhzadwxeubSIvrxOBR+HhkKY/nEX/97 gWXGmpyk9NZfptSnh0IJt99sxmPvYys= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4FE371F443; Thu, 24 Apr 2025 17:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1745514901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8jA/Yq2sLS38l5G8KlTT+Pd1kKyunnmm3yQ5Qp9zrVQ=; b=2hZyWLWf+UC9v/ZRtwrwRlkE2JY6xC6F+61YKo3LnHoCWrvu19loWtL8lKPTvZuqWff+xo 2k2jCatOwyPUh55FiWku+4u65fFjytOQUAoBhVAHHuVqvbjrHwTBZxMRhlC4tLcjKcfATU JPeKzjmgE3NvXWdGPeHeO+b3U4bJDlo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1745514901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8jA/Yq2sLS38l5G8KlTT+Pd1kKyunnmm3yQ5Qp9zrVQ=; b=Wn+UeLPQNIiE8LoygUPcOnHfVxls+Q1lG/TeKDf9Psc7K4AsGjmDMOFHCjS26t69miUX3k P/kw/osTi/vpbeDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1745514901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8jA/Yq2sLS38l5G8KlTT+Pd1kKyunnmm3yQ5Qp9zrVQ=; b=2hZyWLWf+UC9v/ZRtwrwRlkE2JY6xC6F+61YKo3LnHoCWrvu19loWtL8lKPTvZuqWff+xo 2k2jCatOwyPUh55FiWku+4u65fFjytOQUAoBhVAHHuVqvbjrHwTBZxMRhlC4tLcjKcfATU JPeKzjmgE3NvXWdGPeHeO+b3U4bJDlo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1745514901; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8jA/Yq2sLS38l5G8KlTT+Pd1kKyunnmm3yQ5Qp9zrVQ=; b=Wn+UeLPQNIiE8LoygUPcOnHfVxls+Q1lG/TeKDf9Psc7K4AsGjmDMOFHCjS26t69miUX3k P/kw/osTi/vpbeDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 342D7139D0; Thu, 24 Apr 2025 17:15:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id S9xtDJVxCmhhJwAAD6G6ig (envelope-from ); Thu, 24 Apr 2025 17:15:01 +0000 Message-ID: <691b0ba9-7587-4663-8aa3-8ce63ef509c6@suse.cz> Date: Thu, 24 Apr 2025 19:15:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only user Content-Language: en-US To: Andy Shevchenko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Cc: Christoph Lameter , David Rientjes , Andrew Morton , Roman Gushchin , Harry Yoo , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zhenhua Huang References: <20250424164800.2658961-1-andriy.shevchenko@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20250424164800.2658961-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: pjmdbs9f6ho6ne849cp18t4dmrcgw6h3 X-Rspamd-Queue-Id: 001471A0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745514902-668534 X-HE-Meta: U2FsdGVkX1+0s+BvtEGLkBxlbTuXDzvti+zlnGuGfm3U9k178/EUxr+mW9z+vYXE46xrX8WDSNHo4j5IXmSxwc6QWzH2VsB6HOjbXvwp3bkcXqzGjpsyh2C595QLJ2UhZ/DyVg81Ca9cxRmCtjRdfg6BQNseCnYSQVHz5xKL2wdOCUL+89qqkwb5FsYHCLh2tpcZQsWfRb/dhI9rsEjaREFI3g2gXUXakf4Eb0UkuM9IwkBsOC63vkpMpDOnrHzyGsz3urkTCtXfjFWZzNMHdxPvbKJXT1ZMDAl/xQKXcVRzKFvoDYCej3ETrZDpzSkKdQ/XhgXr2rAIFlODD3hv3onSa3gf8tx03t1oORR+i9B43DAafmaHmAXBiCxLvKpoCkJ48ilP8P2X/BBshmeak9TJCFvEst+nzDRL5thX8oSYZpSjgYAXUQ2QcSzbtsh15kgjOlN3qm6ozpNrOUQ2Trd7mauCUHnyeb/YBZ2WpzW3ysJryJENgGKLCDIMhQnV0tKvpBKszBhLyhcJOnrPbLyxp3oKSHN6k9sU5pHjFnd6yuJOoXkpQDK0oJ1kNvCVyCX7Fgsof0GMJ1krH86FfuBcXsuFwKJXI7XBGDQ3jZh1YFuidosa9nxqj8nNWccCFg7oWYbtkr14oXxmhTXeFLskvI5EB44ytTwMH4gyR0ZEExDDuE9SDUQVursFI5Dd3GNrbQJYWOFv7yeSrRhpiH9ReaAN/TldKvRIn1TXKco91CM1jEOcj4c41sJ7Oj25rgOhaEN5d7X6d+Mlre0aDoR1te0Y86CHOzwDUx2it6cfQ1Eyai1h55sxR1vG3uitbCCIpOzm8xOTQJRSJ1pCdXST/nRokbvcjmxeOwn1f8G/ISn9/5a7H4YJQjuVraWiHih9+HL/oilA1/qhG5mk9oHB4TMoLf5OWSUmVKqyn/vRXO8Mq9yt0veGZVLWt0nXaoClcEYq81ulzplCywq jDE+HocA /wHso3f63W/+meSsISJIZBxxTBWMzYmu6Bg89BlhHwD6w4hJNypj17Ey1oaYEXTMahz9VseOPLmf5eiUxHOxpFq16tQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/24/25 18:48, Andy Shevchenko wrote: > need_slab_obj_ext() is used only in one place, fold it into there. > Without that, clang can't build kernel with `make W=1` when > CONFIG_WERROR=y, which is default in the x86 configurations. Note that gcc doesn't warn on this even with W=1. Is really clang + W=1 + CONFIG_WERROR building ok these days except this one unused function? > mm/slub.c:2079:20: error: unused function 'need_slab_obj_ext' [-Werror,-Wunused-function] > > To solve this, fold need_slab_obj_ext() into its only user. > > Fixes: e33b7ae3d802 ("mm, slab: clean up slab->obj_exts always") > Signed-off-by: Andy Shevchenko Thanks, I've folded the fix in.