From: Vlastimil Babka <vbabka@suse.cz>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Cc: Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Harry Yoo <harry.yoo@oracle.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Zhenhua Huang <quic_zhenhuah@quicinc.com>
Subject: Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only user
Date: Thu, 24 Apr 2025 19:15:00 +0200 [thread overview]
Message-ID: <691b0ba9-7587-4663-8aa3-8ce63ef509c6@suse.cz> (raw)
In-Reply-To: <20250424164800.2658961-1-andriy.shevchenko@linux.intel.com>
On 4/24/25 18:48, Andy Shevchenko wrote:
> need_slab_obj_ext() is used only in one place, fold it into there.
> Without that, clang can't build kernel with `make W=1` when
> CONFIG_WERROR=y, which is default in the x86 configurations.
Note that gcc doesn't warn on this even with W=1.
Is really clang + W=1 + CONFIG_WERROR building ok these days except this one
unused function?
> mm/slub.c:2079:20: error: unused function 'need_slab_obj_ext' [-Werror,-Wunused-function]
>
> To solve this, fold need_slab_obj_ext() into its only user.
>
> Fixes: e33b7ae3d802 ("mm, slab: clean up slab->obj_exts always")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks, I've folded the fix in.
next prev parent reply other threads:[~2025-04-24 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 16:48 Andy Shevchenko
2025-04-24 17:15 ` Vlastimil Babka [this message]
2025-04-24 17:22 ` Andy Shevchenko
2025-04-24 19:41 ` kernel test robot
2025-04-25 17:07 ` Andy Shevchenko
2025-04-24 20:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=691b0ba9-7587-4663-8aa3-8ce63ef509c6@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=quic_zhenhuah@quicinc.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox