From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C16CD98C4 for ; Tue, 10 Oct 2023 21:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC5DC8D00E4; Tue, 10 Oct 2023 17:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A75E08D0002; Tue, 10 Oct 2023 17:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93ED08D00E4; Tue, 10 Oct 2023 17:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 809D48D0002 for ; Tue, 10 Oct 2023 17:32:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5D83AA02B0 for ; Tue, 10 Oct 2023 21:32:05 +0000 (UTC) X-FDA: 81330849810.22.DAA0FCE Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 54E14120007 for ; Tue, 10 Oct 2023 21:32:03 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=PTsKTffK; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf29.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696973523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Pjl5gkMN+tM8cTCpSlEYTm/NSKpOFFUeh14zRzLcbk=; b=io3jcpvYzwBlvrwan2pIEEetaAxae9/2W2k2ryHYIJdPZecwIuNOJaapns5AQIjziSERLA n79Sd9tKypICNL2twFyIThcteZC3norLrqmpW3/bi9FHtx2v8uW3HLyKm3YsVD9IW1A86t 4NMpGe3jrvLLCmms7duZt92MONU4ofg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=PTsKTffK; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf29.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696973523; a=rsa-sha256; cv=none; b=XKkrnVGVUm+6NWNn5JGJTd4/BG9aHOHjZ7Mr+lXUqFWGESdvr5qu1UZG2bbIJcdZ++AIzN GwomIgCU7nbrHSxMkHUHOfa3/rNieYNo0z+GCRBawb+hCjEJSAs8SGLn2R1RG8Zcx+vhB0 Qaxx3h4yC3EbfQAcNwkDh0QKrupmgj0= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5042bfb4fe9so7551604e87.1 for ; Tue, 10 Oct 2023 14:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696973522; x=1697578322; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5Pjl5gkMN+tM8cTCpSlEYTm/NSKpOFFUeh14zRzLcbk=; b=PTsKTffKKx1ZqfBfAFA/bBKhtqOAH9Z5tw8cFnyW1wyyZNN/U0VQaKvTff2ApXcNWE pdNzfO+cD17CQfPTFWgZuP9Uy0mqbWIN9uL1co7Gw8muzha5qpPX2tbnfhqHXOz50jUl 2nHmNnexBUdRvSogTeGTm7fgD59GseeLjzJdmYqo5wdVv2meKqFJQO4uozSCifNpW32A HUYyFWPg9vdn2LSrX8PnXxbxALh7uhqfVQZCxLgjTt52UwGUi+Nfdt1R952D5ly+SFXs YWS2UpWjKIyP9Dg6z1u5q47Dm3D8Ekumcx3J5wRj4TSswyibyAhM46sB7EN/Txwy0DDl iaJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696973522; x=1697578322; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5Pjl5gkMN+tM8cTCpSlEYTm/NSKpOFFUeh14zRzLcbk=; b=KNhvtR1rXWOInw6mykzDUoWB4icSAv0KxsaThOiL1cvqyh6lC1qwDwoBpr7n/EWxTN UXz668LCe5x8/j8Vexrehbbs5F5IeN7UWhXQIFLhzHeveKckUqkmq9R2tjwIrihmJQll e+E4j9lBQy6ifalwhHN21yyh+SqQBwAdWm8lFXaNIDzSStpST9HA8rlmUUQhp9EQcgmW LR3QjnkNPJoDQgzkc29tLyO4FCa7j6XvfT3K4lLkgxw39diHLEmQLrOJgS08VwG1nigN eqC4xuQgPohZaJoKJ+blvhO31jb9ByHCKvK0NJ/kplt/ENmY68M+7vhQvclp2MpTF+3W p5pA== X-Gm-Message-State: AOJu0YwwRVP3JcCFeWCwXXygkpK4untCxZOZ5AEJEPO5TFjqDcAbqsJG VICn96WWyzI4e0BUwS3A+1mzsg== X-Google-Smtp-Source: AGHT+IFTH+PnydGygfHJ5Wn21hsrxocpZo61z4PXV5Fk+BDkmC1vFS6LrzUHkxTN24/XcrQG8pTqMA== X-Received: by 2002:a05:6512:a8b:b0:4ff:80d4:e132 with SMTP id m11-20020a0565120a8b00b004ff80d4e132mr22854903lfu.29.1696973521677; Tue, 10 Oct 2023 14:32:01 -0700 (PDT) Received: from ?IPV6:2a00:f41:8004:ab80:24a8:5e5d:e0b2:5884? ([2a00:f41:8004:ab80:24a8:5e5d:e0b2:5884]) by smtp.gmail.com with ESMTPSA id s8-20020ac25fa8000000b0050482b29ac9sm1965533lfe.212.2023.10.10.14.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 14:32:01 -0700 (PDT) Message-ID: <68fd8e0e-1788-435e-a0fe-77b4252387ad@linaro.org> Date: Tue, 10 Oct 2023 23:31:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [External] Re: [PATCH] mm: hugetlb: Only prep and add allocated folios for non-gigantic pages Content-Language: en-US To: Mike Kravetz , Usama Arif Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev, songmuchun@bytedance.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com References: <20231009145605.2150897-1-usama.arif@bytedance.com> <20231010012345.GA108129@monkey> <6b1d9860-3581-0b99-4fb7-4c1f5a2a05f3@bytedance.com> <20231010213019.GB279095@monkey> From: Konrad Dybcio In-Reply-To: <20231010213019.GB279095@monkey> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 54E14120007 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: yzdj8g41p8zi1hwcsurmn9qha1ufz4df X-HE-Tag: 1696973523-196192 X-HE-Meta: U2FsdGVkX1/kP9LIHGoY9J4t5xNK3cOhL/Bik6liXa71Xa8sdu2CO6A/xG0fVIKXuUD3mRCFLMKQhvJXPTtcAy59RGujHHXjCktBcUM6aOKG7vTzQmkwuQz9ARZFDZ71BZ2yCZ7O3IEwNzPh4yrBhAmIYApP7zKV3acWOMNNfgTbZ1SqVbJBBeOUNbe7VkPZVZObGWbiglrJjLOef/tHnV/RRkqvB5MLZCOGZ6Qs9TU92yYAC53vKlVgGTt5AQbtR6YRazwwvfGjjZAbVvKLWufXtLW03lwvmVxTmN7IlAz4CJ5GHuUVGRCQKSVAmJdGGnxNP7kJY2dDjqVy1JQZ+1VkGXlQ2q7i8eNSmv6ePkb+BbINCiSOc42pg2fgpZyVQn7fI44hr5Fd/yQOF2v/nQsEdaeTKgzQjDc8l0MmwW1xWTSDsUyUHwrqqgtYuGcUrZWnczI+UwAKijobpv8ZDivt7ECHHkia7kYK+hAsHxIObFntheo2Xlc1Bnc/jBndQwqx4O5apnFI4g4MyyfnYGGk1k4Craw2zoBgOsiiBo4xRy/XFJIqaSPawXZ5oxEpy6xyF7cDnnfJhUO8+bDQxQbC86+1eTAZGoKvPtpjJ+JkR9aO8w65If8h82quk0AdsndGSSR0hVoivIM36+F9LyXrf2atwCiZcZOel4WQQdOCHz5Kf4L7MADjN/QWv+qYqn9rpbi8LFqkm9vY8MZ4G/N8aaYmWOdcgLUG3DcvNtKLxAmTHlQcpCloWQ5Pyq1RSh5lSSZ0vnzwTzmCitpyUVKsGWFtHQNrnciJHsLHHSGT5cGTi6utjELBpVcS6Iqr8m+XI9xPdqqdJd+oGfoyrTKG9YZuxC5hRSn4dlf/CInOUpU2BrEezM8+fuJBku2hbKa8DJyzKDjG96ofGm7Cp+3291kVCp7De3AgKpA/Gu86ikCjZ9ilc85y1EAIiHA8s10rA8PME3liXs2541N 796kwhdE Mcoa6JzKKNk4Z7+Z96ctokijY10exC4FzOevXzS1pORuyqyhuCRmVEtBW0fsqlMGWm/0MUXTfTEVUsvXvBguQ8N284JA+GdQiJpWlZAhLJ0ynHFpjHuMEEWEIJIkBo1Py3vSnkYQcZ90ozoISVFNwoAeVvM56JBtaCZJ/xpi5zcBSxNkgchdXW/bM6VGCb+MK4MqJFFAHJx9kf+Tr/U7gky1qxizig3rM1OSSG5NOvp3NAT34U4efTMb5MSR/D1t9eJTXUm1HslyPu4wWTGlwNBTM262V1i0qhdA/2Hf0bdZFcM0eheTlh6PUJWoBRngBTBR7qRYX07nlIaEmi+E6BDLkcGfNgBvQ/VAgGDWBUB4MCn1688tS/e8jClODsSndEVNZy2SlUhKS0/1fj88a/tHJ5oTNQ5uvzETXJ+jCo9frIlbcg1+l6XIN7Q2WW54ZMuXVDMBSBh4Wv6AoeXLupamJJgyNiAeaarTIf7C3nlmDnaW11uWUEdMq/vPLQrcXMVwd X-Bogosity: Ham, tests=bogofilter, spamicity=0.001415, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/10/23 23:30, Mike Kravetz wrote: > On 10/10/23 18:01, Usama Arif wrote: >> >> >> On 10/10/2023 02:23, Mike Kravetz wrote: >>> On 10/09/23 15:56, Usama Arif wrote: >>>> Calling prep_and_add_allocated_folios when allocating gigantic pages >>>> at boot time causes the kernel to crash as folio_list is empty >>>> and iterating it causes a NULL pointer dereference. Call this only >>>> for non-gigantic pages when folio_list has entires. >>> >>> Thanks! >>> >>> However, are you sure the issue is the result of iterating through a >>> NULL list? For reference, the routine prep_and_add_allocated_folios is: >>> >> >> Yes, you are right, it wasnt an issue with the list, but the lock. If I do >> the below diff it boots. > > Thanks! > > I believe that may be that may be the root cause of boot issues with > this series. It is unfortunate that the failures were not consistent > and did not directly point at the root cause. > > Hopefully, these changes will resolve the boot issues for Konrad as well. > > I will create a new version of the "Batch hugetlb vmemmap modification > operations" series with these locking changes. We sent a reply at the same time :P [1] Konrad [1] https://lore.kernel.org/all/6f381d4c-d908-4f00-89b3-ed3bcb26b143@linaro.org/