From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC245C52D7C for ; Thu, 15 Aug 2024 16:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A7866B0171; Thu, 15 Aug 2024 12:39:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52F5F6B0172; Thu, 15 Aug 2024 12:39:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30DA96B0173; Thu, 15 Aug 2024 12:39:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 119AC6B0171 for ; Thu, 15 Aug 2024 12:39:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A2C7E81762 for ; Thu, 15 Aug 2024 16:39:30 +0000 (UTC) X-FDA: 82455040500.30.A6BC33C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf11.hostedemail.com (Postfix) with ESMTP id 4000340018 for ; Thu, 15 Aug 2024 16:39:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mVPQBXWf; spf=pass (imf11.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723739895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JPA2PL+CeBl1p6pJOvKvH0vZaS1izS3V+ce+gU37gSI=; b=n96SPUd6wjlUUeOhx2iarx6SlNr9uYVe1vJrcc6Be9ZmNBvNO+5b0sezawXVr9kO9dvIq3 3ak5nYbiew2jgAMZPWOjKQrWBQT4Z9j/elrOwPq2iWdFbbgAYG4NMY+ecKLemUaS1xU7yp 2oVSob2YVV/H8+XYlynQXsAzfDtvmCI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723739895; a=rsa-sha256; cv=none; b=SPl2X965IiY9c2C87WaDG2hb82S4jVnJ4+fonTbugGpnzkM2s9Ax8/pmdAmwTYgrpwOo6U RiQ8xXQyEITnmosIlvjyOTLIYKRXlT/PjbMfQjXHjXni8GdRWoNHlfsRX5enap9jreZ1lx 9ZycvSiBIkeRc74GRAxf0TrVouczJRE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mVPQBXWf; spf=pass (imf11.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BE330CE1D0D; Thu, 15 Aug 2024 16:39:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A991CC32786; Thu, 15 Aug 2024 16:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723739962; bh=nqEGxPh8pwY20u2MZKu3nNO4QLRYnQ4hjFehvCemvbM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mVPQBXWf4rO5tqOD7E573dr/pYnLkTbMxIobg0TVBQo8vrWdsI+BSdGVLxb3z+DuI AB3CwtvHVEesic9NWEB62pNPzB0UJqdc4mZ/YzivT5ZFGoUdfWmLZh0iYBRkZNSExn CGmJRmgQTCFJdl9Jw4SsQ6861ethBoLCMBjuFdUCeyp75mtiYAk9jbkXTk4v+6uMeT No3dA8UXevsw+hJpGxWXFGCI0EsP6KJ4mwGaZhjhGW8rn/ZTEU4zMNmsprnEpxb62I jijupNJtzAxMTcTemcyG6LtY/cD39wLSqWkRJGa6R7ozAs02XXoMJxVcOvJZnO77q8 Ub0FE7zYHQYCA== Date: Thu, 15 Aug 2024 17:39:12 +0100 From: Mark Brown To: "Edgecombe, Rick P" Cc: "corbet@lwn.net" , "ardb@kernel.org" , "maz@kernel.org" , "shuah@kernel.org" , "Szabolcs.Nagy@arm.com" , "james.morse@arm.com" , "debug@rivosinc.com" , "akpm@linux-foundation.org" , "catalin.marinas@arm.com" , "oleg@redhat.com" , "arnd@arndb.de" , "ebiederm@xmission.com" , "will@kernel.org" , "suzuki.poulose@arm.com" , "kees@kernel.org" , "oliver.upton@linux.dev" , "brauner@kernel.org" , "ross.burton@arm.com" , "fweimer@redhat.com" , "aou@eecs.berkeley.edu" , "linux-kernel@vger.kernel.org" , "paul.walmsley@sifive.com" , "hjl.tools@gmail.com" , "linux-mm@kvack.org" , "palmer@dabbelt.com" , "kvmarm@lists.linux.dev" , "linux-arch@vger.kernel.org" , "thiago.bauermann@linaro.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH v10 12/40] mm: Define VM_SHADOW_STACK for arm64 when we support GCS Message-ID: <68ec09da-fb4a-4d59-9c8c-6fae4c48ea68@sirena.org.uk> References: <20240801-arm64-gcs-v10-0-699e2bd2190b@kernel.org> <20240801-arm64-gcs-v10-12-699e2bd2190b@kernel.org> <34f7a5378447b1a8d5a9561594b37cfeaa6bd2b1.camel@intel.com> <3a7d9b69-e9df-4271-a3f0-8e8683c2654f@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vKd189vsbNknapJj" Content-Disposition: inline In-Reply-To: <3a7d9b69-e9df-4271-a3f0-8e8683c2654f@sirena.org.uk> X-Cookie: -- Owen Meredith X-Stat-Signature: 1su5kyfmujei47b4rgf7nf7mstix6p85 X-Rspamd-Queue-Id: 4000340018 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723739967-177435 X-HE-Meta: U2FsdGVkX1+eka0nbB7hTe7P6eBFdFelclaFp7NwIL6FFx2j9rHnX0gjNzeb/xFr162taoGj8Jq0mqJphIOLTXvkAuZ3G3srZFrgU8+RfW/WXU8kp2+/xz79L6EKKG13p13nUj1JYm7E2GauBf0tzP+whk7qiTqH2ORICuIiwS2/f2ItirPHTek3SyXatlj+boENSzzT+CfA6KEPHq5kOBFvp6R9GHBg0z3oLMvEsGoVl9rorhnKqG2xRMIMxbRYvhw2bUcXWTZJOPfnf/mFPQV194kudHqb6b5rWqyhm3Rldy978BBw7rYiAigfgTnr6VS3XUTH9uRQyI8bgvJE1wKpj9hks5Z2zr7ka+0JNfkcnn6ZbqxGHaC4I4h5LvyiVKX5zk4QeHiQbzs6uJTaa7HdoNplyfIHC0UdTNuoVzFeABzxWt2T+GWLc9qr1ouMPocgT8SVR/STUUHWc+Y/MaCrGXsgtBcTRCSNRmL4own+I5FuLyq/ROYqxa6nkgn6BjhhvjOw2q+mQlhWRcJpyYuJTTzMkOFqQN8kaI88ju4OMwik0zCWPSAS/dJ2gOsqBFcj1HrewWf1SnNs1LrckRkS3W2e0kO+BY9/3fQY3g0UQfLldC9HzbCSO8n9G85gj19J//C5aPwo6I26dYmVrH7VJMIWfdLI2edAML1P1SBV3TNPvzx6rZYO9t0t9fDfBEdXbXyGwu4DTrNpJkcF5epb4TZKhYqtSTdEzrvEAH7wGuwH33OxsCNUOIEKQ9+shwbWQEEJwoArsgYWMsRwM1Bcb/g7Xk0AIJIaXzfbeBkX1JY9poAXguLXxQEV/iLXiPAwsKQCsXjPg92yYqy8aS0jnhiWOhbmgb9u/yLVPqFii9bW6PMHHw3gHUQiwe1sM6mJwTduXa7ATzyJFiCNWXnCM8t49GYh0DG59SPJRC4OcR06+sFL4edRoIFvDKewLeh7rV3XYucDj6YJjUB RkoK4pQD pJa0ibL19gWIcyG3nEp7ss+RCQx/tCmjvxV19n7WIhgJbhjrTShbxBHwQwRWkxJuh+dujzKZlosn9sC8mPj4io/R3+Gtg05zh0X8aV0NjoonjC1JthlKu5ceS4gH9XH+DbvXErWN1gQYND0zDFWO/0AoXOApVgutsyzz/tur3/MeDxCB1OYeZHzwf2qh5d/gRqUqPL4nLiEgsLbNawB3Jum3sZKMgsxMTaIkzucf4C9BTGisV/Mip/uQ5i1zZMZ9VVELqE2t2RTrO3RD1YwZ9F+G9M45Rsn3s+VVC1gZ8jiRdlfBd/jJ9WmFdB2bQUHm22sZs4i7wN9nD7oVCzFmSQ5ejUzeEcL8RR0u6kQc3UE+uhTtFTn/KMBII8zVprBblUh0LEoFS29tpSKctaiS+FcfsJxVylE/Wqry1De/xPbe+cgZE9BlDn0E9qAeE8Uez/O5GFisM6fBWqoX8mNCrqvXy4lYAW10UV9yrrLOV21dTi/HfotQ4xd52AXZF7Ld0JWUFpmAVPJBU6JY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --vKd189vsbNknapJj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 15, 2024 at 04:26:47PM +0100, Mark Brown wrote: > On Thu, Aug 15, 2024 at 03:20:52PM +0000, Edgecombe, Rick P wrote: > > FYI - If you want to have more complete guard gaps, you need to do this for arm > > too: > > https://lore.kernel.org/linux-mm/20240326021656.202649-14-rick.p.edgecombe@intel.com/ > > Using VM_SHADOW_STACK only gets you part of the way there. > Oh, thanks for the heads up - I'd missed that. Looking at this I think it makes sense to do as was done for x86 and split this out into a separate series (part of why I'd missed it), updating the generic implementation to do this by default. That'll touch a bunch of architectures and the series is already quite big, it's not really an ABI impact. --vKd189vsbNknapJj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAma+Ly8ACgkQJNaLcl1U h9AuIgf+OuQaTIedzXEkMKSzSn8gQPJlIY5KrokvUJ1INFNplupcL8meQbjGaCke k6p6rULpXRg8dAR2gjIllIWy3YaYrcqKK7VUWUVHy2rdwtozDi5JICj3GVYrZ1N4 RHRL44Xq/dMXBORv5Zm06QeTaZxhgmj+wKvnVVrgiZN33cbHEULW5W3HX/qCcsDe 7qR7858W0Qkm1wZ8tyY3UkGI8AiUO3oMCaQ/pokDf9EDQagBid3Aqe0iMQmRacMZ XaEy5ijWBddwXQb8qolzElM+ySPoxEf+jwEqHAH6WP4ke1NlJrj6+Xn7JN+/OuY8 Lv5n7BHbDEebZQo46ohDBN+Q0iR0vg== =uwcZ -----END PGP SIGNATURE----- --vKd189vsbNknapJj--