From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8273C7EE23 for ; Wed, 24 May 2023 04:44:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4952D900002; Wed, 24 May 2023 00:44:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4450D6B0075; Wed, 24 May 2023 00:44:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30D56900002; Wed, 24 May 2023 00:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 20BDD6B0074 for ; Wed, 24 May 2023 00:44:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DC85E1A0161 for ; Wed, 24 May 2023 04:44:54 +0000 (UTC) X-FDA: 80823908508.22.3DCBF4E Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf19.hostedemail.com (Postfix) with ESMTP id 15C021A0013 for ; Wed, 24 May 2023 04:44:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=JamDd4Jm; spf=pass (imf19.hostedemail.com: domain of hughd@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684903492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f39bjKJNzB9G9TX7qCTMm8x8VJ3ouN/VRnt5yvT027M=; b=VVmFJSMThumarsAFSF4SlGzsUaGA3+rIbu/RokAtizQs6xw/Xc53gsnNJLhcnzNlzqcH9G LVVVnQr1FnZRchGxEILarH6GvNbfGqyLbUNBYRQ1/RtJqQpy73llkVQVRg3uxEtV5mhaHR BjDtoUYUyxVxOgmKwAhTazHAvAQx7IU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684903492; a=rsa-sha256; cv=none; b=0i8QBY+6i5TKOQSU1kv78gggPcY1YhoOsra3HRgxCJMNoCtHJW55Yu2nbJMBRxHAUWLHA8 F3nO4hozR2ls2rYQQRAOEzT+9C/klWVoZDBUPsCXq6DMcKwODTOZMcndIVSnw4wr7K/Jdl poOek5smaJSRqUDfEEVm1xQ5MSbOl9g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=JamDd4Jm; spf=pass (imf19.hostedemail.com: domain of hughd@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-ba94605bcd5so1090514276.2 for ; Tue, 23 May 2023 21:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684903491; x=1687495491; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=f39bjKJNzB9G9TX7qCTMm8x8VJ3ouN/VRnt5yvT027M=; b=JamDd4JmP2zhvbpzAN8ngliSnhtsVTDQSCSV7Hhb56MoCA7ZC/5kjp3iAYY3jTd7EP xZRm4swmN1onU5EY8cggSHzBhSy7GQyAgwZwiXXJR6YA7vJJ08DA9W1T33cDol1onPqA D2Rd5ZOGonVvRlkM/o3I8rfuT9x4XQ5YVxYLcRKOHJ8JBzXyznhKpZ7Kn98JIFVUnGyJ 3SE2IMGhoxRZoZu0BNgNaKt1m/z8GHzXkn72+Wg/4Dy+31KCh//EwJ45MOvMh9rvXuVf lBqYdWuzPXQ9IJrpXeedl6J1SaUmF9r5BmI1rYL2p5IAzBxLpcuYx8okDzMNFhvyLq75 D31A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684903491; x=1687495491; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f39bjKJNzB9G9TX7qCTMm8x8VJ3ouN/VRnt5yvT027M=; b=Ni6xuxyyAW2F4Rz1PHLakP3kupQ+h5Wc38zifAipsh+DGSxAubhYy1zgwt/x3dZQI3 JwInQv6t0dNvG7nyQWvTmTFMHGlNF1R0FIeJu79TbgQLkpfoDIDeouqAsYaciZRalKQg QDMRkdzra5e8icg4HXQxzQhMQ5qaEt/VCPzW1+cRWbYIliYLhiLYvWR5suBm5S899EqC w1jY/RTLwvOchiHXfJ7L45gYKwluPKH7RLmX7AJ1S+OlcxpGhHZEYfYH1DKovLIn/lzB FokFL8toe3Pvl9uXq+9jp2CAACC983xaQA5Tg3pmyQnDlP9HDu/jT3AqeHaB7Am8h86N oXNw== X-Gm-Message-State: AC+VfDwa/xvv9Y9q5OBG4Thy9bgiQZx1EfxxknMOMyKBix1SEX+6Inqv wmw7xwovoQZcJwXFts0m986C5w== X-Google-Smtp-Source: ACHHUZ6Udji73O98VKhs/8RJOjJyNFJJ9VQVeCUmuu3F+F1oM4lZMvgR8dLHY6gzcqHMiz7EhGVRKA== X-Received: by 2002:a25:acd4:0:b0:ba8:7158:f0ac with SMTP id x20-20020a25acd4000000b00ba87158f0acmr18104751ybd.57.1684903491047; Tue, 23 May 2023 21:44:51 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d143-20020a25e695000000b00ba68a6e547esm2539120ybh.48.2023.05.23.21.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 21:44:50 -0700 (PDT) Date: Tue, 23 May 2023 21:44:47 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Yang Shi cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 27/31] mm/khugepaged: allow pte_offset_map[_lock]() to fail In-Reply-To: Message-ID: <68dddbbb-bc3c-367d-798a-cbe2a69664@google.com> References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463760895-655262871-1684903490=:7491" X-Rspamd-Queue-Id: 15C021A0013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: dsaxgxzzmprn6ibnmu7napjy9mwagji4 X-HE-Tag: 1684903491-659846 X-HE-Meta: U2FsdGVkX1//FlYFsJHieksU+D7L9YQsL6TAWIpwpHG20vD4ovdzd/dSkqdpbnFRRuXj99ioQ0yK4nRrO3+rCyQuBPTBoTpJFGn5e4/+ejzpoB1AnJ3y4OkD37wgkQ4dPsxiLADcDnA2a2IA1iysRQAFAYga6cCArz5wnsDF5zs0c0qtzE/ifDThircO2RVkv1Q4m3L1Llui78mMIk/ffeHWOO+wSF3UNYDvuVwmbozrHlLGg2uPuJmGaf91PHofyB7bFXEHs65QIjUjlEWPNS6QGCkKgXOybsc3rw8uwsNDd+0qcWc+jW6JO4+r3/JoozUrq2lazij3/d0r3JQpvtYw4PseFmpLg5hphT6bbt6mC0dRntNKLypBQ5Ofm27wviBm+/w5FQT7nQxQ3cTETYzVvxMuYpJ9AOQsj9RnAUDMIzcB+fQw+dPttHT7VZqyUZLlmgnQsJ7OY5O99ejLI6W4tHn4XyRsiNEOlKHld7ERj7WBr0ZtXPB88/apdGY/QSYgFAH3WeRVKT8px1xU05MxASf+slVKE1HgmKAkDr2BEkV6GuLrPVcAW3UfXYx8vAjz5IzdVt3C3lI+Q28qXfc81wGKS639UOtxzeFGxPDDa7/jgQGTNU/gqOiJJ46n1ooiS1l3wc5YUn5m6vRJM0EB6C4+vySQTpMTZuJ5eOto/B7lGnvwNGxjzM97JiPA91vl0uziF/hrXLsI2wRKLcqAIOJIrx457dOPqPMiIHD0z4BdZ6kkCe9Obh6zzwBWedC0dxa8/UuLP8q1EVjxg1zUh2a+fIxSxiMPp2jRSr34KN6nU2crHR5j+LTvjRInTeUh8BVYHKximdpZvmPSAASZBVWZ8ekQcXq0IrYv4ypdmt3R7T4x1WTvHMhn+bn61Zu5Kt4D6A4yaRGlXtXcXCetJoy+8Q5of7+XDoQpWFVtZXORmBQ+0ly0ImGnleNxLAfAbY26Ozfkelcpq9w S6/0yZ6j jqEUeq8c/Rh6v94VOS7GfsJN6VEgaeinpNpQhQjE0Ob4PdVAjZ6mMYiPvp1ULXR8CC5fqnUVzLvVAxfWWr/cEFX8QnG5onUVjjWVDikmZjuljJhNFZiHIwUjgHvuxCIoaDOWmxMss1Du3tZ0AGVPWFOL0WuMKKmXyXZCDSXvckx+UDizdr0dolwY62aSANKeiLB7gpUA8x+EgRV5aCtomj2kawyl2XqHfylLLQ6RtYIYi1utHWBt5qaIZVXcq9Ur7TxQObECKpMNEf7dG5uFnmtB71dB8YQPMoBORiIoGZeoXAhZuCo0zlAqKPMm5hWM0ubiyazUMTDdwstYxu7uuxeGlj/1VvW2P1MJRCDPWr2aKx8ASbMhvmGRem1GiE3ruoBSuTaes6BvzeL2qh81kOVIY3juBz/6MK1Qdqve8rRRqmQ4F9MO4DaXZJP/kArmI1COKh3vR18VRrV77AbBqPECOVTNONGvXjCaSPNS4jcQPuounfMzDMkoLHR6Av1J+hdHlUJuEvIL0W2KV5zJpPXVBKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463760895-655262871-1684903490=:7491 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 22 May 2023, Yang Shi wrote: > On Sun, May 21, 2023 at 10:24=E2=80=AFPM Hugh Dickins = wrote: > > > > __collapse_huge_page_swapin(): don't drop the map after every pte, it > > only has to be dropped by do_swap_page(); give up if pte_offset_map() > > fails; trace_mm_collapse_huge_page_swapin() at the end, with result; > > fix comment on returned result; fix vmf.pgoff, though it's not used. > > > > collapse_huge_page(): use pte_offset_map_lock() on the _pmd returned > > from clearing; allow failure, but it should be impossible there. > > hpage_collapse_scan_pmd() and collapse_pte_mapped_thp() allow for > > pte_offset_map_lock() failure. > > > > Signed-off-by: Hugh Dickins >=20 > Reviewed-by: Yang Shi Thanks. >=20 > A nit below: >=20 > > --- > > mm/khugepaged.c | 72 +++++++++++++++++++++++++++++++++---------------- > > 1 file changed, 49 insertions(+), 23 deletions(-) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index 732f9ac393fc..49cfa7cdfe93 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c =2E.. > > @@ -1029,24 +1040,29 @@ static int __collapse_huge_page_swapin(struct m= m_struct *mm, > > * resulting in later failure. > > */ > > if (ret & VM_FAULT_RETRY) { > > - trace_mm_collapse_huge_page_swapin(mm, swapped_= in, referenced, 0); > > /* Likely, but not guaranteed, that page lock f= ailed */ > > - return SCAN_PAGE_LOCK; > > + result =3D SCAN_PAGE_LOCK; >=20 > With per-VMA lock, this may not be true anymore, at least not true > until per-VMA lock supports swap fault. It may be better to have a > more general failure code, for example, SCAN_FAIL. But anyway you > don't have to change it in your patch, I can send a follow-up patch > once this series is landed on mm-unstable. Interesting point (I've not tried to wrap my head around what differences per-VMA locking would make to old likelihoods here), and thank you for deferring a change on it - appreciated. Something to beware of, if you do choose to change it: mostly those SCAN codes (I'm not a fan of them!) are only for a tracepoint somewhere, but madvise_collapse() and madvise_collapse_errno() take some of them more seriously than others - I think SCAN_PAGE_LOCK ends up as an EAGAIN (rightly), but SCAN_FAIL as an EINVAL (depends). But maybe there are layers in between which do not propagate the result code, I didn't check. All in all, not something I'd spend time on myself. Hugh ---1463760895-655262871-1684903490=:7491--