From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4C21EB64DB for ; Thu, 15 Jun 2023 16:39:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2263B8E0001; Thu, 15 Jun 2023 12:39:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15FD26B0074; Thu, 15 Jun 2023 12:39:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1A058E0001; Thu, 15 Jun 2023 12:39:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DDF186B0072 for ; Thu, 15 Jun 2023 12:39:28 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 969C21209C0 for ; Thu, 15 Jun 2023 16:39:28 +0000 (UTC) X-FDA: 80905542816.29.9434C67 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 72B91180014 for ; Thu, 15 Jun 2023 16:39:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X3QeXZJ0; spf=pass (imf16.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686847166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=85Cde2lC1B5p+slsHblZ/ywkw9kOFzxqw+4KoOzSvts=; b=C2sqlIRJBMxYO07zTvQENRyuBl3uTSRVKLCCCUTUs+JRSPAtjG6iiCxAVJCoyvOcG34Pgv bmIrI++l1cXo1sQy0+Q+qt8m8Io4BKkhgLNDpuU6Bc+D5UQVLE6Fnj4fSt6FV+F77V7+9p w6nUTIK6ldkjtf4cFnwtSW3qBQQR6Bo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686847166; a=rsa-sha256; cv=none; b=I9sE1vpe9euTu7pJ8h44myv9lOCpLF94iLFgbn5xnl84+QbpWo27HX3thBIjal2VSpfs6Z v6JOq3GhIskGbqTHLOst2ESPGAUf2zvdS/kXnf+oxqCzgA/frYyrgnXkXa5NzP0PRmAwJu ub3TfAO4bSD6xQynanQ6CigGOmGUGlI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X3QeXZJ0; spf=pass (imf16.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686847165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85Cde2lC1B5p+slsHblZ/ywkw9kOFzxqw+4KoOzSvts=; b=X3QeXZJ0RtvYoNO9SuP6yMVxqUZI0T+sfOuGeGuwhl9AkGtTEIv9O4bJBsq8kfSSqzvskE eJy30LQCeZA4vxK+Z3AaYN+C/tfjjKWB0CdE1KH2Qfp3+qTPh3iVALMyNI5uFweCxNBVPT kw1pMd7wlsL3Pno3SaqrBtNZ0X0m1yQ= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-G24ETx5wNhWdUeThVtC7gw-1; Thu, 15 Jun 2023 12:39:23 -0400 X-MC-Unique: G24ETx5wNhWdUeThVtC7gw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-98281e071fdso138193866b.0 for ; Thu, 15 Jun 2023 09:39:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686847162; x=1689439162; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=85Cde2lC1B5p+slsHblZ/ywkw9kOFzxqw+4KoOzSvts=; b=G0t2BiMBTZCyaNTL+wEbAGNRo6addgjmHXOmxc6ssEO+DrllxIgKC0TW92onprSdTe B8TSc+9gA2GIUTxPAGieFW13s5lmrwUik3aDcfIA/FDLDZHWs6lJ2NpqG4nW9sguCRBe agDUfKKpGLGlw35kLFHpynsZBc0U/jxcPSQV9HGfXnK3br78BBJB5snTAqnhAOED+BG9 cYfddwWhfEM9ucA/MQSq6IC7eaLqPeTDX/upWlZKYdDUpyRm2DO2WWH4IFa2U9FFHJUx VJyZTahGGLF8lTG+3CodMlJOog9KxD203KDpSX6x4yiRuXVYMqvRVPJRfPk4NGClB56r AxFw== X-Gm-Message-State: AC+VfDzMxo5B4sJ/MfsjG5KHkctjo5Rav8kLhIZgP46RRFgVIIa/yCw5 VYu7naIChylw5E4tl6MJojQoMj9yjv6HRqaAzA2XaAsXt6UdlX2L6gKAlUMDQ7RPPXpwk9sC6yY QIie4h1W6HcY= X-Received: by 2002:a17:906:478f:b0:96f:aadb:bf81 with SMTP id cw15-20020a170906478f00b0096faadbbf81mr20890724ejc.45.1686847162691; Thu, 15 Jun 2023 09:39:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4HFzj8oji+QgifVAS8W5rrkeLVzDVniPUlQYTVJZN7par6lelAUrI2LEXLSV910896GtiXog== X-Received: by 2002:a17:906:478f:b0:96f:aadb:bf81 with SMTP id cw15-20020a170906478f00b0096faadbbf81mr20890694ejc.45.1686847162404; Thu, 15 Jun 2023 09:39:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:4b3f:de9c:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de9c:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id a13-20020a170906684d00b0096f7500502csm9582514ejs.199.2023.06.15.09.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 09:39:22 -0700 (PDT) Message-ID: <68cd25de-e767-725e-2e7b-703217230bb0@redhat.com> Date: Thu, 15 Jun 2023 18:39:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI To: Liam.Howlett@oracle.com Cc: airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230606223130.6132-1-dakr@redhat.com> From: Danilo Krummrich Organization: RedHat In-Reply-To: <20230606223130.6132-1-dakr@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: eq6rf5o1khu4xkcq4o7mcd4jesw3xbwr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 72B91180014 X-Rspam-User: X-HE-Tag: 1686847166-80527 X-HE-Meta: U2FsdGVkX18KbNQWzBisAwdbNSlzUw3in65Udi9zAAiAPsmM8D0lw2FdQcLqAAxyNRMi9oCNjt3JtZwOmE7VXraLDA5bA5rAtl6mGGD3nqcj9Yaba0Odl4aFnzB+awOo6CM5EBmYeCngQGTuJin6KXNRYjg9B3GyqfgbonrIQcpSnRkjVPsNXsuRZzqVLLNyhKOW/YxbInO3ri7+c7LPnaIXx4Y3zTb+QE8WpcrXVq5dBQyh+Y1g4v+zwjH08ab4pm7ipvfWsYhJw4l23JXOqsMuLZpdCaukzGZaHzTkWHNej6E3g4MnTNWIP+HMaY5Jd4NEB2RBR2cXZpO4MBxEETKVqZGfeuTT/JGARG0Oas+K5Cv/tf5QF4SPNtzNtv74EamRFwqYShrMy7Nk0c50H5Vt7XmzHwfP5iQVEQIsFYciQoA6u79RlPwb1YgvsO1cMNAb2dzqbDwTJNEOfHB5M5Hn7y5oXqBHcn2c1HVqy1JZCn3nl7cD5smFZHl7eMryt7Kkqzp7lCFifIUkqt1MtM9FVN58nYYymhxegZEteXIcU+v0XPvkVNoVBHp5RTmE2R4bTiDS7qjdFCvNtF42Jg61+/OxE1ZvvQSig275zFqLymi0VXkQ3Sfww6fxTH/LbjB/sIgwyz/RVropRoLkWiR1HCeqSub24bZEy3Hdo7ZVvhxZBFN/ehKmDwLq97su5Lc9kWxqbtP405NebsE3og3AcReJG9W7OCIQPlG/xotC7C7g6GCt+yvfokfKEtmGp66taznooD7CEsv5B2/pskMOPjlne0Z/deEGMAkSn/s5IgBTonSC6c3bhpdEjy1PSPAaJQah8rP9Dv8JGBFiGC7ekA1gy+PGOlml09bewDS3rKH8ivmYxpHfeQv3RUG99+9MNhIFb+jlm2laF8bxW22RksFC3bEnaXamTP/klGi0z0pJegNzVYp0RBz7myxNhfqMLfWfYs6lBMkrloj 3Cx8pEga 3U3fsEucQFp176hnkzmXY3VcQ/SX7SSRZ4t537kzu8pS2BFAkPxlw4ctFrJijDa+WQQNMt+/EQZUuusAUj2yY4/bewGLL6mMkXdS1qLos1h/MaRFBcsFT/qDQ8TuURaoenh1HalAj/T4Y0dNW7SWjf8heWZDBHlLjVFYHAcK8MHoeqKd6v7ztGGHFgRi++tbNvO27d7Gv5ICTrz/RruwDTf7gIHLoMlYyvA52FlsZ9ZaFmhlhxmcwfwZ5gy2ai1SoIl7eO6AkHI6vaMsEBNSKu2ShiFJqPYC/CBJM51/sJZyQpfGOA34MpyTJAPweDiSM4HZgEL6HGHKRjGpAtT1LqFHpWg+W0C1b5L11t3XKOlGHQqakedDXBiR3+Lq2wOMfP6cjooSfsTGvUbqmU5w7oiTF32ks9rfvYTLgqV6qXLBtCate1TR3Gw672rcH/9W8m2/cMypkGx72v4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/7/23 00:31, Danilo Krummrich wrote: > Maple Tree: > - Maple tree uses the 'unsinged long' type for node entries. While this > works for 64bit, it's incompatible with the DRM GPUVA Manager on 32bit, > since the DRM GPUVA Manager uses the u64 type and so do drivers using it. > While it's questionable whether a 32bit kernel and a > 32bit GPU address > space make any sense, it creates tons of compiler warnings when compiling > for 32bit. Maybe it makes sense to expand the maple tree API to let users > decide which size to pick - other ideas / proposals are welcome. I remember you told me that the filesystem folks had some interest in a 64-bit maple tree for a 32-bit kernel as well. Are there any news or plans for such a feature? For the short term I'd probably add a feature flag to the GPUVA manager, where drivers explicitly need to promise not to pass in addresses exceeding 32-bit on a 32-bit kernel, and if they don't refuse to initialize the GPUVA manager on 32-bit kernels - or something similar...