From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7C3C71136 for ; Wed, 11 Jun 2025 17:57:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 389606B0098; Wed, 11 Jun 2025 13:57:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 313196B009B; Wed, 11 Jun 2025 13:57:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B3CD6B009D; Wed, 11 Jun 2025 13:57:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED7536B0098 for ; Wed, 11 Jun 2025 13:57:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 36167161236 for ; Wed, 11 Jun 2025 17:57:50 +0000 (UTC) X-FDA: 83543877900.28.1AEAF4E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf27.hostedemail.com (Postfix) with ESMTP id BA4A340006 for ; Wed, 11 Jun 2025 17:57:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qGQAiysI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VcN2Kp0R; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qGQAiysI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VcN2Kp0R; dmarc=none; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749664668; a=rsa-sha256; cv=none; b=YrYGf0/nbj12Ii8b49ZqoB9A3EsgGX6rr0SKOKWcGNVA41dRPySpxNKGlS7sMW6jUkQ20z nvhC3cpJJGajmM971w/HiqWQukXCHKA35KyZQiK6ZrHlFm41EYukIAil4Q6FvMccxSdjMA DfssQTA1o3P++4DLzoQzlb0kbqG083Y= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qGQAiysI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VcN2Kp0R; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qGQAiysI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VcN2Kp0R; dmarc=none; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749664668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VhoXWW6F68B+fBMvoXJeILEJUgHeYVE8gaY+ZRAg9Ow=; b=wDOutyYtqjq0O+F0hnsBe/GvPclmosQACBPU1Ct42XC8gmCXq1bislR0QFxfHQfciScyNE wwnMf3LG+sVJhUyMIiFBbfzl+XSqzBiqtUrC1Hc1swmZo0e7MWo6EvR6+uENvRX+cBqHW2 PSZDAVBZPhOTTUt6Lot2xn9JI3zSuqk= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C4C2221921; Wed, 11 Jun 2025 17:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1749664665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VhoXWW6F68B+fBMvoXJeILEJUgHeYVE8gaY+ZRAg9Ow=; b=qGQAiysIR0GuooorxKARHF0/hcxq7HVD7uFvSuieZ7HmA1CHothZoN9UFCWxKcqhWw1Oxl 5m7b8rihF5c1Rb4gmXwzJ6eUD4rszXLShaFKwB/EnttlgYK6a6ZOxT3/3XTfEgTB0NRcLg ZAQ4NXt3R5QJvZeTy2tgiU/DcSbXbZ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1749664665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VhoXWW6F68B+fBMvoXJeILEJUgHeYVE8gaY+ZRAg9Ow=; b=VcN2Kp0RE+wYMuEwGlzTMbmzNze/CGmWtvovbbBG5RlfNvyuceoYZLTcE18lGTEvJ1NI2d dDRpx6MdA9ss4fDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1749664665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VhoXWW6F68B+fBMvoXJeILEJUgHeYVE8gaY+ZRAg9Ow=; b=qGQAiysIR0GuooorxKARHF0/hcxq7HVD7uFvSuieZ7HmA1CHothZoN9UFCWxKcqhWw1Oxl 5m7b8rihF5c1Rb4gmXwzJ6eUD4rszXLShaFKwB/EnttlgYK6a6ZOxT3/3XTfEgTB0NRcLg ZAQ4NXt3R5QJvZeTy2tgiU/DcSbXbZ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1749664665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VhoXWW6F68B+fBMvoXJeILEJUgHeYVE8gaY+ZRAg9Ow=; b=VcN2Kp0RE+wYMuEwGlzTMbmzNze/CGmWtvovbbBG5RlfNvyuceoYZLTcE18lGTEvJ1NI2d dDRpx6MdA9ss4fDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D2C4139CE; Wed, 11 Jun 2025 17:57:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jQTAJZnDSWhhIgAAD6G6ig (envelope-from ); Wed, 11 Jun 2025 17:57:45 +0000 Message-ID: <68c0649d-d9b3-44f4-9a92-7f72c51a5013@suse.cz> Date: Wed, 11 Jun 2025 19:57:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: locking/local_lock, mm: sparse warnings about shadowed variable Content-Language: en-US To: Charlemagne Lasse , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Alexei Starovoitov , Thomas Gleixner , Jakub Kicinski , "Peter Zijlstra (Intel)" , Davidlohr Bueso , LKML , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-rt-devel@lists.linux.dev References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: pwqnowhtftyod1c7esp5sewt8gyo8yqi X-Rspamd-Queue-Id: BA4A340006 X-Rspam-User: X-HE-Tag: 1749664667-33955 X-HE-Meta: U2FsdGVkX1/0jSihXUiNmc5K45Yalr5l3NQId1MISiH9GfZO4LkwLfFqF/+SOLRbAd+Uu49PBUdRGKmU5vbtOi/2dLPs3Sdj1t59SWY4/+eCtm/Tex7Op2NRBs/zRROI45CQmTm6qqE+xjylazG39GNphfM/In38MEqw4wTT1VyFg1vDm4o4rj7FXvipb+Mptl5wgOfco9ow6sxh3CqfJuDulWk5G4A5SyHJc56DciTLQvDP+8n6Ph9yRA+Y4hjBpxyRD5oYnrGXT5s/T4pddmRciOdq9CmENHb/TVEvGyowzi39uNxFAyCGUVW7Lm638UMp6rcbToiV7zn8VjHaQ3uInAL6RWtQIxjIpH1I3IvPMCsuiU/nOjude35nj99IMwU1ytS0bLv0PZ9xK/wIrLye/rs1/9IB3OQeP4x5CY2snu0mTx86YDWtqfRfbbelA+Qvcor5XbD4fr6vyX91y1JYV2cqgDkFMeb1gfBIbM8bsgRlw3fSU4/GVY1YU3qKgjmA93P/opNpeEKzxSP7cCyhwUXOoreEf2hSkti5YDmMx19Uuv+QPYd/+6gf14b/RBE0h3xTV6DTcmU4gWFVqnEMcPQhKdEfgbhmhqvDp+f3fAck92hiahdmD3HWdiDvnyhBTdQPVI1EVhK3c4i/yAca3ANI6XJ4uUzslGnR4dUxrmq09GQff7S1v1DqrE7O2pczXrOzpyX6wsPW2AJ7PETr+6VLcTWBsOdtfLuKK8/B5/SdaYcxGsoyvjTYTK/2mu35kCI1ZJ+YrDr2+6F5QZKhB2qB8IeaD2rfD3q9fbN1GzzbTmd+NP3x0sKcTOoB1UqcVRibr1+4lQsGD3VBSdP/Wkf8sv17pvFGT1QkiHb1SXuk8B53E2yiNV5flnVnD8yAmaJnwZG6TDEL4QCE+KzuDHSSvhtaKbgVKhLvD5P/8B0cWuIlp4cn06oJ9NfTu1bqt2B8oXNnSalGSMo 6FQqjpAr CeHqAcXOvBQKUAyXbY7Bf1ldYYFoRghDhHwId7LoSnTU8uMWYvZuY11C0Yo907Zjl6CcoFQD/MkHpt2284k4S4efJVlS7OiCKdeZPi9FidIXvAm7Myq9gDMoJhwZqanYVp/v9KrzHWoHE+QZiRq5bhW5tIt1fwl+BYW+K3qvioAz3KTZsYPv5/wzGY4mCQJSBGjNRdZtJ5NFlN6lNBHN+7bdNhb/9rdosJz78dTmsUeTpAGQirYdgdgS8BJ7t6vPctWT7G/bFPfmbm82b2O2a7R7VOVI1oqRrw4WSTb7A+k9r1Qy7+sVxiw0pK7sKU8YMnyV6GLjyj7a5atgQlPOUR8ElOFqVYCfwxrmUzcjcXqRcL5w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/11/25 19:37, Charlemagne Lasse wrote: > HI, > > when I run `make C=2 mm/mlock.o CHECK="sparse -Wshadow"`, I get a lot of > > ./include/linux/local_lock.h:88:1: warning: symbol 'l' shadows an earlier one > ./include/linux/local_lock.h:88:1: originally declared here > > after commit > > 51339d99c0131bc0d16d378e9b05bc498d2967e2 is the first bad commit > commit 51339d99c0131bc0d16d378e9b05bc498d2967e2 > Author: Alexei Starovoitov > Date: 2025-04-02 19:55:14 -0700 > > locking/local_lock, mm: replace localtry_ helpers with local_trylock_t type Looks like __DEFINE_LOCK_GUARD_1() has "_type *l" and __local_lock_acquire() has "local_lock_t *l;". It can be fixed e.g. like this, although it's harmless? The _release() part is not necessary, just for symmetry. diff --git a/include/linux/local_lock_internal.h b/include/linux/local_lock_internal.h index 8d5ac16a9b17..075338f270d0 100644 --- a/include/linux/local_lock_internal.h +++ b/include/linux/local_lock_internal.h @@ -97,17 +97,17 @@ do { \ #define __local_lock_acquire(lock) \ do { \ local_trylock_t *tl; \ - local_lock_t *l; \ + local_lock_t *ll; \ \ - l = (local_lock_t *)this_cpu_ptr(lock); \ - tl = (local_trylock_t *)l; \ + ll = (local_lock_t *)this_cpu_ptr(lock); \ + tl = (local_trylock_t *)ll; \ _Generic((lock), \ __percpu local_trylock_t *: ({ \ lockdep_assert(tl->acquired == 0); \ WRITE_ONCE(tl->acquired, 1); \ }), \ __percpu local_lock_t *: (void)0); \ - local_lock_acquire(l); \ + local_lock_acquire(ll); \ } while (0) #define __local_lock(lock) \ @@ -165,11 +165,11 @@ do { \ #define __local_lock_release(lock) \ do { \ local_trylock_t *tl; \ - local_lock_t *l; \ + local_lock_t *ll; \ \ - l = (local_lock_t *)this_cpu_ptr(lock); \ - tl = (local_trylock_t *)l; \ - local_lock_release(l); \ + ll = (local_lock_t *)this_cpu_ptr(lock); \ + tl = (local_trylock_t *)ll; \ + local_lock_release(ll); \ _Generic((lock), \ __percpu local_trylock_t *: ({ \ lockdep_assert(tl->acquired == 1); \