From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEA6CE7AE0 for ; Fri, 6 Sep 2024 08:10:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 113B56B0092; Fri, 6 Sep 2024 04:10:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C3C56B0093; Fri, 6 Sep 2024 04:10:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECDE66B0095; Fri, 6 Sep 2024 04:10:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF7056B0092 for ; Fri, 6 Sep 2024 04:10:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6F09B12106D for ; Fri, 6 Sep 2024 08:10:54 +0000 (UTC) X-FDA: 82533592428.22.142ACC8 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf02.hostedemail.com (Postfix) with ESMTP id 2D1E38000C for ; Fri, 6 Sep 2024 08:10:50 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725610202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bi90WpWtp0Hud4WU3DVdAAAeYm4lCfp7/QrCA0W4l1Y=; b=M+Jo1bXKz5EWN2PxkRoS/b53jfH/SsL+gsu+igNJvs+kaaCCxipZ4wnIEeIk8BD3ps5Hrp 6g538d+4Vhh6cI3tm3yttAiVKPIYh739sJow604SnONkE6qHRrzwKJ24nc0lMPIp7itMZI zsu7rBpFcfpv5tIqJhogXmt9JswLUDM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725610202; a=rsa-sha256; cv=none; b=ZbxWeP+VaSoZ/qZ1OwjRwUwZG3QTkbed0pEWJICW8xu/WKS4wjpyzxJln00Ylq9Qh/VmC/ lPxwMOjULxw6ujFMvQrUYtC0Pe5Ojp4hMeCS+T87LsezU4JnZvvagnMXF/+TLWWS5ShHIr Hm7b3GqmugAQjlTu2UPuxBdU5Ykc5TU= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4X0TPy4nbMzfbjV; Fri, 6 Sep 2024 16:08:38 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id C0E3C1800D1; Fri, 6 Sep 2024 16:10:46 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 6 Sep 2024 16:10:46 +0800 Message-ID: <68b86f66-cd00-bb7d-b8bb-5a94e8dd1ea2@huawei.com> Date: Fri, 6 Sep 2024 16:10:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v4 3/3] mm/slub: Fix memory leak of kobj->name in sysfs_slab_add() Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> CC: Liu Shixin , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , , References: <20221112114602.1268989-1-liushixin2@huawei.com> <20221112114602.1268989-4-liushixin2@huawei.com> <3780a622-03f2-4cfe-5705-0e9d0be61d57@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2D1E38000C X-Stat-Signature: wb9fijjzzbzwz1n8us6ntmy6misrt5yq X-HE-Tag: 1725610250-966224 X-HE-Meta: U2FsdGVkX19uO0ibku53pLrx4fM4MM/ZOfUoyNNmHL++Z1SWQ1shZ2csDZgUFa7BzACNMQmcAgQAP+dEdGgIqLKT13D6DlACZSriwK3Nfvxoe3pzDaRH5IV+/HemCYKo1Caj5K3iBK4vKR5NTEZk/2Y+ACi9SyWUl7qBMXzRB8Thsr79i4aZXGOJk8y4QHVUoDLsKbTJlPth/tAKjRxJ6zT2z0YdNM9QF0rFHhn5WHkMT5QJK3Hbbgwr95ekkj9WZ/LAdX7mGlo8OHIkQz/NgLy3yItjdMZezUeKk5XZ2pJcGG8fh63LCNeHnfPdL9q3rXM7Vrc+3RtMVhH6Gmi5+iQE2G+ns5djPloV7TegC/Hs3Gk1Smc1bsXSul8NRpr6NFtACizSP4TZOn8X/w4iIPjfkE73WKUTvxch8QYSw0qdZDWdco+Pyue2JAO1bisKL+oFi2nFDaj7LsLgkU9UGCyNp7mSHUE/XiJprgM8+nFV5lsFVsasz2yGb1Ma9lel3RGC/tTRB8kCyrCPae2KV4sc5cCELaE1PgWVii4kwSbUba9BTb+uvKt3wFxBSyeRVkN3Z1LPaJDTjilFUDZE9C7tgF6cFbkWtuxpO/XfGRsYhKJ9Oo4SeG4mYGPrB+mU0ewPrJDMSCfS6lGImNnDLjiEvtnXDJJ9Qlohkx5WExIdgiEqymZZyl2WLWyQEwtmTXTZ2v4qCM5EEQYZNbkyWHRStUBnvkSjNh0n3wUqdJ+uhbXIwM5NC5UJt+iNShzKMIYa/7aSdlAEDuTDpIm9MAGDZqCqWLXYMkRStGI3gGxXfjd9NxCgqEEUHz0M19Hx9sCpepKNMgwF1O4qe9o0+kYnUSgryFGfIrj7GpfSbXhiDmZAtL0JiK+69FqhHUmdfng6kybpXubajPMdwDAWu8HkPA+gqPrJfwrIQ+phwoiW9HDzaRZrxdjhUCTC/NfgEaF+IjMoOCpxkFDbWSh MNaTvoQi KRvlZJLzLzSlJY4A2pLctwqrESl9KjoWXmnwT5f+y2XaV2rSkzR7yeaZzhcygkLlP8WlbA6WNpt9cM4sZ8c+ipVLrC9iTZI0pTAxTtata+JJOmcO+OnS+KD+pELG0ELS//A/QyEw3X5ioSfre2YLLClE928ZiY0BS7aWuwog1kl3kqSsrVZsEq6Ym7IGrGofkLv80KISrQFvEsioSYD2KbLHilXgUQJhtsyx+ABpT1LXs3UDLbf0PlrhLafqJuZQfQA3u4cL/y394Wqfj6ZeNG964kTZpeI3AsaSvt5oDQyCuKH0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/5 21:59, Hyeonggon Yoo wrote: > On Thu, Sep 5, 2024 at 12:41 PM Jinjie Ruan wrote: >> >> >> >> On 2022/11/12 19:46, Liu Shixin wrote: >>> There is a memory leak of kobj->name in sysfs_slab_add(): >>> >>> unreferenced object 0xffff88817e446440 (size 32): >>> comm "insmod", pid 4085, jiffies 4296564501 (age 126.272s) >>> hex dump (first 32 bytes): >>> 75 62 69 66 73 5f 69 6e 6f 64 65 5f 73 6c 61 62 ubifs_inode_slab >>> 00 65 44 7e 81 88 ff ff 00 00 00 00 00 00 00 00 .eD~............ >>> backtrace: >>> [<000000005b30fbbd>] __kmalloc_node_track_caller+0x4e/0x150 >>> [<000000002f70da0c>] kstrdup_const+0x4b/0x80 >>> [<00000000c6712c61>] kobject_set_name_vargs+0x2f/0xb0 >>> [<00000000b151218e>] kobject_init_and_add+0xb0/0x120 >>> [<00000000e56a4cf5>] sysfs_slab_add+0x17d/0x220 >>> [<000000009326fd57>] __kmem_cache_create+0x406/0x590 >>> [<00000000dde33cff>] kmem_cache_create_usercopy+0x1fc/0x300 >>> [<00000000fe90cedb>] kmem_cache_create+0x12/0x20 >>> [<000000007a6531c8>] 0xffffffffa02d802d >>> [<000000000e3b13c7>] do_one_initcall+0x87/0x2a0 >>> [<00000000995ecdcf>] do_init_module+0xdf/0x320 >>> [<000000008821941f>] load_module+0x2f98/0x3330 >>> [<00000000ef51efa4>] __do_sys_finit_module+0x113/0x1b0 >>> [<000000009339fbce>] do_syscall_64+0x35/0x80 >>> [<000000006b7f2033>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 >> >> >> Hi，every one, > > Hi. > >> I found the same problem and it solve this problem with the patch, is >> there any plan to update the patch and solve it. > > What kernel version do you use, 6.11.0-rc6 > and when do you encounter it or how do you reproduce it? Hi, Hyeonggon, Thank you, I encounter it when doing inject fault test while modprobe amdgpu.ko. > > -- > Hyeonggon