From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2722DE7716C for ; Thu, 5 Dec 2024 06:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6B196B0088; Thu, 5 Dec 2024 01:50:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F2A46B008A; Thu, 5 Dec 2024 01:50:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 893026B008C; Thu, 5 Dec 2024 01:50:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 68CA86B0088 for ; Thu, 5 Dec 2024 01:50:25 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 10748A13DB for ; Thu, 5 Dec 2024 06:50:25 +0000 (UTC) X-FDA: 82859980896.08.1A87C8E Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf05.hostedemail.com (Postfix) with ESMTP id A9621100003 for ; Thu, 5 Dec 2024 06:49:52 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ik4AdqZH; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733381411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T6mHsMiu1ngXUZZ8XsIizZ75Pq7HYldFMfXbIXzmoWQ=; b=60+Mt0izXS14L5HkqyxjHssU99/wnH+MZzfiKm4dmgR9ChblcQQEBkEXVnT9mIcq4zlAXd ANyUwJWT5jJViN8aaF77RkqwRsziBhkTuoV1KnyRpZiOZt1tnGOOjZqpMGK346D2UnCIGM Br3nwBpNa5i7IFcz/SXbtn/llRcQv/w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ik4AdqZH; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733381411; a=rsa-sha256; cv=none; b=4rSCV5Wk4kJ3XJP805WmPqLLE2Yt4wFptOMaMrTfaq0ZnMpI20od/UWVdOPCzAHDf8BwJ1 SkwzcZhhzo8Bc1SwCWfijCrI/+xz0RJRAvXE0yUxO944bgbDVcMAAz+4SGP2zf8ebsXAjD PnYxoVVxHGuJTluYCc5pNaU3BId0ylc= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1733381417; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=T6mHsMiu1ngXUZZ8XsIizZ75Pq7HYldFMfXbIXzmoWQ=; b=ik4AdqZH8dPfq85caazESQWW1QnSrqN2l9Eq/c4kAjCv/40LFXg129NbnY7ZKvJdwJVO2ztDzQKIdJDlJelDZZF6jpCmOQVpUkYMzI35Ya2YkFRhux0v5uCvK/8cbDzFqlaU07auGxlozYMu0412n+jNedpiUo4uyT9RpFrkN+o= Received: from 30.74.144.118(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WKsFV69_1733381415 cluster:ay36) by smtp.aliyun-inc.com; Thu, 05 Dec 2024 14:50:16 +0800 Message-ID: <6896a7ab-b6f6-4b2f-944a-c1c3f731bead@linux.alibaba.com> Date: Thu, 5 Dec 2024 14:50:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: migrate: drop redundant anonymous statistics for file folios migration To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <48fe508d-ecb9-4607-aab6-cc18b4bc78e9@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A9621100003 X-Rspamd-Server: rspam12 X-Stat-Signature: u5u1oxn3k94smwu65m1rgpgbirrwfunt X-Rspam-User: X-HE-Tag: 1733381392-477781 X-HE-Meta: U2FsdGVkX18XqUvz3bMTcGlHR6/OyeD1gzjELIaCjNERJGaPTh8G/Qa27MC1oyIrByEIjqk+Jvh/QzeGGcaOb2dZUa4IOQ8Gpk0jyq6MBB6tYBETd/I9wPwTnfappCwE9pO0MCLbE/O14LtCk4P/cdQkSFIAaD5W7+9R2gmdo0/awTGK2cA8BDeye3hFkrBg/t4/pNvscaz/KyJimUH9Q1AH9r5cRL0o8NIHyh+O0dcrjfqz5XGYU9n6Q8DtfiscBS/SwpGN/iqqZhhaxu5c5+fWmYVyWEzt5FIwfb0WO9bUxtNn2WqVPFuRxo5gB78sGZkNG4MagK+IKliHs8p3RXWTBlAev1H26dPSNM3TTE4Pw5vwdi5IJ9QkVVqdERogwuMNKYYUu4D0wamWGQONQ8CeMPL8zH6rJlHFGli/VbIjY8Kay3OcTiBVZqDe8AOhs2euqrgSI9myAGebAZmqMUqffjbkfa/efkZqOgsc+jWj0HcH3t8NGmP+Su6c5h3kRrV8C/qDhH8KNSGz2gJRB1jBP3BAK90mH+tOpdwH+cAZc9YWuvGfqfO4jnykdHNCTjlVtTWZ3rcifeDzm/bbJmR2ivYfXAbW2hXCIoGAC35S6H6eVzR0jowqZRBU27K9gEbYJ1xwzWYnopYnYtN9LsPXFJvBLW8FdQfmHSwghIF6C/Wz3E2R9F1gounyg6LwJ3x/aeChxY7a0XqE5RWN2PFyXpmBFnCSwhD+/OMdSY80aJ4zK5rk8j1GmvOdvcE4XicYx1bqzmxkWNmnaS1kv9ex2uThR3ilf/wimN3MHVzPdw19njdzf42uGjJeR6CfTLJIW5Ed5isKW+JPWxh2Q2GWCr5Paz2aBR+ShS2AgbI2esr4DceSzZQQI10Y+FyrRf3UY5Fmd6NzE5Rn8U8O3RgtkgJkSHhxVUrEv+/Ke7ubMDmFM1JbDUCTq5wtvblVnl57dblK4j0p20UCc63 VcQcAFdl /KQvjknGjKRN/hb+fRpUqEvOixR9+1Cte0lAnsowGxg/YqfF2m+7AVR8xvqgW8dyEo/Ey4N3tcPyw5o8M/nPrdiVJePnNGQwpY9qJpGLjiFamFX8VsGhZe6hOYjr1BuLT2xMMEeCCo/KvwdSHDTR54Vh52A1oIjgXsBCT4n/dOKyhidJ8CNttWwutw9+0JPk5k9mLYOtAvXoX1NoEGXrcyPbD3KcSA6FjU7n+6QwVQdOPyOZdYg+s1BXm2D9wEPCXdUivkJow7+K057vjXFGHvqaweKvMjy4K+W34Wn8hVQ0vD18= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/5 14:33, Barry Song wrote: > On Thu, Dec 5, 2024 at 7:06 PM Baolin Wang > wrote: >> >> >> >> On 2024/12/5 13:00, Barry Song wrote: >>> On Thu, Dec 5, 2024 at 4:54 PM Baolin Wang >>> wrote: >>>> >>>> Commit 5d65c8d758f2 ("mm: count the number of anonymous THPs per size") adds >>>> a new anonymous counter per THP size, however, when folio_mapping() is not NULL >>>> during folio migration, it means this is not an anonymous folio, so remove the >>>> redundant anonymous statistics in this case. >>> >>> why? Are you sure anon folios won't call __folio_migrate_mapping()? >>> folio->mapping is PAGE_MAPPING_ANON for anon folios. >>> >>> static __always_inline bool folio_test_anon(const struct folio *folio) >>> { >>> return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != 0; >>> } >> >> Ah, sorry for noise. This just caught my eyes when reading the code, and >> I did not think about it deeply before sending a quick patch. Thanks to >> Barry and Ying for the reminder. > > No worries. I recall encountering a negative count during the development of > the original patch and eventually realizing it was due to forgetting > to increment > the migrated anon folios. Your patch seems to reintroduce the bug I encountered > back then :-) Right. I was blind and need a cup of coffee:)