From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BE3C54E65 for ; Thu, 22 May 2025 12:04:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1862A6B0085; Thu, 22 May 2025 08:04:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 136AF6B0092; Thu, 22 May 2025 08:04:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F40D66B0093; Thu, 22 May 2025 08:04:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D396F6B0085 for ; Thu, 22 May 2025 08:04:27 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7C6FD1411DE for ; Thu, 22 May 2025 12:04:27 +0000 (UTC) X-FDA: 83470411374.16.71C0EF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id EB45580004 for ; Thu, 22 May 2025 12:04:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YPe3DAwi; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747915465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SE1l7LwOJdzhSNTpk1qJSyj60i+zwkLVGGrsHxlqMck=; b=nQHtcOCc3OROfmGLt/NIqcGawW7Zl2vFDYhTLmHY3c8CVCfYloer73s+7HV+zvSXtPGC56 vICbfRdeM8W0dPxFUzghR4okHC3fsYvk4DKOdclJQWQrP5a5qMg0pvcFn1z/1U/MP7NM1F rOU6GeGXFnn0xZl9xuftxZbJiqMeE/4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YPe3DAwi; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747915465; a=rsa-sha256; cv=none; b=T1FE1bglnYJIcwj8Nmt4Gr+fM/H9lUkZlAZqficaex6ZVoaHUJHxf3ZDGI6yNTHDXzJixH ly+VQZiBhWq3IfQZBhsadJM20tpJgvqtrunzKj98XFT+RGw/F0yYVp8/00pRYPwaSL7Zjr 5KMS/E0a4viKhqwRryq1orACa7F7HqM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747915464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SE1l7LwOJdzhSNTpk1qJSyj60i+zwkLVGGrsHxlqMck=; b=YPe3DAwigoGffLDS4GiL/TLKBfnhp/Yjde/tMppnZGAMT5XchVwQrYDGNsXjbTvBu5NeWG sfOEXXCESEiKyN74G/TrFJPhbjVMrxg0cbwbFEKN79OK8oJtNFqflXr0T7i/1C0ymfUCTx 13wdN5/yUhvyDBeMbrPJjEsog48Qf/Y= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-iTVHsohVOtCtLreStukCQQ-1; Thu, 22 May 2025 08:04:23 -0400 X-MC-Unique: iTVHsohVOtCtLreStukCQQ-1 X-Mimecast-MFC-AGG-ID: iTVHsohVOtCtLreStukCQQ_1747915462 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-442d472cf7fso61009675e9.3 for ; Thu, 22 May 2025 05:04:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747915462; x=1748520262; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SE1l7LwOJdzhSNTpk1qJSyj60i+zwkLVGGrsHxlqMck=; b=vJI63Z/d7nzK03fHiGftFE74gkkIIsTXV16YfzlwigpryRn+fYTny9nmSdE/H2gr3o bfkj3KwOmgr4mqyhc/9xK9hcqva5uReVKEx4X5pwn8gykmBQyvJngnZyoj//lSyokiIQ AE5mH2OSujZe2Ilg8EDHdxlxtH3Pffq8kFMZrWpWlaEvWfrKByDTdrd3hxXh8QM2spm4 qg/lCNochmsoRmmnb4SuUhU+XaNNor92txjt7p2jkxtIC+DJXi/LvAJuu+E+rwntmPRq +YsWzzvxhk+UUOxDVREHvf4768Bd+e3nqapT2ysVKRz8MnvLKR84YVf2/Ly7IyU9zQN6 oCew== X-Forwarded-Encrypted: i=1; AJvYcCV9DjQirP9AZ1GvruEpDI55TuXS3cVwVa9AscbJpyXZVHi/WwUIEDkasKbWpxsymrVxLF3hocC2iA==@kvack.org X-Gm-Message-State: AOJu0Yw9DzCIySrvffLZi9eIZ/su2/9isZdyOgv40bswliNf/ewkipOu TYVyDv9ly8JV8rgJXrZgjM+THC5szFq6ZhthgfNXJI1kalxHZxcT7nCDxUzqvy62Wh39IgTK7Ce MhULnqh1mahLGqtELVbZT2g9vmzIWBa/Om8BdyZYb9c6IVKxftdj9 X-Gm-Gg: ASbGncsao1oN7PCgn7SXQFkF6FjZDbVzEqwkC+IVYMlRibgya3kWfpidU1Z8OeRZOFk urAG7jOKkiyov/hvK0qX3n2zg5Elzm/j4VXeijCV2ln9amUdE/3FrDo0fOg57rT5UW0JgzSy8Bq kJUO9WHdQqHLGlIJFVyHCuTmaGiLJ63MjHtXflzkklqMMJvdxGGiKS4osZKuRlvFfuGNlNq1Xub B1N6YopZTg/sMvY8BJuY2qyXesaqfb120XKI1aGk5sp22rMn7gRLcB4qAMnoLcBQZMY4e38OBcJ ckcVKCETUFDFHxVg7fPABlPWEkqu5IF7fJrsF+n1jiI+FvAOBRtdTcEXmCIRv7pCjYhWLewAPPO IEfeGluANGhm0kfqvd1wRyIIb9H+hyQKNzzpEn7Y= X-Received: by 2002:a05:600c:6748:b0:442:e011:7eb with SMTP id 5b1f17b1804b1-442fd671befmr283747165e9.30.1747915461987; Thu, 22 May 2025 05:04:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBeNOf9p7XQMEo661VsP3lNb83xqKoazNsruCMHoqOB07PdLk122+DzoLdl3opzWhYkLxpDg== X-Received: by 2002:a05:600c:6748:b0:442:e011:7eb with SMTP id 5b1f17b1804b1-442fd671befmr283746665e9.30.1747915461561; Thu, 22 May 2025 05:04:21 -0700 (PDT) Received: from ?IPV6:2003:d8:2f22:2e00:6e71:238a:de9f:e396? (p200300d82f222e006e71238ade9fe396.dip0.t-ipconnect.de. [2003:d8:2f22:2e00:6e71:238a:de9f:e396]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f24b6471sm103717145e9.24.2025.05.22.05.04.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 05:04:21 -0700 (PDT) Message-ID: <6894a8b1-a1a7-4a35-8193-68df3340f0ad@redhat.com> Date: Thu, 22 May 2025 14:04:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 0/2] add THP_HUGE_ZERO_PAGE_ALWAYS config option To: "Pankaj Raghav (Samsung)" , Mike Rapoport Cc: Pankaj Raghav , Suren Baghdasaryan , Vlastimil Babka , Ryan Roberts , Michal Hocko , Thomas Gleixner , Nico Pache , Dev Jain , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Zi Yan , Dave Hansen , Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , gost.dev@samsung.com, hch@lst.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, x86@kernel.org, mcgrof@kernel.org References: <20250522090243.758943-1-p.raghav@samsung.com> <6lhepdol4nlnht7elb7jx7ot5hhckiegyyl6zeap2hmltdwb5t@ywsaklwnakuh> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6lhepdol4nlnht7elb7jx7ot5hhckiegyyl6zeap2hmltdwb5t@ywsaklwnakuh> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rfqvT2UbTydbDVN7iBEUIKspimz7MQpXE2GtzKSuzuI_1747915462 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EB45580004 X-Stat-Signature: gwbg3og5wybqbtwayzguqts4x6b8u71h X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1747915464-74373 X-HE-Meta: U2FsdGVkX18rVKsXPBelmYGU3BEWnk9f09HwcZBmnK1042/SMmiBMY+2k8FlUtCtmJjYnkuYVDsdC7ZnqHgJMv6zqY/PUGoWbJqCKWTWze7f5vsbv4hALQg83KEl0qh2OAJrbKHAzoTxeB8RTMxS5x0TVUp1V8bHwDrE9hx3GO4uZZHCfnUcFJaFw934xW7ZkmmfUthV0GBHcbvCTV70dmauApEZjkgtbdanhwF3fVShaJMrRkTRWQ3tL6TRuYySBJXe82lJ7nrScu1Wkph23pBcf5uFhMKpPAqVP2j0cnwCX8E5WxJ9ykOLD7bH/M21Nhi9Y5SeIgKde8Pdn3V4IN1FsEi2js3UEolrZOgSucgMfosgYTy7L+V7Qz0gIWTa2ys+QHsaWNBgV1UQCjFmlmklFNg7x3+BN3GSKd/FcrqRDIyKpIQUH/6rGPy50hd+wnCq4Hwjwi8088N/7mmvSXzs6XyGlFx47Hn9qiZ9Q2RwiXPH2GBmEv+4hp/0H1kfgCrBATVseoqgY+TXO35IN/NY0aFXAwMHndR1BosVbYZjxWbjdATkPuGrsDDDzuwFXB/OaancHxIEOYSvGnqWR7KbW7iyEFcrmiYCh23/aSQ9ieCUpxf/+kTzdAR6RLljHquI5kpkcuDibWC6ndXafhTqvYiP1CfJiBRqZo3YGAS1stElxVGHah7R4gpcKlfoVik6uDvIx9E5k5m8flZqpkQxWXDjmPn66BJT7mkazjhwwcowWZHh1V81XKcPjCAP1OgvMkF1F1ufkuYQzzfmJpX4pRF5UyY4a4DIj01cTF8RFrrk1WNwMLwn4vfVNiWSOMPjLKrNsu60C+H1M0uMTmv6RWqsLOEz9jlL/QsTBJAKF4FGTzid5qHWkNMBy0yk3VALF3xTdCQbjh+t0c4WRZ2VkhIO8ET36YrGhJorNkMKVp+yYCNPYsPAAUaDcGamjJ1Yqmakxb9/8Jz7G3u ZjxfuvxH /N8ulvLlJNy/Tkz/PtFhk3fJxRmilWQhN52zlL2M1w205+GKREbW08OXcQxoNWyNIHTx/NBn6NlHrERov3vmVko538teIwzc9g+eRNSiWlIQkASwvsRFMswcxz3ixesltk0kq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.05.25 14:00, Pankaj Raghav (Samsung) wrote: > Hi Mike, > >>> Add a config option THP_HUGE_ZERO_PAGE_ALWAYS that will always allocate >>> the huge_zero_folio, and it will never be freed. This makes using the >>> huge_zero_folio without having to pass any mm struct and a call to put_folio >>> in the destructor. >> >> I don't think this config option should be tied to THP. It's perfectly >> sensible to have a configuration with HUGETLB and without THP. >> > > Hmm, that makes sense. You mean something like this (untested): > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 2e1527580746..d447a9b9eb7d 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -151,8 +151,8 @@ config X86 > select ARCH_WANT_OPTIMIZE_DAX_VMEMMAP if X86_64 > select ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP if X86_64 > select ARCH_WANT_HUGETLB_VMEMMAP_PREINIT if X86_64 > + select ARCH_WANTS_HUGE_ZERO_PAGE_ALWAYS if X86_64 > select ARCH_WANTS_THP_SWAP if X86_64 > - select ARCH_WANTS_THP_ZERO_PAGE_ALWAYS if X86_64 > select ARCH_HAS_PARANOID_L1D_FLUSH > select BUILDTIME_TABLE_SORT > select CLKEVT_I8253 > diff --git a/mm/Kconfig b/mm/Kconfig > index a2994e7d55ba..83a5b95a2286 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -823,9 +823,19 @@ config ARCH_WANT_GENERAL_HUGETLB > config ARCH_WANTS_THP_SWAP > def_bool n > > -config ARCH_WANTS_THP_ZERO_PAGE_ALWAYS > +config ARCH_WANTS_HUGE_ZERO_PAGE_ALWAYS > def_bool n > > +config HUGE_ZERO_PAGE_ALWAYS Likely something like PMD_ZERO_PAGE Will be a lot clearer. > + def_bool y> + depends on HUGETLB_PAGE && ARCH_WANTS_HUGE_ZERO_PAGE_ALWAYS I suspect it should then also be independent of HUGETLB_PAGE? > + help > + Typically huge_zero_folio, which is a huge page of zeroes, is allocated > + on demand and deallocated when not in use. This option will always > + allocate huge_zero_folio for zeroing and it is never deallocated. > + Not suitable for memory constrained systems. I assume that code then has to live in mm/memory.c ? -- Cheers, David / dhildenb