From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD504C432C0 for ; Thu, 28 Nov 2019 15:29:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9CA5821787 for ; Thu, 28 Nov 2019 15:29:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="RiROsxoQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CA5821787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 391926B0547; Thu, 28 Nov 2019 10:29:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 342516B0548; Thu, 28 Nov 2019 10:29:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 232F16B0549; Thu, 28 Nov 2019 10:29:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 0BCB46B0547 for ; Thu, 28 Nov 2019 10:29:27 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id C00B4824999B for ; Thu, 28 Nov 2019 15:29:26 +0000 (UTC) X-FDA: 76206070332.23.pot13_8ca2a49ba902e X-HE-Tag: pot13_8ca2a49ba902e X-Filterd-Recvd-Size: 4239 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 15:29:26 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id d124so7848750qke.6 for ; Thu, 28 Nov 2019 07:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=o25gVTM3POIQu+gqgts69ZSJpER0xLxj/NptxHj1lGY=; b=RiROsxoQeTjFzPUjV2tSMBSlHoWH14G7MKaat8rAiHMEsMRQ6uHJWEZko66S5ZLYRR D8Rgaa/jk1lC/LpAQ+SqVl8oJv9NPtAb6ozlqx1+a5x0sdEtQRpGPeMi5f3y7SrbXXlV z9r/FfReU/k8ZaRBkh7jPNkTQPnCMD7cqmCoU1AxOX/3vE7MVg2yLblVUuPH95n1ayTG seWpwnF2SGi+e1nrNnosoaZEwNXgOWc7m1vhr7PgcACk8jrd+ANE6nb3s0oRFh9FrKsd N3C7AGSTPrAFbVlDWwJeuVA2mkHWEayVnRtWl/NmvtZmaGadHPfrWkawv+zLC7SK3c5o 5aTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=o25gVTM3POIQu+gqgts69ZSJpER0xLxj/NptxHj1lGY=; b=BDAtEuyHi7nmHTqDf+3LGOWSL3RBkfbJCxrYaq5sPBkoHKeQ2ykLSRt7oDZVMAccQh k3pR3+skGesMnJQ7n3MpvCJzoJvclJOJaAkgNz15OFgprRESsaEgQ2+U3fuZagpi3soL alTpg26xu+s5ZA6kp01klLdbhCeQd/dtfLatOdCLc9x52vwpX2EU/Fw6XjRrZNA6imwm 1A1N6Om4AfAVlAZt/YFdzyhVUDjzgWGlty4MGGZ6AB5MqBEgjca9Qm6VFHM2mNVE+L5q pq9ZKI14zmcDLGZnihGEk4H9DSAGgKPCxS022HNA/06Z6Y7Du3hAzFFx6Tv4EyLiUiFV mZMg== X-Gm-Message-State: APjAAAXuDKLscTmOHJw/eWVrriutOA2ajc34va8t/MpQxonBK6Tws+YN DUK2eyUrqYCJjIRgQW8pXhPCwdbm0EZppA== X-Google-Smtp-Source: APXvYqw1pdKo9iQXakvY4/z67dTdEia642ja75qtt6+Zp2jRCx47LSMi11S8cgfmAeOTImpKbpXPfg== X-Received: by 2002:a37:9fc9:: with SMTP id i192mr7687196qke.364.1574954965256; Thu, 28 Nov 2019 07:29:25 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id u4sm4055273qkh.59.2019.11.28.07.29.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2019 07:29:24 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn Date: Thu, 28 Nov 2019 10:29:24 -0500 Message-Id: <687DAE43-C40F-4527-876D-CAC750D150B6@lca.pw> References: Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Oscar Salvador In-Reply-To: To: David Hildenbrand X-Mailer: iPhone Mail (17A878) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Nov 28, 2019, at 9:52 AM, David Hildenbrand wrote: >=20 > I also agree that it should not be used for basic functional/compile > tests (I said "It is a way of giving patches *more* testing."). It > should not be the only place to test stuff (especially to let somebody > else do it). >=20 > However, sometimes we really have to get additional test coverage via > linux-next, especially for weird archs/configurations/setups. >=20 > ... and if we don't have enough reviewers, it's really hard to get stuff > upstream. >=20 > I wish MM patches would get reviewed more thoroughly. >=20 > (If we all make a wish, maybe Santa Clause will listen ;) ) What I don=E2=80=99t understand is that we have an policy prohibiting code c= hurn like code optimization in cold path, but allow those micro cleanup of c= ode. Those cleanup also tend to be unregulated and is subject to personal ta= stes (for example, your CS teachers may have a different taste from mine). I= can understand developers want to have fun, but perhaps there are other pla= yground areas that worth taking more risk?=20=