From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235F3C4167B for ; Thu, 7 Dec 2023 11:27:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 857C16B006E; Thu, 7 Dec 2023 06:27:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 808126B0085; Thu, 7 Dec 2023 06:27:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A8E06B0088; Thu, 7 Dec 2023 06:27:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 528716B006E for ; Thu, 7 Dec 2023 06:27:19 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F3DD8160194 for ; Thu, 7 Dec 2023 11:27:18 +0000 (UTC) X-FDA: 81539796156.11.98DC863 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id 53C3840023 for ; Thu, 7 Dec 2023 11:27:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701948436; a=rsa-sha256; cv=none; b=tkd0k8vp9C8RJXpwRXDayKUk8eoCj257DnHeZFkpPoNM4Ze4szEg341oGJ7oYansw1tZk+ PO1T8zPsjywtBsE10YDch+GAEQ0j6Q8qgl4tUQhAsFEjl96uwCitpfj/YXZx9ivLvN7aRs iGfeZbwT0K3Onyk1xn6klCZVyoj4wuY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701948436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGwXy20djAkRDzUSPq0jXXd/LO92N4eXagBniWIQvig=; b=RkCnC3vwktxSzEXwnmprMJOQGW2U5xqG0c2Wn9e9w3371GvuDtIhgtuUbmIneNAqxnyp0D wHR/uxwH9BVGJWmekskE5RvVY1J+dEH6ZIDFdcIPwBBp+xDi/Q9vk65p0joC1QG0KCT45o z42M/VPcYWCDWAhir/JFxRtq9YfyRkc= Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SmBmP6BNDzWjZ5; Thu, 7 Dec 2023 19:26:13 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 19:27:09 +0800 Subject: Re: [PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page allocation To: Jakub Kicinski CC: , , , , Alexander Duyck , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Eric Dumazet , , , References: <20231205113444.63015-1-linyunsheng@huawei.com> <20231205113444.63015-3-linyunsheng@huawei.com> <20231206191539.06d955f3@kernel.org> From: Yunsheng Lin Message-ID: <68750375-bab1-916d-0415-ff873e75a875@huawei.com> Date: Thu, 7 Dec 2023 19:27:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20231206191539.06d955f3@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 53C3840023 X-Stat-Signature: c1xmxbc1sfwedbpnizogwtmng8h69b5c X-HE-Tag: 1701948434-800310 X-HE-Meta: U2FsdGVkX18RKsHMTnHa1UdqB71HkQC71CaYmLkHqFHlq1UN1V3KeJpH/j3cTEBFoi2ohnGLREnrsGnebUxCwseh1tu8YJbcu3YLP6pwNTAmX6jr2u2jqvOprCo88eSfQKfMMcqJYbUHy94K9ZdJZQg/63L0bnsvXgZeSCR/ogiER1xwr0onpA289nY227NVfM6dYpF9n9VQARsn1JPAKsrKKgtvVjRSBjz86U5R4FYwm/fbc/ElShwGIQotyjkFosQg27+2+GQQq3/fJ/g6vaCDfY1CGXwdvR7v0U52ekZcFThMcO1c/vFxAn48pYKr4Nui8aEGfdoP9Sd/CWsVxO61m/zRUdjOU1D7FPmn8fAnh/OOLl0IJ//VicK9nqOpbSORAToKC5ZBjt20GmbdMS5rWsGMK7D43Zo+kMe5iN0+JL/HDnpTmkcaTzeazT4tDuTnayOAASqnfL/ApsW6u8bAwH4d/UXVHlvQBYnXnuPDNqy9F07z+6jIJwuaenXcxS5KMZEA/+D2k4Yb24y/gqVswyJ93qBjZ1/9o+sO3W+PJu0/tWdV2QQfA2cE+tJtYfcVjD1l/hHsyT+HoJiZ0GepW6eVboer1s/o42RWB7F+KBijL9Yioh3YgqfmFC6TXZHGfX8bQt9KXnl4qgonkkcvb3W8DD0djvSYp/sOrseJ0i2YKrCq/xHYrHEGXkG104+fIY3vEzlcwqFFIVcjSTuOHp476mAow3IFNqRWqT0ByiGgEFGsP4pJjSFccudRpuiKQmSgw7B+dpUOYLbA7z6Tv1AuDOQsetQhgpGoa6ZZo1gfS8s8yh07Q5yY4zIpwSz+MMLqkcEHfIK0KKNuYZflVxnzc9/FZbjLcU2Tmnh0oQ7KmvjIm2qhmO/5IaJEz6o+UD998sreXloY1SITD9rHVQjzxgK30Q6XCvJQnRUtfSc6KHzAwgmbKagNHTrl5j5Yq3qGXc/SfBeGPqO h8suN6j+ nf2aYacGqOJ1r2p7n10ozJhd7t+Nkp8ZADjmSVycawi3KvXHCG3v6SwihjcCvPF9j3wMmJWOtjnHqRTXsF3b+jM4gxbh3cSXteU/G/aoDoB0mlUNqEgjihTZT2hesU6DpAFstwbc8FyCECPlkJQ+hbERx7S2Ubz33OgH59bRnmoLm0gubzW0/8hV8DrPxQH+QDmlP8PpCvL6vswWDDqQVmACa0/i9BVgngpNbxO/Ghf8xo9UcyobLw0oM0eQdXZ8xxapdpTtgppZs2v5ezicfFLB+ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/7 11:15, Jakub Kicinski wrote: > On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote: >> __GFP_DIRECT_RECLAIM is xor'd to avoid >> direct reclaim in skb_page_frag_refill(), but it is not >> xor'd in __page_frag_cache_refill(). > > xor is not the same thing as masking a bit off. You are right. Will use 'mask off', thanks. > The patch itself LGTM. > . >