Re: [PATCH] mm, oom: avoid printk() iteration under RCU

[Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>]

On 2019/07/18 9:31, Shakeel Butt wrote:
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>> index 8dc1811..cb6696b 100644
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -1246,6 +1246,7 @@ struct task_struct {
>>  #ifdef CONFIG_MMU
>>         struct task_struct              *oom_reaper_list;
>>  #endif
>> +       struct list_head                oom_victim_list;
> 
> Shouldn't there be INIT_LIST_HEAD(&tsk->oom_victim_list) somewhere?

Yes if we need to use list_empty(&tsk->oom_victim_list) test.
This patch does not use such test; tsk->oom_victim_list is initialized
by list_add_tail() inside the OOM killer.

> 
>>  #ifdef CONFIG_VMAP_STACK
>>         struct vm_struct                *stack_vm_area;
>>  #endif