From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E77C3064D for ; Tue, 2 Jul 2024 15:38:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3944F6B009D; Tue, 2 Jul 2024 11:38:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3442F6B00A1; Tue, 2 Jul 2024 11:38:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1975A6B00A2; Tue, 2 Jul 2024 11:38:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EC4A56B009D for ; Tue, 2 Jul 2024 11:38:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8E6E7C01B4 for ; Tue, 2 Jul 2024 15:38:27 +0000 (UTC) X-FDA: 82295219454.15.C04D662 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 2D0D840021 for ; Tue, 2 Jul 2024 15:38:23 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cejY4iZa; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719934681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iAzfxFyO9LwltD4YxV4jTJpadHiZLqH04rmYDKvnDWc=; b=cps210WX2Ulgx/uLJacouiEgzJ3pPPhbW7FyEn5hrz5d5GKY9FGOAFXr4zjSIeGVO82hxc HNvQrPmuA5OSrbnn8qeZp0ilMUQH+urezyFqQ3bldo2bZ5j4grqX03+hm2PW0bX+lavZTE SDNyjVbmW7cgZLOJ+CjMK0gyWA2ZO6k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719934681; a=rsa-sha256; cv=none; b=8OpyoXLb5P4FlTvEl01+DH5efIu3tqr8H46E4h2jAVhq3IxJ5F2FAk4w/87jK0VurLtU0L fxGwZ1TbA3BUpP+LV6Ue1VB+ajCdNul8/Ouy/SpksEVdSd/stApJAGwT3k6FlCVl6RS+on ysH2TX8xaNOgRce5p+cqVFmWqz7qitc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cejY4iZa; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719934703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iAzfxFyO9LwltD4YxV4jTJpadHiZLqH04rmYDKvnDWc=; b=cejY4iZaq/EMvgKAnfUcchZWsNbr9uIshcnTwW4xJgYvbbcSpgVzx//NpRMS0+GJmac1uO QTAy+cdhAMkegJrBd4sLv4aRhHsGhwDvAYDJpcqi7aN/tN+zPqmjcvKxb/FeEhhkv6vk4C rNbt0ao3MofZPAZN0bqXCL9xmKqOu6k= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-HstUpQzINuiKtVmqGt_FSA-1; Tue, 02 Jul 2024 11:38:22 -0400 X-MC-Unique: HstUpQzINuiKtVmqGt_FSA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ec4efbbb7aso38295931fa.2 for ; Tue, 02 Jul 2024 08:38:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719934700; x=1720539500; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iAzfxFyO9LwltD4YxV4jTJpadHiZLqH04rmYDKvnDWc=; b=w095kqiveE7FDpiS6PkvkqqquBpafwk3EvIOU+GYaZNFJeGKM0Iq4KLGYaQzXg6CdQ CBzVyEq5aww4wopnVqNp+b35snk1wutF8WL58H83+ujY4EJbvi/5JRbI5KMsEDxUtfCp iu26E1AnvLEiumDZRaTFCorjpinLN1rclljuakK3o0/sulR9veJquuUKemDoRbEOwRIN mOkxp61J2R3GBRyf8+xT1lFP0LgsZFyyKVUPQSu0IFUNIjGpeYnGi4HjK5+/phqjWzbl +PjfRCUHd5xNWLKxPy8Kjoi3Zam/5BCKjdgsc1axSfXBneCY0YNC0P7SBBm3dr5DyloV Hvcg== X-Gm-Message-State: AOJu0YwLOqiYD22i2b6LF0O5f2XAKiBcykD5MJMoy99WFUmuLBgqjr6B sbzS095fA4ZJniERxwH+TkC2I9fv+g9mw86D8YtKeP4NirMO4ZGUoIpW2v0AcQRY2t0LR6FmGZ9 03bPdA9OMfmOwvsr7hlgiU5qXEzqIiAEfcQWJ00jJYDWyog/S X-Received: by 2002:a2e:ab0b:0:b0:2ec:5945:62e9 with SMTP id 38308e7fff4ca-2ee5e6f60ccmr91090571fa.32.1719934699726; Tue, 02 Jul 2024 08:38:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8FsOViU0tLBkJ4MYGisQkin3IcHk046lhGDLNQonBPeFO9Vc5cI43qiofMRBy/LRH6fNcow== X-Received: by 2002:a2e:ab0b:0:b0:2ec:5945:62e9 with SMTP id 38308e7fff4ca-2ee5e6f60ccmr91090361fa.32.1719934699285; Tue, 02 Jul 2024 08:38:19 -0700 (PDT) Received: from [192.168.3.141] (p5b0c6364.dip0.t-ipconnect.de. [91.12.99.100]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c19eesm208322605e9.45.2024.07.02.08.38.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 08:38:18 -0700 (PDT) Message-ID: <686d3f32-45b0-4dd5-8954-e75748b9c946@redhat.com> Date: Tue, 2 Jul 2024 17:38:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: Fix khugepaged activation policy To: Ryan Roberts , Andrew Morton , Jonathan Corbet , Barry Song , Baolin Wang , Lance Yang , Yang Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240702144617.2291480-1-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2D0D840021 X-Stat-Signature: nbrbr69wz8m5ygn1t9mmm6c696k41hmc X-HE-Tag: 1719934703-494462 X-HE-Meta: U2FsdGVkX1+nET3myJg+bhe7kjFHcFrnIJEwdKkRLmpSrK6POg0ncSnMz1VirM1vmw1Q42jfOwTwbPdgZ1Ypdj4gJIwjKpZzJh1u65z5q6OQPXa6AoOgJ0zgY8GYolWOjeejdBW3Q8JIj1WSJShQuDKsXEo372PUXhTFo3iWmoso3T4G+W4EhiX2teXeCNTutBO3CZXZptNf8dajfbl3IQqBCcrXzmkCA4g1id+vpNEt5EKU0pHYF7HeLX6w7l6YMsd3QiQihZNmXQPy0aHHy+WXefXEy4MzC3VAKSPQh1KjK+dO0xD3D1zO+dEiSl1RqVfq8r0xWx+Anob+/vIZOl2xWlOsZqgeWElx0S60TcwZf2az/rrW22xWJ90CKCYsKbIFKPHzBwcaLlbwl/MBze9HfupfTif9UMSBYWdtTh1OLeuFUgHFeuHeqgZhan7U+dWNrdLezu6Se2dJUa+J+SxZmbgduyoIrXH8L3Ux+h9OwePwofKJt6rlKk96IlzxZ421KUENNt0w7M7+K2NUdLXkK1R9t6YwP5nxM4BWRPaF+4jprAVyEzIrPsrLO8Kkh1O46WDuwiOclV3346oUeDrGc0VfRqVgsG+sHGV1vng6x3BChQGa/Sfck4V8LtvecvJS5m3XpmkKZZVtGcbcOmB5NvceZrvzbPR1vjxwdwlWqfI8fvq1anIxx9gxBGsHCf88Lm7W+EPV+qCHBopt0zWBrf0s60vq3iGftnbHiM0VVyg/NkAFeenmI5GdVQXl5IaqeF3SKzVGSi5ss2VOrfS75oHlzccALXIml8qzDiBSuMuI3bGejHiM8X1KoKvjzvz8L5FPc8TrQlzBy2DcHCtrK288cXpgmNZhT/egg6AypJeifYC43YwA2ckwdxHocryQupn0P4wlQXpoCaDLYNyar/8CTqI8jjFliPsPE08K65Z7E8tdyk112zhfPvLjaqM4mZpl+0csCiCkXGo pWQoKP32 R/UJ+0HNGIHfwOkm5Pm7mY6y78egzJyc9+wSEy1a3/hJLxZs+2vndsW1GkU+Cu8XnGAp0HQfqO+x54JFLl5zvviwhswAu7R7/jOZZID6mBche49WgV7nuJQpALrBXN3UmYGvVZXI8wJcOOskQXmSG4as2q/VFay7tRHjjzYUgH8EQ9yVPUXN0oydsUdBEMYrGq0tGjU0Hwv2DJ2CiTz1mVRhC/mokmWiAWrU5tLp0UMSXJW2NVE82Tt0nBL/0QZNMJpIw00ZfgusLtciDFqE4mUn84NgAqILRKPo4v54Dem16lCfrIRCEnHoCnEVXZm8vQO2a0wh/0RqQagg7M7/bcLHF9lg/1YLHXfV50Vgnbk52oq+3UNxag2jgafhGMNfx+vNFM+VmNqVVuSsgTuTeVkyDLoHV2RxhuxLflq7icitDurQ/HVL6S49BBqZ2NzZF+FLFy6VFBS8UB4kHwDZIT/QvKmdUkqA1yTAyHC3b+gt3fQ6Gk2lV1Y1+Rt9C8wNpiPYYHMLRv8kbO5//YOMSiGyRQ6E+lSDf6zAcKyeh9d8YAdoIYUqfhJIZqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.24 17:29, Ryan Roberts wrote: > On 02/07/2024 15:57, David Hildenbrand wrote: >> On 02.07.24 16:46, Ryan Roberts wrote: >>> Since the introduction of mTHP, the docuementation has stated that >>> khugepaged would be enabled when any mTHP size is enabled, and disabled >>> when all mTHP sizes are disabled. There are 2 problems with this; 1. >>> this is not what was implemented by the code and 2. this is not the >>> desirable behavior. >>> >>> Desirable behavior is for khugepaged to be enabled when any PMD-sized >>> THP is enabled, anon or file. (Note that file THP is still controlled by >>> the top-level control so we must always consider that, as well as the >>> PMD-size mTHP control for anon). khugepaged only supports collapsing to >>> PMD-sized THP so there is no value in enabling it when PMD-sized THP is >>> disabled. So let's change the code and documentation to reflect this >>> policy. >>> >>> Further, per-size enabled control modification events were not >>> previously forwarded to khugepaged to give it an opportunity to start or >>> stop. Consequently the following was resulting in khugepaged eroneously >>> not being activated: >>> >>>    echo never > /sys/kernel/mm/transparent_hugepage/enabled >>>    echo always > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled >>> >>> Signed-off-by: Ryan Roberts >>> Fixes: 3485b88390b0 ("mm: thp: introduce multi-size THP sysfs interface") >>> Closes: >>> https://lore.kernel.org/linux-mm/7a0bbe69-1e3d-4263-b206-da007791a5c4@redhat.com/ >>> Cc: stable@vger.kernel.org >>> --- >>> >>> Hi All, >>> >>> Applies on top of today's mm-unstable (9bb8753acdd8). No regressions observed in >>> mm selftests. >>> >>> When fixing this I also noticed that khugepaged doesn't get (and never has been) >>> activated/deactivated by `shmem_enabled=`. I'm not sure if khugepaged knows how >>> to collapse shmem - perhaps it should be activated in this case? >>> >> >> Call me confused. >> >> khugepaged_scan_mm_slot() and madvise_collapse() only all >> hpage_collapse_scan_file() with ... IS_ENABLED(CONFIG_SHMEM) ? > > Looks like khugepaged_scan_mm_slot() was converted from: > > if (shmem_file(vma->vm_file)) { > > to: > > if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file) { > > By 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 which adds THP collapse support for > non-shmem files. Clearly that looks wrong, but I guess never spotted in practice > because noone disables shemem? > > I guess madvise_collapse() was a copy/paste? > Likely. >> >> collapse_file() is only called by hpage_collapse_scan_file() ... and there we >> check "shmem_file(file)". >> >> So why is the IS_ENABLED(CONFIG_SHMEM) check in there if collapse_file() seems >> to "collapse filemap/tmpfs/shmem pages into huge one". >> >> Anyhow, we certainly can collapse shmem (that's how it all started IIUC). > > Yes, thanks for pointing me at it. Should have just searched "shmem" in > khugepaged.c :-/ > >> >> Besides that, khugepaged only seems to collapse !shmem with >>   VM_BUG_ON(!IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) && !is_shmem); > > That makes sense. I guess I could use IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) to > tighen the (non-shmem) file THP check in hugepage_pmd_enabled() (currently I'm > unconditionally using the top-level enabled setting as a "is THP enabled for > files" check). > > But back to my original question, I think hugepage_pmd_enabled() should also be > explicitly checking the appropriate shmem_enabled controls and ORing in the > result? Otherwise in a situation where only shmem is THP enabled (and file/anon > THP is disabled) khugepaged won't run. I think so. > >> >> The thp_vma_allowable_order() check tests if we are allowed to collapse a >> PMD_ORDER in that VMA. > > I don't follow the relevance of this statement. On whatever VMA we indicate true, we will try to collapse in khugepaged. Regarding the question, what khugepaged will try to collapse. -- Cheers, David / dhildenb