From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D55C433F5 for ; Tue, 16 Nov 2021 17:01:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E334F61AA2 for ; Tue, 16 Nov 2021 17:01:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E334F61AA2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3C6D26B007B; Tue, 16 Nov 2021 12:01:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 375A96B007D; Tue, 16 Nov 2021 12:01:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 217536B007E; Tue, 16 Nov 2021 12:01:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 11B166B007B for ; Tue, 16 Nov 2021 12:01:31 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C3DEE86E79 for ; Tue, 16 Nov 2021 17:01:30 +0000 (UTC) X-FDA: 78815409540.16.DD9FB88 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id 1A49160890D4 for ; Tue, 16 Nov 2021 16:41:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E8EF91FD37; Tue, 16 Nov 2021 16:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1637080378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdNHsSJ0TUD00V1kkWXYSG/GlAFO0QPXtO8TfYkofSY=; b=MijUyi88lZ9DiijG3jxYOvHLk3fRiZzkR+fpqvw/u1z0LEueLN/0KUr7R3BvYU1M4z6aBE zhnvy154JcLZ4I5wXS7KnTyl7U7XczcEzaEGt54cc8nMDHqImnQ2IfYFGx830RQdTAkIlY 4ss7d7Tu0HfV1mYRx3tt0igHxDXiZps= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1637080378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdNHsSJ0TUD00V1kkWXYSG/GlAFO0QPXtO8TfYkofSY=; b=JKrI4zxYmDk0OoP0A4AGw4Uj1AYkJhYXTHuBPrGvh+prinKuWrhEVkFyZhC891suL7lvHV vhCNK4l3K5a0L5BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7CC0313C25; Tue, 16 Nov 2021 16:32:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id i4pYHDrdk2FtUQAAMHmgww (envelope-from ); Tue, 16 Nov 2021 16:32:58 +0000 Message-ID: <6866ad09-f765-0e8b-4821-8dbdc6d0f24e@suse.cz> Date: Tue, 16 Nov 2021 17:32:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [RFC PATCH 21/32] mm: Convert struct page to struct slab in functions used by other subsystems Content-Language: en-US To: Andrey Konovalov Cc: Matthew Wilcox , Linux Memory Management List , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Julia Lawall , Luis Chamberlain , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Johannes Weiner , Michal Hocko , Vladimir Davydov , kasan-dev , cgroups@vger.kernel.org References: <20211116001628.24216-1-vbabka@suse.cz> <20211116001628.24216-22-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MijUyi88; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JKrI4zxY; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1A49160890D4 X-Stat-Signature: 3kwr66s37bykr8jxota7htfnabyj4mqj X-HE-Tag: 1637080892-387553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/16/21 15:02, Andrey Konovalov wrote: >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -249,7 +249,7 @@ static void print_address_description(void *addr, u8 tag) >> >> if (page && PageSlab(page)) { >> struct kmem_cache *cache = page->slab_cache; >> - void *object = nearest_obj(cache, page, addr); >> + void *object = nearest_obj(cache, page_slab(page), addr); > > The tab before addr should be a space. checkpatch should probably report this. Good catch, thanks. Note the tab is there already before this patch, it just happened to appear identical to a single space before.